From nobody Sun Nov 9 13:12:02 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linux.intel.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1551166480598914.9291903441684; Mon, 25 Feb 2019 23:34:40 -0800 (PST) Received: from localhost ([127.0.0.1]:50831 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyXG7-0007br-Tp for importer@patchew.org; Tue, 26 Feb 2019 02:34:35 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58050) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyXEu-00078p-R8 for qemu-devel@nongnu.org; Tue, 26 Feb 2019 02:33:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gyXEq-00085d-Op for qemu-devel@nongnu.org; Tue, 26 Feb 2019 02:33:18 -0500 Received: from mga14.intel.com ([192.55.52.115]:35208) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gyXEn-0007rQ-87 for qemu-devel@nongnu.org; Tue, 26 Feb 2019 02:33:15 -0500 Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Feb 2019 23:32:29 -0800 Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by fmsmga008.fm.intel.com with ESMTP; 25 Feb 2019 23:32:27 -0800 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,414,1544515200"; d="scan'208";a="127300126" From: Wei Yang To: qemu-devel@nongnu.org, linux-kernel@vger.kernel.org Date: Tue, 26 Feb 2019 15:31:59 +0800 Message-Id: <20190226073159.13434-1-richardw.yang@linux.intel.com> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.115 Subject: [Qemu-devel] [PATCH] fw_cfg: use __ATTR_RO_MODE to define rev sysfs X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: somlo@cmu.edu, Wei Yang , mst@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Leverage __ATTR_RO_MODE to define rev sysfs instead of using open code to define the attribute. Signed-off-by: Wei Yang --- drivers/firmware/qemu_fw_cfg.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c index 039e0f91dba8..a1293cbd7adb 100644 --- a/drivers/firmware/qemu_fw_cfg.c +++ b/drivers/firmware/qemu_fw_cfg.c @@ -296,18 +296,13 @@ static int fw_cfg_do_platform_probe(struct platform_d= evice *pdev) return 0; } =20 -static ssize_t fw_cfg_showrev(struct kobject *k, struct attribute *a, char= *buf) +static ssize_t fw_cfg_rev_show(struct kobject *k, struct kobj_attribute *a, + char *buf) { return sprintf(buf, "%u\n", fw_cfg_rev); } - -static const struct { - struct attribute attr; - ssize_t (*show)(struct kobject *k, struct attribute *a, char *buf); -} fw_cfg_rev_attr =3D { - .attr =3D { .name =3D "rev", .mode =3D S_IRUSR }, - .show =3D fw_cfg_showrev, -}; +static const struct kobj_attribute fw_cfg_rev_attr =3D + __ATTR_RO_MODE(fw_cfg_rev, 0400); =20 /* fw_cfg_sysfs_entry type */ struct fw_cfg_sysfs_entry { --=20 2.19.1