From nobody Sun Nov 9 17:49:33 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1551125336160765.7925531820757; Mon, 25 Feb 2019 12:08:56 -0800 (PST) Received: from localhost ([127.0.0.1]:43682 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyMYX-0001qD-5J for importer@patchew.org; Mon, 25 Feb 2019 15:08:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49229) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyMTz-0006yV-M7 for qemu-devel@nongnu.org; Mon, 25 Feb 2019 15:04:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gyMTx-00014h-4y for qemu-devel@nongnu.org; Mon, 25 Feb 2019 15:04:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44780) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gyMTu-0000Ih-UC; Mon, 25 Feb 2019 15:04:07 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 40193883BC; Mon, 25 Feb 2019 20:03:28 +0000 (UTC) Received: from t460s.redhat.com (ovpn-116-61.ams2.redhat.com [10.36.116.61]) by smtp.corp.redhat.com (Postfix) with ESMTP id E12465D9CC; Mon, 25 Feb 2019 20:03:26 +0000 (UTC) From: David Hildenbrand To: qemu-devel@nongnu.org Date: Mon, 25 Feb 2019 21:03:14 +0100 Message-Id: <20190225200318.16102-4-david@redhat.com> In-Reply-To: <20190225200318.16102-1-david@redhat.com> References: <20190225200318.16102-1-david@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 25 Feb 2019 20:03:28 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 3/7] s390x/tcg: Clarify terminology in vec_reg_offset() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-s390x@nongnu.org, Cornelia Huck , David Hildenbrand , Thomas Huth , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" We will use s390x speak "Element Size" (es) for MO_8 =3D=3D 0, MO_16 =3D=3D= 1 ... Simple rename of variables. Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/translate.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/target/s390x/translate.c b/target/s390x/translate.c index c646e50eb3..5e3955e4d7 100644 --- a/target/s390x/translate.c +++ b/target/s390x/translate.c @@ -145,10 +145,11 @@ void s390x_translate_init(void) } } =20 -static inline int vec_reg_offset(uint8_t reg, uint8_t enr, TCGMemOp size) +static inline int vec_reg_offset(uint8_t reg, uint8_t enr, TCGMemOp es) { - const uint8_t es =3D 1 << size; - int offs =3D enr * es; + /* Convert element size (es) - e.g. MO_U8 - to bytes */ + const uint8_t bytes =3D 1 << es; + int offs =3D enr * bytes; =20 g_assert(reg < 32); /* @@ -173,9 +174,9 @@ static inline int vec_reg_offset(uint8_t reg, uint8_t e= nr, TCGMemOp size) * the two 8 byte elements have to be loaded separately. Let's force a= ll * 16 byte operations to handle it in a special way. */ - g_assert(size <=3D MO_64); + g_assert(es <=3D MO_64); #ifndef HOST_WORDS_BIGENDIAN - offs ^=3D (8 - es); + offs ^=3D (8 - bytes); #endif return offs + offsetof(CPUS390XState, vregs[reg][0].d); } --=20 2.17.2