From nobody Sun Nov 9 14:47:45 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1550931711267109.89398078874228; Sat, 23 Feb 2019 06:21:51 -0800 (PST) Received: from localhost ([127.0.0.1]:38574 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gxYBa-0001K4-3m for importer@patchew.org; Sat, 23 Feb 2019 09:21:50 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42519) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gxY71-0006Zk-47 for qemu-devel@nongnu.org; Sat, 23 Feb 2019 09:17:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gxY6z-0002Po-5U for qemu-devel@nongnu.org; Sat, 23 Feb 2019 09:17:07 -0500 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:53639) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gxY6y-0002Ou-4N for qemu-devel@nongnu.org; Sat, 23 Feb 2019 09:17:04 -0500 Received: by mail-wm1-x341.google.com with SMTP id e74so4315593wmg.3 for ; Sat, 23 Feb 2019 06:17:03 -0800 (PST) Received: from localhost.localdomain ([176.228.155.165]) by smtp.gmail.com with ESMTPSA id x3sm3310506wru.76.2019.02.23.06.17.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 23 Feb 2019 06:17:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ZVzbdqTRjmG8BdUYtofEXwDvTI2TpB37oXuH/eyntOs=; b=QmPlaV0O1GMtfYTqzb7IaBB98yp7BL5jTyr1fRrjjbYDH2qszTGi0hdGk8oeImhvRO 7r5t6gVplqys87DNmRFe1oaFqm6Dx7NKvIyguyGnoY6MOnsiN19lYEYZ9HOraD6ylUYW Zn+8iIKzBLD1REE7mnJpLSLwCjO6wiVgbAHciUo3flpuylDct2K6t7rMbigJ1rJqMTcz NuhGPHtJ8szAbShLSf0Mtyn9T0QvaqTloAQoQ6mw1+MBz1DO1FchV0SAg5RrGSaXmL5v EyeuopLqIyix42jAB7BmZODmYiBwJZfw7yg2jNPhlkxhnsR1jjQhLVDRjeMWGvOlrZrK /q9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ZVzbdqTRjmG8BdUYtofEXwDvTI2TpB37oXuH/eyntOs=; b=tHRDApcpFBmlDpUHRe0NeNdTQZB+b5/feO5GwUOO8ftaODsPA97VDZh+zkxRYw1mLZ nMrhFJzljSltaErXRV7M928+KpFSY+hhy6OIVX83BQs616lLipHRU5N5goTN0StKzQWt sUyQ2aa6UYMVEnqBKcQgivEwtMLmhhvToEhqcIP7kDV3b9U7WtadyXwmMw47nQE5Linw 6B4AgTuPCGhZLwJq2+DPcMI73hCfqpSEaAAy8dXfVioa4YzReRZUB8ekGl5yWV4NDbbw O9tz6Pu3kx2YpD4ehziXlyx1LORqWjUEMJocq5iQFgRL/o17V47qNe14pmk2vUm2neSH S/9g== X-Gm-Message-State: AHQUAubinIPr6DeUcJtyO/pR1ySDW/dcUQpNZOt2tAloGGx8pnajfwOm RzKKSsTw334wf0ltVcPnVRPwn3zt X-Google-Smtp-Source: AHgI3IZUmwRgQPjMrlyt5dZfqv1PF4uql+JRvW7m8at2xN4/mE35tWzmS3iGkrKUkSIITBLUzHxWEA== X-Received: by 2002:a1c:9ed7:: with SMTP id h206mr5251744wme.28.1550931421886; Sat, 23 Feb 2019 06:17:01 -0800 (PST) From: Marcel Apfelbaum To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Sat, 23 Feb 2019 16:16:41 +0200 Message-Id: <20190223141644.6609-9-marcel.apfelbaum@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190223141644.6609-1-marcel.apfelbaum@gmail.com> References: <20190223141644.6609-1-marcel.apfelbaum@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 Subject: [Qemu-devel] [PATCH PULL 08/11] hw/pvrdma: Delete unneeded function argument X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: philmd@redhat.com, kamalheib1@gmail.com, yuval.shaia@oracle.com, dgilbert@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Yuval Shaia The function argument rdma_dev_res is not needed as it is stored in the backend_dev object at init. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum Message-Id: <20190213065357.16076-9-yuval.shaia@oracle.com> Signed-off-by: Marcel Apfelbaum --- hw/rdma/rdma_backend.c | 13 ++++++------- hw/rdma/rdma_backend.h | 1 - hw/rdma/vmw/pvrdma_qp_ops.c | 3 +-- 3 files changed, 7 insertions(+), 10 deletions(-) diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c index 83a68057a7..4c994e9a39 100644 --- a/hw/rdma/rdma_backend.c +++ b/hw/rdma/rdma_backend.c @@ -594,7 +594,6 @@ static unsigned int save_mad_recv_buffer(RdmaBackendDev= *backend_dev, } =20 void rdma_backend_post_recv(RdmaBackendDev *backend_dev, - RdmaDeviceResources *rdma_dev_res, RdmaBackendQP *qp, uint8_t qp_type, struct ibv_sge *sge, uint32_t num_sge, void *c= tx) { @@ -613,9 +612,9 @@ void rdma_backend_post_recv(RdmaBackendDev *backend_dev, rc =3D save_mad_recv_buffer(backend_dev, sge, num_sge, ctx); if (rc) { complete_work(IBV_WC_GENERAL_ERR, rc, ctx); - rdma_dev_res->stats.mad_rx_bufs_err++; + backend_dev->rdma_dev_res->stats.mad_rx_bufs_err++; } else { - rdma_dev_res->stats.mad_rx_bufs++; + backend_dev->rdma_dev_res->stats.mad_rx_bufs++; } } return; @@ -625,7 +624,7 @@ void rdma_backend_post_recv(RdmaBackendDev *backend_dev, bctx->up_ctx =3D ctx; bctx->backend_qp =3D qp; =20 - rc =3D rdma_rm_alloc_cqe_ctx(rdma_dev_res, &bctx_id, bctx); + rc =3D rdma_rm_alloc_cqe_ctx(backend_dev->rdma_dev_res, &bctx_id, bctx= ); if (unlikely(rc)) { complete_work(IBV_WC_GENERAL_ERR, VENDOR_ERR_NOMEM, ctx); goto err_free_bctx; @@ -633,7 +632,7 @@ void rdma_backend_post_recv(RdmaBackendDev *backend_dev, =20 rdma_protected_gslist_append_int32(&qp->cqe_ctx_list, bctx_id); =20 - rc =3D build_host_sge_array(rdma_dev_res, new_sge, sge, num_sge, + rc =3D build_host_sge_array(backend_dev->rdma_dev_res, new_sge, sge, n= um_sge, &backend_dev->rdma_dev_res->stats.rx_bufs_le= n); if (rc) { complete_work(IBV_WC_GENERAL_ERR, rc, ctx); @@ -652,13 +651,13 @@ void rdma_backend_post_recv(RdmaBackendDev *backend_d= ev, } =20 atomic_inc(&backend_dev->rdma_dev_res->stats.missing_cqe); - rdma_dev_res->stats.rx_bufs++; + backend_dev->rdma_dev_res->stats.rx_bufs++; =20 return; =20 err_dealloc_cqe_ctx: backend_dev->rdma_dev_res->stats.rx_bufs_err++; - rdma_rm_dealloc_cqe_ctx(rdma_dev_res, bctx_id); + rdma_rm_dealloc_cqe_ctx(backend_dev->rdma_dev_res, bctx_id); =20 err_free_bctx: g_free(bctx); diff --git a/hw/rdma/rdma_backend.h b/hw/rdma/rdma_backend.h index cb5efa2a3a..5d507a1c41 100644 --- a/hw/rdma/rdma_backend.h +++ b/hw/rdma/rdma_backend.h @@ -111,7 +111,6 @@ void rdma_backend_post_send(RdmaBackendDev *backend_dev, union ibv_gid *dgid, uint32_t dqpn, uint32_t d= qkey, void *ctx); void rdma_backend_post_recv(RdmaBackendDev *backend_dev, - RdmaDeviceResources *rdma_dev_res, RdmaBackendQP *qp, uint8_t qp_type, struct ibv_sge *sge, uint32_t num_sge, void *c= tx); =20 diff --git a/hw/rdma/vmw/pvrdma_qp_ops.c b/hw/rdma/vmw/pvrdma_qp_ops.c index 16db726dac..508d8fca3c 100644 --- a/hw/rdma/vmw/pvrdma_qp_ops.c +++ b/hw/rdma/vmw/pvrdma_qp_ops.c @@ -231,8 +231,7 @@ void pvrdma_qp_recv(PVRDMADev *dev, uint32_t qp_handle) continue; } =20 - rdma_backend_post_recv(&dev->backend_dev, &dev->rdma_dev_res, - &qp->backend_qp, qp->qp_type, + rdma_backend_post_recv(&dev->backend_dev, &qp->backend_qp, qp->qp_= type, (struct ibv_sge *)&wqe->sge[0], wqe->hdr.nu= m_sge, comp_ctx); =20 --=20 2.17.1