From nobody Sun Nov 9 14:51:59 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1550805557289432.38555194159517; Thu, 21 Feb 2019 19:19:17 -0800 (PST) Received: from localhost ([127.0.0.1]:43436 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gx1Mk-0003lb-8P for importer@patchew.org; Thu, 21 Feb 2019 22:19:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40396) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gx1Ju-0002Az-09 for qemu-devel@nongnu.org; Thu, 21 Feb 2019 22:16:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gx1Jt-0002JW-1s for qemu-devel@nongnu.org; Thu, 21 Feb 2019 22:16:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57174) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gx1Js-0000Pi-OD for qemu-devel@nongnu.org; Thu, 21 Feb 2019 22:16:12 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A998D99CE8 for ; Fri, 22 Feb 2019 03:14:52 +0000 (UTC) Received: from xz-x1.redhat.com (ovpn-12-57.pek2.redhat.com [10.72.12.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2909A5D9D4; Fri, 22 Feb 2019 03:14:48 +0000 (UTC) From: Peter Xu To: qemu-devel@nongnu.org Date: Fri, 22 Feb 2019 11:14:13 +0800 Message-Id: <20190222031413.20250-5-peterx@redhat.com> In-Reply-To: <20190222031413.20250-1-peterx@redhat.com> References: <20190222031413.20250-1-peterx@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 22 Feb 2019 03:14:52 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 4/4] iothread: push gcontext earlier in the thread_fn X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , peterx@redhat.com, Stefan Hajnoczi , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" We were pushing the context until right before running the gmainloop. Now since we have everything unconditionally, we can move this earlier. One benefit is that now it's done even before init_done_sem, so as long as the iothread user calls iothread_create() and completes, we know that the thread stack is ready. Signed-off-by: Peter Xu --- iothread.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/iothread.c b/iothread.c index 9abdbace66..7b7cba5d04 100644 --- a/iothread.c +++ b/iothread.c @@ -53,7 +53,7 @@ static void *iothread_run(void *opaque) IOThread *iothread =3D opaque; =20 rcu_register_thread(); - + g_main_context_push_thread_default(iothread->worker_context); my_iothread =3D iothread; iothread->thread_id =3D qemu_get_thread_id(); qemu_sem_post(&iothread->init_done_sem); @@ -66,12 +66,11 @@ static void *iothread_run(void *opaque) * changed in previous aio_poll() */ if (iothread->running && atomic_read(&iothread->run_gcontext)) { - g_main_context_push_thread_default(iothread->worker_context); g_main_loop_run(iothread->main_loop); - g_main_context_pop_thread_default(iothread->worker_context); } } =20 + g_main_context_pop_thread_default(iothread->worker_context); rcu_unregister_thread(); return NULL; } --=20 2.17.1