From nobody Wed Apr 9 20:39:53 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1550776853438893.5941237815581; Thu, 21 Feb 2019 11:20:53 -0800 (PST) Received: from localhost ([127.0.0.1]:37218 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwttp-0002Vt-CR for importer@patchew.org; Thu, 21 Feb 2019 14:20:49 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53430) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwtcB-0004gb-NA for qemu-devel@nongnu.org; Thu, 21 Feb 2019 14:02:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gwtcA-0001yE-TY for qemu-devel@nongnu.org; Thu, 21 Feb 2019 14:02:35 -0500 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]:35287) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gwtcA-0001xq-NM for qemu-devel@nongnu.org; Thu, 21 Feb 2019 14:02:34 -0500 Received: by mail-pl1-x635.google.com with SMTP id p19so3387196plo.2 for ; Thu, 21 Feb 2019 11:02:34 -0800 (PST) Received: from cloudburst.twiddle.net (97-113-188-82.tukw.qwest.net. [97.113.188.82]) by smtp.gmail.com with ESMTPSA id v1sm19300675pff.9.2019.02.21.11.02.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Feb 2019 11:02:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=j++1cjJYjaYiU5QQ1AcrS0RVXtuDfk0nBs2HoastqKg=; b=OaSEsmIdQODi+g4kZhOchQMNnvwFDaXRM+G+0o9iEXd8Jov+3PKCMnd2BEmpvflYc7 SkRa0PlcfMI46U0ZwjZKbh76xXjMyQqqqufyPY3P7wHvEE0y0pXbNuadt6OAbcXWoWfC OE1m+8qLCNcjy1t9GRyfzlwv7uWv7xFJoGVMA/vc9hIkKn1SsIStiiEYdN68EofOVFyG aU7L9Py/ZJ7wlSjItHd+dSjAIPOUiFlivPf3lH1c33R/Gov/xylGlupm2Ih8pOatnRTc 9KTV4Vwvvhet6DkJ6rGIUd5JHVhPmzSLkrFwYvEKTcN8C4H7KkJ3HZWq7Lmd0HHyjrmX mXtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=j++1cjJYjaYiU5QQ1AcrS0RVXtuDfk0nBs2HoastqKg=; b=hkStmTzpGRQBuZfjJlb3nXE0hs8UmC4uUwK6oaF3Ri1acDjv/w+F30EX2KTmSpFhHd +z+18BN1l19HCy3BUik/xIbJati9wBGTc0NlhRaGfEi8/vv25K7XE6ZkHGrtYIpIfAv3 Knco/Oe/4OxXlL5PYyAl2wg+WZ+eVH/0QKGjIbriu8339g9hZW0N83LNZCFbj7MNb4Ff 3/IMwXJA7V7rQ3tEQNEtVeM/koRd+scPvkjNjvIMcx72Y3+koTfTo/GDAJyOctxo8k6u 3VtyaYjJ6T89zkrNGRRUbYU7VHLMvk4spZoLUcr9vMwU2s10Ob07c3OMEzbDA+XWakoF Fjqw== X-Gm-Message-State: AHQUAua9Es8uaMLWSpFgkpD1tFGyysviEunZ4pjSyMXp8efak6PM0eBs ID3osaYutW2hLSeNGt4qtB4Zkc9O4Iw= X-Google-Smtp-Source: AHgI3Iaj2XEEiMaOOEBjJWyFbe4al5WmeQ6c3K9VGXgDdeN4aCQ1i3c7MNUFrtcfk2jE5AYwMh0Gbg== X-Received: by 2002:a17:902:46a4:: with SMTP id p33mr69332pld.48.1550775753361; Thu, 21 Feb 2019 11:02:33 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 21 Feb 2019 11:02:29 -0800 Message-Id: <20190221190229.22599-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190221190229.22599-1-richard.henderson@linaro.org> References: <20190221190229.22599-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::635 Subject: [Qemu-devel] [PULL 2/2] include/exec/helper-head.h: support "const void *" in helper calls X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, David Hildenbrand Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: David Hildenbrand Especially when dealing with out-of-line gvec helpers, it is often helpful to specify some vector pointers as constant. E.g. when we have two inputs and one output, marking the two inputs as consts pointers helps to avoid bugs. Const pointers can be specified via "cptr", however behave in TCG just like ordinary pointers. We can specify helpers like: DEF_HELPER_FLAGS_4(gvec_vbperm, TCG_CALL_NO_RWG, void, ptr, cptr, cptr, i32) void HELPER(gvec_vbperm)(void *v1, const void *v2, const void *v3, uint32_t desc) And make sure that here, only v1 will be written (as long as const is not casted away, of course). Signed-off-by: David Hildenbrand Message-Id: <20190221093459.22547-1-david@redhat.com> Signed-off-by: Richard Henderson --- include/exec/helper-head.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/include/exec/helper-head.h b/include/exec/helper-head.h index ab4f8b6623..f2519c9741 100644 --- a/include/exec/helper-head.h +++ b/include/exec/helper-head.h @@ -30,6 +30,7 @@ #define dh_alias_f32 i32 #define dh_alias_f64 i64 #define dh_alias_ptr ptr +#define dh_alias_cptr ptr #define dh_alias_void void #define dh_alias_noreturn noreturn #define dh_alias(t) glue(dh_alias_, t) @@ -43,6 +44,7 @@ #define dh_ctype_f32 float32 #define dh_ctype_f64 float64 #define dh_ctype_ptr void * +#define dh_ctype_cptr const void * #define dh_ctype_void void #define dh_ctype_noreturn void QEMU_NORETURN #define dh_ctype(t) dh_ctype_##t @@ -88,6 +90,7 @@ #define dh_is_64bit_i32 0 #define dh_is_64bit_i64 1 #define dh_is_64bit_ptr (sizeof(void *) =3D=3D 8) +#define dh_is_64bit_cptr dh_is_64bit_ptr #define dh_is_64bit(t) glue(dh_is_64bit_, dh_alias(t)) =20 #define dh_is_signed_void 0 @@ -105,6 +108,7 @@ extension instructions that may be required, e.g. ia64's addp4. But for now we don't support any 64-bit targets with 32-bit pointers. */ #define dh_is_signed_ptr 0 +#define dh_is_signed_cptr dh_is_signed_ptr #define dh_is_signed_env dh_is_signed_ptr #define dh_is_signed(t) dh_is_signed_##t =20 @@ -117,6 +121,7 @@ #define dh_callflag_f32 0 #define dh_callflag_f64 0 #define dh_callflag_ptr 0 +#define dh_callflag_cptr dh_callflag_ptr #define dh_callflag_void 0 #define dh_callflag_noreturn TCG_CALL_NO_RETURN #define dh_callflag(t) glue(dh_callflag_, dh_alias(t)) --=20 2.17.2