From nobody Fri Nov 7 03:57:01 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1550748545950897.2438329949823; Thu, 21 Feb 2019 03:29:05 -0800 (PST) Received: from localhost ([127.0.0.1]:58598 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwmXF-0003dy-Ug for importer@patchew.org; Thu, 21 Feb 2019 06:29:01 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34719) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwmCS-00025e-3g for qemu-devel@nongnu.org; Thu, 21 Feb 2019 06:07:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gwmCO-0006u9-IC for qemu-devel@nongnu.org; Thu, 21 Feb 2019 06:07:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34736) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gwmCL-0006qf-1E for qemu-devel@nongnu.org; Thu, 21 Feb 2019 06:07:26 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4D1DC308FC22 for ; Thu, 21 Feb 2019 11:07:22 +0000 (UTC) Received: from localhost (ovpn-112-68.ams2.redhat.com [10.36.112.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id E00871001DD1; Thu, 21 Feb 2019 11:07:19 +0000 (UTC) From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= To: qemu-devel@nongnu.org Date: Thu, 21 Feb 2019 12:06:57 +0100 Message-Id: <20190221110703.5775-6-marcandre.lureau@redhat.com> In-Reply-To: <20190221110703.5775-1-marcandre.lureau@redhat.com> References: <20190221110703.5775-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Thu, 21 Feb 2019 11:07:22 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v3 05/11] spice: do not stop spice if VM is paused X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kraxel@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" spice_server_vm_start/stop() was added to help migration state (commit f5bb039c6d97ef3e664094eab3c9a4dc1824ed73). However, a paused VM could keep running the spice server. This will allow a Spice client to keep sending commands to a spice chardev. This allows to stop/cont a VM from a Spice monitor port. Character devices (vdagent/usb/smartcard/..) should not read from Spice when the VM is paused. Signed-off-by: Marc-Andr=C3=A9 Lureau Tested-by: Victor Toso --- ui/spice-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index 91d0960522..92eebe5f0e 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -627,7 +627,7 @@ static void vm_change_state_handler(void *opaque, int r= unning, { if (running) { qemu_spice_display_start(); - } else { + } else if (state !=3D RUN_STATE_PAUSED) { qemu_spice_display_stop(); } } --=20 2.21.0.rc1