From nobody Sun Nov 9 11:36:02 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1550657100206219.71671906761912; Wed, 20 Feb 2019 02:05:00 -0800 (PST) Received: from localhost ([127.0.0.1]:37204 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwOkI-00086Q-6T for importer@patchew.org; Wed, 20 Feb 2019 05:04:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39982) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwOiA-00070J-4U for qemu-devel@nongnu.org; Wed, 20 Feb 2019 05:02:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gwOi8-00035R-Gv for qemu-devel@nongnu.org; Wed, 20 Feb 2019 05:02:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43538) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gwOi8-000356-7r for qemu-devel@nongnu.org; Wed, 20 Feb 2019 05:02:40 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 83B1FC05D41E for ; Wed, 20 Feb 2019 10:02:39 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-228.ams2.redhat.com [10.36.116.228]) by smtp.corp.redhat.com (Postfix) with ESMTP id B32BE19C70; Wed, 20 Feb 2019 10:02:36 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id ECF0711AAB; Wed, 20 Feb 2019 11:02:35 +0100 (CET) From: Gerd Hoffmann To: qemu-devel@nongnu.org Date: Wed, 20 Feb 2019 11:02:35 +0100 Message-Id: <20190220100235.20914-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 20 Feb 2019 10:02:39 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] kbd-state: don't block auto-repeat events X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrang=C3=A9 --- ui/kbd-state.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/ui/kbd-state.c b/ui/kbd-state.c index ac14add70e..09e3cfedfc 100644 --- a/ui/kbd-state.c +++ b/ui/kbd-state.c @@ -42,14 +42,18 @@ void qkbd_state_key_event(QKbdState *kbd, QKeyCode qcod= e, bool down) { bool state =3D test_bit(qcode, kbd->keys); =20 - if (state =3D=3D down) { + if (down =3D=3D false /* got key-up event */ && + state =3D=3D false /* key is not pressed */) { /* - * Filter out events which don't change the keyboard state. + * Filter out suspious key-up events. * - * Most notably this allows to simply send along all key-up - * events, and this function will filter out everything where - * the corresponding key-down event wasn't send to the guest, - * for example due to being a host hotkey. + * This allows to simply send along all key-up events, and + * this function will filter out everything where the + * corresponding key-down event wasn't send to the guest, for + * example due to being a host hotkey. + * + * Note that key-down events on already pressed keys are *not* + * suspious, those are keyboard autorepeat events. */ return; } --=20 2.9.3