From nobody Sun Nov 9 14:46:31 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1550625837680887.6614151913598; Tue, 19 Feb 2019 17:23:57 -0800 (PST) Received: from localhost ([127.0.0.1]:57583 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwGc6-0006lW-JW for importer@patchew.org; Tue, 19 Feb 2019 20:23:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41086) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwGQp-00052u-1P for qemu-devel@nongnu.org; Tue, 19 Feb 2019 20:12:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gwGJ3-0001nT-Uw for qemu-devel@nongnu.org; Tue, 19 Feb 2019 20:04:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44062) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gwGJ3-0001aT-HK; Tue, 19 Feb 2019 20:04:13 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 405BA81F19; Wed, 20 Feb 2019 01:03:46 +0000 (UTC) Received: from x1w.redhat.com (unknown [10.40.205.222]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4679C1001E7E; Wed, 20 Feb 2019 01:03:23 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Prasad J Pandit , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini Date: Wed, 20 Feb 2019 02:02:10 +0100 Message-Id: <20190220010232.18731-4-philmd@redhat.com> In-Reply-To: <20190220010232.18731-1-philmd@redhat.com> References: <20190220010232.18731-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 20 Feb 2019 01:03:46 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v3 03/25] chardev/wctablet: Use unsigned type to hold unsigned value X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard , Stefano Stabellini , Samuel Thibault , Li Zhijian , Amit Shah , "Michael S. Tsirkin" , Jason Wang , Cornelia Huck , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, Paul Durrant , qemu-ppc@nongnu.org, Gerd Hoffmann , Pavel Dovgalyuk , Zhang Chen , Anthony Perard , xen-devel@lists.xenproject.org, Stefan Berger , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" TabletChardev::query is an array of uint8_t. Use the same type to hold it (this also silent a -Wsign-conversion warning in the trace function). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Gerd Hoffmann Reviewed-by: Marc-Andr=C3=A9 Lureau --- chardev/trace-events | 2 +- chardev/wctablet.c | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/chardev/trace-events b/chardev/trace-events index d0e5f3bbc1..562bfe70e9 100644 --- a/chardev/trace-events +++ b/chardev/trace-events @@ -5,7 +5,7 @@ wct_init(void) "" wct_cmd_re(void) "" wct_cmd_st(void) "" wct_cmd_sp(void) "" -wct_cmd_ts(int input) "0x%02x" +wct_cmd_ts(uint8_t input) "0x%02x" wct_cmd_other(const char *cmd) "%s" wct_speed(int speed) "%d" =20 diff --git a/chardev/wctablet.c b/chardev/wctablet.c index 35dbd29a33..cf7a08a363 100644 --- a/chardev/wctablet.c +++ b/chardev/wctablet.c @@ -207,7 +207,8 @@ static int wctablet_chr_write(struct Chardev *chr, const uint8_t *buf, int len) { TabletChardev *tablet =3D WCTABLET_CHARDEV(chr); - unsigned int i, clen; + size_t i; + unsigned int clen; char *pos; =20 if (tablet->line_speed !=3D 9600) { @@ -269,7 +270,7 @@ static int wctablet_chr_write(struct Chardev *chr, =20 } else if (strncmp((char *)tablet->query, "TS", 2) =3D=3D 0 && clen =3D=3D 3) { - unsigned int input =3D tablet->query[2]; + uint8_t input =3D tablet->query[2]; uint8_t codes[7] =3D { 0xa3, ((input & 0x80) =3D=3D 0) ? 0x7e : 0x7f, --=20 2.20.1