From nobody Fri Apr 19 09:42:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1550501897133444.64239044264343; Mon, 18 Feb 2019 06:58:17 -0800 (PST) Received: from localhost ([127.0.0.1]:59973 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gvkN3-0002aF-5M for importer@patchew.org; Mon, 18 Feb 2019 09:58:13 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38803) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gvjwz-0005h7-E6 for qemu-devel@nongnu.org; Mon, 18 Feb 2019 09:31:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gvjwv-0002i5-Fr for qemu-devel@nongnu.org; Mon, 18 Feb 2019 09:31:15 -0500 Received: from ozlabs.org ([2401:3900:2:1::2]:48771) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gvjwu-0002bO-1S; Mon, 18 Feb 2019 09:31:13 -0500 Received: by ozlabs.org (Postfix, from userid 1007) id 4435rf5RP2z9sPh; Tue, 19 Feb 2019 01:30:57 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1550500258; bh=+VuCWlQx9dzy5TKAswfzKDl04tz4gSB7fDtvxAz/31A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FfIX3mkqujck2N/U1hZa3V91zsJYRtEQ4fBcBLQhysSd64X4axv2whynpQ9cNcyNG OnzXXHaQeRwKe/i47gFwUc+uvavrbskmQcdkFT8hqnFP0TiJMK/c8o8y/uFQ/yyuE9 GqEwGEbRA3Bbwgad1QSjA7f9OtnkjvinEjp26nG0= From: David Gibson To: peter.maydell@linaro.org Date: Tue, 19 Feb 2019 01:30:15 +1100 Message-Id: <20190218143049.17142-10-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190218143049.17142-1-david@gibson.dropbear.id.au> References: <20190218143049.17142-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 Subject: [Qemu-devel] [PULL 09/43] target/ppc: Remove some #if 0'ed code X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: groug@kaod.org, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, clg@kaod.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Benjamin Herrenschmidt Some debug stuff we don't need to keep there Signed-off-by: Benjamin Herrenschmidt Signed-off-by: C=C3=A9dric Le Goater Message-Id: <20190128094625.4428-7-clg@kaod.org> Signed-off-by: David Gibson --- target/ppc/excp_helper.c | 12 ------------ target/ppc/mmu_helper.c | 12 ------------ 2 files changed, 24 deletions(-) diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c index 0ec7ae1ad4..751d759fcc 100644 --- a/target/ppc/excp_helper.c +++ b/target/ppc/excp_helper.c @@ -748,13 +748,7 @@ void ppc_cpu_do_interrupt(CPUState *cs) static void ppc_hw_interrupt(CPUPPCState *env) { PowerPCCPU *cpu =3D ppc_env_get_cpu(env); -#if 0 - CPUState *cs =3D CPU(cpu); =20 - qemu_log_mask(CPU_LOG_INT, "%s: %p pending %08x req %08x me %d ee %d\n= ", - __func__, env, env->pending_interrupts, - cs->interrupt_request, (int)msr_me, (int)msr_ee); -#endif /* External reset */ if (env->pending_interrupts & (1 << PPC_INTERRUPT_RESET)) { env->pending_interrupts &=3D ~(1 << PPC_INTERRUPT_RESET); @@ -797,12 +791,6 @@ static void ppc_hw_interrupt(CPUPPCState *env) if (msr_ce !=3D 0) { /* External critical interrupt */ if (env->pending_interrupts & (1 << PPC_INTERRUPT_CEXT)) { - /* Taking a critical external interrupt does not clear the ext= ernal - * critical interrupt status - */ -#if 0 - env->pending_interrupts &=3D ~(1 << PPC_INTERRUPT_CEXT); -#endif powerpc_excp(cpu, env->excp_model, POWERPC_EXCP_CRITICAL); return; } diff --git a/target/ppc/mmu_helper.c b/target/ppc/mmu_helper.c index cefed34da4..bcf19da61d 100644 --- a/target/ppc/mmu_helper.c +++ b/target/ppc/mmu_helper.c @@ -1415,10 +1415,6 @@ static int get_physical_address_wtlb( bool real_mode =3D (access_type =3D=3D ACCESS_CODE && msr_ir =3D=3D 0) || (access_type !=3D ACCESS_CODE && msr_dr =3D=3D 0); =20 -#if 0 - qemu_log("%s\n", __func__); -#endif - switch (env->mmu_model) { case POWERPC_MMU_SOFT_6xx: case POWERPC_MMU_SOFT_74xx: @@ -1468,10 +1464,6 @@ static int get_physical_address_wtlb( cpu_abort(CPU(cpu), "Unknown or invalid MMU model\n"); return -1; } -#if 0 - qemu_log("%s address " TARGET_FMT_lx " =3D> %d " TARGET_FMT_plx "\n", - __func__, eaddr, ret, ctx->raddr); -#endif =20 return ret; } @@ -1805,10 +1797,6 @@ static int cpu_ppc_handle_mmu_fault(CPUPPCState *env= , target_ulong address, break; } } -#if 0 - printf("%s: set exception to %d %02x\n", __func__, - cs->exception, env->error_code); -#endif ret =3D 1; } =20 --=20 2.20.1