From nobody Tue May 7 04:07:57 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 15504035502071007.100988146783; Sun, 17 Feb 2019 03:39:10 -0800 (PST) Received: from localhost ([127.0.0.1]:39723 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gvKmc-0000bY-AM for importer@patchew.org; Sun, 17 Feb 2019 06:38:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33189) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gvKlf-0000HQ-Tu for qemu-devel@nongnu.org; Sun, 17 Feb 2019 06:37:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gvKlW-00059Y-EV for qemu-devel@nongnu.org; Sun, 17 Feb 2019 06:37:48 -0500 Received: from smtp.duncanthrax.net ([2001:470:70c5:1111::170]:54559) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gvKlT-000583-7r for qemu-devel@nongnu.org; Sun, 17 Feb 2019 06:37:44 -0500 Received: from hsi-kbw-109-193-150-175.hsi7.kabel-badenwuerttemberg.de ([109.193.150.175] helo=t470p.stackframe.org) by smtp.eurescom.eu with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1gvKlM-0008N5-SJ; Sun, 17 Feb 2019 12:37:36 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=duncanthrax.net; s=dkim; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From; bh=ZqTxfXTBy2aDU7h4KKUiYH6lQQHNwIevqRXfIPPz0/8=; b=Ivp/UN3M4g1b16tIEmPuRTWNW3 f+MpknNGpy8a3llotaBEcP0dvD/ITdz8z1OBEJTkGJrJjQ45mKoIOIdDjQx8A7Eb/KiGYQwHmKttW tzIzDG+EqSn3wNA82Feh9sJdPfioSOupMDobuhwkFDsAtoXm+jvd8sn3ipQZ2yyk2ZI0=; From: Sven Schnelle To: qemu-devel@nongnu.org Date: Sun, 17 Feb 2019 12:37:17 +0100 Message-Id: <20190217113717.7077-1-svens@stackframe.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:470:70c5:1111::170 Subject: [Qemu-devel] [PATCH] lsi: check if SIGP bit is already set in Wait reselect X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Paolo Bonzini , Helge Deller , Sven Schnelle Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" If SIGP is set, the 'Wait for Reselection' command should jump immediately to the address stored in the second DWORD of the instruction. This fixes spurious hangs in the HP-UX 11.11 installer when the SIGP bit gets set by the kernel before the 'Wait for Reselection' command is executed by SCRIPTS. Signed-off-by: Sven Schnelle Tested-by: Helge Deller --- hw/scsi/lsi53c895a.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c index 8ba07f8756..bcff859bac 100644 --- a/hw/scsi/lsi53c895a.c +++ b/hw/scsi/lsi53c895a.c @@ -1297,8 +1297,10 @@ again: } break; case 2: /* Wait Reselect */ - if (!lsi_irq_on_rsl(s)) { - lsi_wait_reselect(s); + if (s->istat0 & LSI_ISTAT0_SIGP) { + s->dsp =3D s->dnad; + } else if (!lsi_irq_on_rsl(s)) { + lsi_wait_reselect(s); } break; case 3: /* Set */ --=20 2.20.1