From nobody Sat Nov 8 06:05:57 2025 Delivered-To: importer@patchew.org Received-SPF: temperror (zoho.com: Error in retrieving data from DNS) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1550094904925708.3160297256478; Wed, 13 Feb 2019 13:55:04 -0800 (PST) Received: from localhost ([127.0.0.1]:35595 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gu2UX-0005cn-I2 for importer@patchew.org; Wed, 13 Feb 2019 16:54:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48318) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gu1vQ-000782-D6 for qemu-devel@nongnu.org; Wed, 13 Feb 2019 16:18:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gu1vP-0002tI-MV for qemu-devel@nongnu.org; Wed, 13 Feb 2019 16:18:36 -0500 Received: from relay12.mail.gandi.net ([217.70.178.232]:40297) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gu1vP-0002qb-33 for qemu-devel@nongnu.org; Wed, 13 Feb 2019 16:18:35 -0500 Received: from localhost (lfbn-tou-1-411-96.w86-206.abo.wanadoo.fr [86.206.237.96]) (Authenticated sender: thomas.petazzoni@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 7494F200003; Wed, 13 Feb 2019 21:18:30 +0000 (UTC) From: Thomas Petazzoni To: qemu-devel@nongnu.org Date: Wed, 13 Feb 2019 22:18:27 +0100 Message-Id: <20190213211827.20300-1-thomas.petazzoni@bootlin.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 217.70.178.232 X-Mailman-Approved-At: Wed, 13 Feb 2019 16:54:01 -0500 Subject: [Qemu-devel] [PATCH] configure: improve usbfs check X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Petazzoni Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" The current check to test if usbfs support should be compiled or not solely relies on the presence of , without actually checking that all definition used by Qemu are provided by this header file. With sufficiently old kernel headers, may be present, but some of the definitions needed by Qemu may not be available. This commit improves the check by building a small program that actually tests whether the necessary definitions are available. In addition, it fixes a bug where have_usbfs was set to "yes" regardless of the result of the test. Signed-off-by: Thomas Petazzoni Reviewed-by: Thomas Huth --- configure | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 3d89870d99..799c8e3b08 100755 --- a/configure +++ b/configure @@ -4266,10 +4266,25 @@ fi # check for usbfs have_usbfs=3Dno if test "$linux_user" =3D "yes"; then - if check_include linux/usbdevice_fs.h; then + cat > $TMPC << EOF +#include + +#ifndef USBDEVFS_GET_CAPABILITIES +#error "USBDEVFS_GET_CAPABILITIES undefined" +#endif + +#ifndef USBDEVFS_DISCONNECT_CLAIM +#error "USBDEVFS_DISCONNECT_CLAIM undefined" +#endif + +int main(void) +{ + return 0; +} +EOF + if compile_prog "" ""; then have_usbfs=3Dyes fi - have_usbfs=3Dyes fi =20 # check for fallocate --=20 2.20.1