[Qemu-devel] [PATCH 0/4] nbd: non-blocking negotiation

Vladimir Sementsov-Ogievskiy posted 4 patches 5 years, 1 month ago
Test docker-mingw@fedora passed
Test asan passed
Test checkpatch passed
Test docker-clang@ubuntu passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190211125601.86533-1-vsementsov@virtuozzo.com
Maintainers: Eric Blake <eblake@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>
include/io/channel.h |   9 +++
block/nbd-client.c   |  10 +--
io/channel.c         |   5 ++
nbd/client.c         | 149 ++++++++++++++++++++++++++++++++++---------
nbd/common.c         |   6 +-
nbd/server.c         |  45 +++++--------
nbd/trace-events     |  15 ++---
7 files changed, 161 insertions(+), 78 deletions(-)
[Qemu-devel] [PATCH 0/4] nbd: non-blocking negotiation
Posted by Vladimir Sementsov-Ogievskiy 5 years, 1 month ago
Hi all!

Here is a try of moving to non-blocking negotiation in nbd
code, proposed by Deniel in
https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg03817.html

in thread "[PATCH v4 00/10] NBD reconnect"
https://lists.gnu.org/archive/html/qemu-devel/2018-07/msg05973.html

Vladimir Sementsov-Ogievskiy (4):
  io/channel: add qio_channel_get_attached_aio_context()
  nbd/client: do negotiation in coroutine
  nbd: do qemu_coroutine_yield during tls handshake
  block/nbd-client: use non-blocking io channel for nbd negotiation

 include/io/channel.h |   9 +++
 block/nbd-client.c   |  10 +--
 io/channel.c         |   5 ++
 nbd/client.c         | 149 ++++++++++++++++++++++++++++++++++---------
 nbd/common.c         |   6 +-
 nbd/server.c         |  45 +++++--------
 nbd/trace-events     |  15 ++---
 7 files changed, 161 insertions(+), 78 deletions(-)

-- 
2.18.0


Re: [Qemu-devel] [PATCH 0/4] nbd: non-blocking negotiation
Posted by Eric Blake 5 years ago
On 2/11/19 6:55 AM, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
> 
> Here is a try of moving to non-blocking negotiation in nbd
> code, proposed by Deniel in
> https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg03817.html
> 
> in thread "[PATCH v4 00/10] NBD reconnect"
> https://lists.gnu.org/archive/html/qemu-devel/2018-07/msg05973.html
> 
> Vladimir Sementsov-Ogievskiy (4):
>   io/channel: add qio_channel_get_attached_aio_context()
>   nbd/client: do negotiation in coroutine
>   nbd: do qemu_coroutine_yield during tls handshake
>   block/nbd-client: use non-blocking io channel for nbd negotiation

Will there be a v2 of this series?  Soft freeze for 4.0 is coming up
very rapidly, so I'm trying to gauge if this is still 4.0 material (and
I should hold off my NBD queue for a chance to include it) or if it is
more likely to slip into 4.1 (and I should post my NBD pull request
sooner to avoid burdening Peter with a last-minute rush next week).

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH 0/4] nbd: non-blocking negotiation
Posted by Vladimir Sementsov-Ogievskiy 5 years ago
06.03.2019 19:11, Eric Blake wrote:
> On 2/11/19 6:55 AM, Vladimir Sementsov-Ogievskiy wrote:
>> Hi all!
>>
>> Here is a try of moving to non-blocking negotiation in nbd
>> code, proposed by Deniel in
>> https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg03817.html
>>
>> in thread "[PATCH v4 00/10] NBD reconnect"
>> https://lists.gnu.org/archive/html/qemu-devel/2018-07/msg05973.html
>>
>> Vladimir Sementsov-Ogievskiy (4):
>>    io/channel: add qio_channel_get_attached_aio_context()
>>    nbd/client: do negotiation in coroutine
>>    nbd: do qemu_coroutine_yield during tls handshake
>>    block/nbd-client: use non-blocking io channel for nbd negotiation
> 
> Will there be a v2 of this series?  Soft freeze for 4.0 is coming up
> very rapidly, so I'm trying to gauge if this is still 4.0 material (and
> I should hold off my NBD queue for a chance to include it) or if it is
> more likely to slip into 4.1 (and I should post my NBD pull request
> sooner to avoid burdening Peter with a last-minute rush next week).
> 

I decided to go another way as I really unsure about using all this staff
in a context of the thread in nbd server. And it'll be 1-2 patches.
Possibly, they'll be ready on March 9.

On the other hand, the most interest part is nbd-reconnect series and it
doesn't seem feasible to finish it for 4.0. (it's possible that March 9
would be the only my working day from 7-11)

So, I think, let's move this all to 4.1.


-- 
Best regards,
Vladimir