[Qemu-devel] [PULL 0/3] Linux user for 4.0 patches

Laurent Vivier posted 3 patches 10 weeks ago
Test docker-mingw@fedora passed
Test asan passed
Test checkpatch failed
Test docker-clang@ubuntu passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190207105347.22337-1-laurent@vivier.eu
linux-user/fd-trans.c |  8 ++++++
linux-user/syscall.c  | 67 +++++++++++++++++++++++++------------------
2 files changed, 47 insertions(+), 28 deletions(-)

[Qemu-devel] [PULL 0/3] Linux user for 4.0 patches

Posted by Laurent Vivier 10 weeks ago
The following changes since commit 47994e16b1d66411953623e7c0bf0cdcd50bd507:

  Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20190205' into staging (2019-02-05 18:25:07 +0000)

are available in the Git repository at:

  git://github.com/vivier/qemu.git tags/linux-user-for-4.0-pull-request

for you to fetch changes up to 0c1beacdb528319fd446b8d44bc540d4d8fb7504:

  linux-user: add new netlink types (2019-02-07 11:51:13 +0100)

----------------------------------------------------------------
- add new netlink type from linux v4.18 and v4.19
- fix coverity warning (CID 1390634)
- fix ioctl(SIOCGIFCONF) crash

----------------------------------------------------------------

Kan Li (1):
  Fix linux-user crashes in ioctl(SIOCGIFCONF) when ifc_buf is NULL.

Laurent Vivier (1):
  linux-user: add new netlink types

Peter Maydell (1):
  linux-user: Check sscanf return value in open_net_route()

 linux-user/fd-trans.c |  8 ++++++
 linux-user/syscall.c  | 67 +++++++++++++++++++++++++------------------
 2 files changed, 47 insertions(+), 28 deletions(-)

-- 
2.20.1


Re: [Qemu-devel] [PULL 0/3] Linux user for 4.0 patches

Posted by no-reply@patchew.org 10 weeks ago
Patchew URL: https://patchew.org/QEMU/20190207105347.22337-1-laurent@vivier.eu/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PULL 0/3] Linux user for 4.0 patches
Type: series
Message-id: 20190207105347.22337-1-laurent@vivier.eu

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190206181725.14337-1-armbru@redhat.com -> patchew/20190206181725.14337-1-armbru@redhat.com
 * [new tag]               patchew/20190207105347.22337-1-laurent@vivier.eu -> patchew/20190207105347.22337-1-laurent@vivier.eu
Switched to a new branch 'test'
11efd0b554 linux-user: add new netlink types
a7c0a6a696 linux-user: Check sscanf return value in open_net_route()
e1edb0bc04 Fix linux-user crashes in ioctl(SIOCGIFCONF) when ifc_buf is NULL.

=== OUTPUT BEGIN ===
1/3 Checking commit e1edb0bc04af (Fix linux-user crashes in ioctl(SIOCGIFCONF) when ifc_buf is NULL.)
WARNING: Block comments use a leading /* on a separate line
#48: FILE: linux-user/syscall.c:4200:
+            /* We can't fit all the extents into the fixed size buffer.

ERROR: "(foo*)" should be "(foo *)"
#62: FILE: linux-user/syscall.c:4210:
+        host_ifc_buf = (char*)host_ifconf + sizeof(*host_ifconf);

total: 1 errors, 1 warnings, 73 lines checked

Patch 1/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/3 Checking commit a7c0a6a696f8 (linux-user: Check sscanf return value in open_net_route())
3/3 Checking commit 11efd0b55422 (linux-user: add new netlink types)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190207105347.22337-1-laurent@vivier.eu/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PULL 0/3] Linux user for 4.0 patches

Posted by Laurent Vivier 10 weeks ago
I'm going to resend an updated series.

Thanks,
Laurent

On 07/02/2019 12:37, no-reply@patchew.org wrote:
> Patchew URL: https://patchew.org/QEMU/20190207105347.22337-1-laurent@vivier.eu/
> 
> 
> 
> Hi,
> 
> This series seems to have some coding style problems. See output below for
> more information:
> 
> Subject: [Qemu-devel] [PULL 0/3] Linux user for 4.0 patches
> Type: series
> Message-id: 20190207105347.22337-1-laurent@vivier.eu
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> git config --local diff.algorithm histogram
> ./scripts/checkpatch.pl --mailback base..
> === TEST SCRIPT END ===
> 
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> From https://github.com/patchew-project/qemu
>  t [tag update]            patchew/20190206181725.14337-1-armbru@redhat.com -> patchew/20190206181725.14337-1-armbru@redhat.com
>  * [new tag]               patchew/20190207105347.22337-1-laurent@vivier.eu -> patchew/20190207105347.22337-1-laurent@vivier.eu
> Switched to a new branch 'test'
> 11efd0b554 linux-user: add new netlink types
> a7c0a6a696 linux-user: Check sscanf return value in open_net_route()
> e1edb0bc04 Fix linux-user crashes in ioctl(SIOCGIFCONF) when ifc_buf is NULL.
> 
> === OUTPUT BEGIN ===
> 1/3 Checking commit e1edb0bc04af (Fix linux-user crashes in ioctl(SIOCGIFCONF) when ifc_buf is NULL.)
> WARNING: Block comments use a leading /* on a separate line
> #48: FILE: linux-user/syscall.c:4200:
> +            /* We can't fit all the extents into the fixed size buffer.
> 
> ERROR: "(foo*)" should be "(foo *)"
> #62: FILE: linux-user/syscall.c:4210:
> +        host_ifc_buf = (char*)host_ifconf + sizeof(*host_ifconf);
> 
> total: 1 errors, 1 warnings, 73 lines checked
> 
> Patch 1/3 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> 2/3 Checking commit a7c0a6a696f8 (linux-user: Check sscanf return value in open_net_route())
> 3/3 Checking commit 11efd0b55422 (linux-user: add new netlink types)
> === OUTPUT END ===
> 
> Test command exited with code: 1
> 
> 
> The full log is available at
> http://patchew.org/logs/20190207105347.22337-1-laurent@vivier.eu/testing.checkpatch/?type=message.
> ---
> Email generated automatically by Patchew [http://patchew.org/].
> Please send your feedback to patchew-devel@redhat.com
>