From nobody Mon Apr 29 11:29:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1549430518143279.6010249055298; Tue, 5 Feb 2019 21:21:58 -0800 (PST) Received: from localhost ([127.0.0.1]:45233 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1grFei-0000uT-5b for importer@patchew.org; Wed, 06 Feb 2019 00:21:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50846) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1grFbg-0007HS-61 for qemu-devel@nongnu.org; Wed, 06 Feb 2019 00:18:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1grFQU-0003Jf-Ml for qemu-devel@nongnu.org; Wed, 06 Feb 2019 00:07:11 -0500 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:50906) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1grFQU-0003JC-81 for qemu-devel@nongnu.org; Wed, 06 Feb 2019 00:07:10 -0500 Received: by mail-wm1-x32b.google.com with SMTP id z5so1114575wmf.0 for ; Tue, 05 Feb 2019 21:07:09 -0800 (PST) Received: from cloudburst.twiddle.net (host81-133-38-158.in-addr.btopenworld.com. [81.133.38.158]) by smtp.gmail.com with ESMTPSA id l125sm2343473wml.18.2019.02.05.21.07.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Feb 2019 21:07:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=84vmGP9Bty50VmJ29TzqnMG7INxyOeuGKn+/z1pdICA=; b=s1uu53Oi58ae92wm816ieXZMCV8mktjtoxfkARsF9DMQv8lA0Bp8e8q2NTs3A3nGSh prFfYIy9IfnYB/BsG/hVEUk9eX3g53bd0cpameP7RqxH1Bk+6wQqUR1VclMUQLXq265U QgKKlOSIf3KAptJrvgTAiv/HeoO9yZrSJT5zl+JdKpqxrzlTt//mlhlOa2Cz9fcA3CtG s4FBHglhOPQFw9bT8vftDQBDYgx+6rxdQsz5/Mk43/sc/q30YhOEm/A40NhFrvEWRHzu /qgUjB9Awr15npMdrjos2zl/JdaRd0MwzaZOtGL1Jr1ODffsRS+7d68562VGBE4OfGCy p2Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=84vmGP9Bty50VmJ29TzqnMG7INxyOeuGKn+/z1pdICA=; b=Yek4IZBwphdzeG3InzIrLfbTCGtHSmJxyIV4RILeAymZO1cMiZuzhfQbOppO3Y+4ro r/uA3VGxhtraAbIIJalO4p8ialrZOpgKuJlQqznF9+6TuLWCg9MBJuWJoOrDmXyefd8r 7HErTtPQnPpNw7DsE6Od+RILhweklwkA9ALrE9FHMprhgYwej2e4t+R8ESEuQkYuiCtp rK+8RSM1RqM0sKrRA163guwfshdaYAC9CExM2EORQjH9S8pqSoIYJRlfkmYcgnHjX9zt j8BSt1jW/T5w4acIukxAKWnlLAIKeKhSApdWn7NtJ+mKpG/hHQL4YaI9QUuGKvc6S9se rXkQ== X-Gm-Message-State: AHQUAuZeJVFejDVv6hZq5nmP+5NmKL2V9mC0dWjJzgnF1rXeW9cEdxJH 1Rgj/Tam4CUz6QLqASyP1J+rRw7JDGV1qw== X-Google-Smtp-Source: AHgI3IYLyr9GJ7Q2ipbtQH9153B7vITwUm4jjCjjWwwgkOX6KGKfrIGZGi8qKlbq1AgKG5fCf7uuQw== X-Received: by 2002:a1c:c1c9:: with SMTP id r192mr1407868wmf.146.1549429628386; Tue, 05 Feb 2019 21:07:08 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 6 Feb 2019 05:06:57 +0000 Message-Id: <20190206050701.11847-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190206050701.11847-1-richard.henderson@linaro.org> References: <20190206050701.11847-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32b Subject: [Qemu-devel] [PATCH v2 1/5] target/arm: Rely on optimization within tcg_gen_gvec_or X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Since we're now handling a =3D=3D b generically, we no longer need to do it by hand within target/arm/. Reviewed-by: David Gibson Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 6 +----- target/arm/translate-sve.c | 6 +----- target/arm/translate.c | 12 +++--------- 3 files changed, 5 insertions(+), 19 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index e002251ac6..a12bfac719 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -10648,11 +10648,7 @@ static void disas_simd_3same_logic(DisasContext *s= , uint32_t insn) gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_andc, 0); return; case 2: /* ORR */ - if (rn =3D=3D rm) { /* MOV */ - gen_gvec_fn2(s, is_q, rd, rn, tcg_gen_gvec_mov, 0); - } else { - gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_or, 0); - } + gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_or, 0); return; case 3: /* ORN */ gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_orc, 0); diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c index b15b615ceb..3a2eb51566 100644 --- a/target/arm/translate-sve.c +++ b/target/arm/translate-sve.c @@ -280,11 +280,7 @@ static bool trans_AND_zzz(DisasContext *s, arg_rrr_esz= *a) =20 static bool trans_ORR_zzz(DisasContext *s, arg_rrr_esz *a) { - if (a->rn =3D=3D a->rm) { /* MOV */ - return do_mov_z(s, a->rd, a->rn); - } else { - return do_vector3_z(s, tcg_gen_gvec_or, 0, a->rd, a->rn, a->rm); - } + return do_vector3_z(s, tcg_gen_gvec_or, 0, a->rd, a->rn, a->rm); } =20 static bool trans_EOR_zzz(DisasContext *s, arg_rrr_esz *a) diff --git a/target/arm/translate.c b/target/arm/translate.c index 66cf28c8cb..9d2dba7ed2 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -6294,15 +6294,9 @@ static int disas_neon_data_insn(DisasContext *s, uin= t32_t insn) tcg_gen_gvec_andc(0, rd_ofs, rn_ofs, rm_ofs, vec_size, vec_size); break; - case 2: - if (rn =3D=3D rm) { - /* VMOV */ - tcg_gen_gvec_mov(0, rd_ofs, rn_ofs, vec_size, vec_size= ); - } else { - /* VORR */ - tcg_gen_gvec_or(0, rd_ofs, rn_ofs, rm_ofs, - vec_size, vec_size); - } + case 2: /* VORR */ + tcg_gen_gvec_or(0, rd_ofs, rn_ofs, rm_ofs, + vec_size, vec_size); break; case 3: /* VORN */ tcg_gen_gvec_orc(0, rd_ofs, rn_ofs, rm_ofs, --=20 2.17.2 From nobody Mon Apr 29 11:29:27 2024 Delivered-To: importer@patchew.org Received-SPF: temperror (zoho.com: Error in retrieving data from DNS) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1549430401948877.1095977772766; Tue, 5 Feb 2019 21:20:01 -0800 (PST) Received: from localhost ([127.0.0.1]:45187 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1grFck-0007uz-8V for importer@patchew.org; Wed, 06 Feb 2019 00:19:50 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50846) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1grFbW-0007HS-1u for qemu-devel@nongnu.org; Wed, 06 Feb 2019 00:18:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1grFQV-0003Jz-6Z for qemu-devel@nongnu.org; Wed, 06 Feb 2019 00:07:12 -0500 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:38386) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1grFQU-0003JS-W3 for qemu-devel@nongnu.org; Wed, 06 Feb 2019 00:07:11 -0500 Received: by mail-wm1-x342.google.com with SMTP id m22so1205441wml.3 for ; Tue, 05 Feb 2019 21:07:10 -0800 (PST) Received: from cloudburst.twiddle.net (host81-133-38-158.in-addr.btopenworld.com. [81.133.38.158]) by smtp.gmail.com with ESMTPSA id l125sm2343473wml.18.2019.02.05.21.07.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Feb 2019 21:07:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=vfmR0xjiEFR7KqO1KlnHNMMmXo5J+oxa//ouhR3geX4=; b=vsMg8pInhUVUQ3EwimnokGn7jckJoThbX1eqGRpaAHeQ7HU5u7BXMfKxnhuarfN7nQ zlVlqSzhNdjSkyu2AgB1FWsv6d137jR8ZUpfP3rYXLM67uheVyBwdGAtMgaCh7crBl0U 6OIIQiT23WtJNFK7Ey/OGqx4/MvF8u92WPzvIpSTR9XAIHLCYIYGSPgzC+Fx/3NXKk89 +vQcbWH2r5LOxt2qt5I2ud3MX7PZOACqDcaBuk2N6sYF6qze85d0E0Jw40KgoKrzc4fm S27stvnIiKWbvuVKHKUum7Q/zI+dq0noST8zz7PgDAYfwityZ0IYdANCnhURs//KzBa2 5Dfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=vfmR0xjiEFR7KqO1KlnHNMMmXo5J+oxa//ouhR3geX4=; b=p1b06m86saUptVcJUg5JadbuGfPD1f6lG3OY9WgtrLS1UKXKQ6i403xkPdWyRJodFv DT18i/1fy2zNFIqc7xZWvf7jQwg6VZ3hDksefzkcxPRVHLFAHxtBQ4AjGIXPlJ0gNAzN owTLTFJMBq8kklLnvtdpTMeHYldko1MvcYv40HSin7he2yehJYU1NwD95ce7xH7NY83o x8hpTztgVUyT7NwArMpxzLAkt641W4+GxbbYPb20owgbzZmUmOB1ndPeb2CY37uhh+Qr yywjkTFy5tpnvmMUtUijOOSwer793PFlaww5zy3beb/yXt03fe3Eu3GcKurO2hUX5rOm aUfg== X-Gm-Message-State: AHQUAuYfFm0O6EhT0wsIAMM10x3XPOR8jfy/QI5vkw/HiNDaC+Mpygp0 K4tvVSQGC7yCYP9qiId23DKTpV3blk3JaA== X-Google-Smtp-Source: AHgI3IYlitru2Td38uSYeGMNRifaGagoMPnJkcj4o9gDCkgWGaPLhe/TKeQwjW2KoYs7VoVITk/ymg== X-Received: by 2002:a1c:f50a:: with SMTP id t10mr1494962wmh.126.1549429629698; Tue, 05 Feb 2019 21:07:09 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 6 Feb 2019 05:06:58 +0000 Message-Id: <20190206050701.11847-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190206050701.11847-1-richard.henderson@linaro.org> References: <20190206050701.11847-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::342 Subject: [Qemu-devel] [PATCH v2 2/5] target/arm: Use vector minmax expanders for aarch64 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 35 ++++++++++++++--------------------- 1 file changed, 14 insertions(+), 21 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index a12bfac719..fd5ceb6613 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -10948,6 +10948,20 @@ static void disas_simd_3same_int(DisasContext *s, = uint32_t insn) } =20 switch (opcode) { + case 0x0c: /* SMAX, UMAX */ + if (u) { + gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_umax, size); + } else { + gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_smax, size); + } + return; + case 0x0d: /* SMIN, UMIN */ + if (u) { + gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_umin, size); + } else { + gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_smin, size); + } + return; case 0x10: /* ADD, SUB */ if (u) { gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_sub, size); @@ -11109,27 +11123,6 @@ static void disas_simd_3same_int(DisasContext *s, = uint32_t insn) genenvfn =3D fns[size][u]; break; } - case 0xc: /* SMAX, UMAX */ - { - static NeonGenTwoOpFn * const fns[3][2] =3D { - { gen_helper_neon_max_s8, gen_helper_neon_max_u8 }, - { gen_helper_neon_max_s16, gen_helper_neon_max_u16 }, - { tcg_gen_smax_i32, tcg_gen_umax_i32 }, - }; - genfn =3D fns[size][u]; - break; - } - - case 0xd: /* SMIN, UMIN */ - { - static NeonGenTwoOpFn * const fns[3][2] =3D { - { gen_helper_neon_min_s8, gen_helper_neon_min_u8 }, - { gen_helper_neon_min_s16, gen_helper_neon_min_u16 }, - { tcg_gen_smin_i32, tcg_gen_umin_i32 }, - }; - genfn =3D fns[size][u]; - break; - } case 0xe: /* SABD, UABD */ case 0xf: /* SABA, UABA */ { --=20 2.17.2 From nobody Mon Apr 29 11:29:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1549430594803473.9700909322679; Tue, 5 Feb 2019 21:23:14 -0800 (PST) Received: from localhost ([127.0.0.1]:45247 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1grFfw-0001mU-Ri for importer@patchew.org; Wed, 06 Feb 2019 00:23:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50846) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1grFbf-0007HS-Cx for qemu-devel@nongnu.org; Wed, 06 Feb 2019 00:18:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1grFQW-0003Ka-9f for qemu-devel@nongnu.org; Wed, 06 Feb 2019 00:07:12 -0500 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:55284) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1grFQW-0003KB-3a for qemu-devel@nongnu.org; Wed, 06 Feb 2019 00:07:12 -0500 Received: by mail-wm1-x342.google.com with SMTP id a62so1094777wmh.4 for ; Tue, 05 Feb 2019 21:07:12 -0800 (PST) Received: from cloudburst.twiddle.net (host81-133-38-158.in-addr.btopenworld.com. [81.133.38.158]) by smtp.gmail.com with ESMTPSA id l125sm2343473wml.18.2019.02.05.21.07.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Feb 2019 21:07:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=RT1GreJgsvsbPtqY2RbKVaphAKh18dUwun7FW6H0APA=; b=nL5cFLjpOBCFPeV5i5mfAqsFdpU9x4FxgmMmrjKOsRyDehTZgWuRzfXyZpbIa7rNEW F4BXK1kbKEaVS9FYb9phbMM1gkJIzBRkdhFvt1lylHEtkcID0IE44XHeu5AdeV0ZZvld nBTHFSvRyzUB1PdqdYM9iWLu6Z64E5PKmoxIRB+vuULCZ6Mbj9kHwXCVcVHk7N12p94+ heC70NT5ajfYWFJrY9poAWXiT8kV5CrrassexawOG/c4E6l4cP+oEcntyeELBf9SNc+E bmKzzMelaJPK12PKY/3oD3NBzNDH93wn+D5fb86K0ng9aK2pPDLZVSNCpmSUcn3Nr9et VD7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=RT1GreJgsvsbPtqY2RbKVaphAKh18dUwun7FW6H0APA=; b=iFAnOYuEBLCjQYxGkgif4HEeQkT5Ph1Bc2CwNygxAHOwVo8IqW04ybSfWQbkmNlGk5 773I1+cX3MAfKIV1KfnlaYa+Ijwp012DxtM8LhrIqLn1k1yENjtXh16TPZfms7d5LuQe Yb0aqrYM+bEwA81nTTkpTarRa/aZRySTTYW5KDC0ZoK8HkYbnMhE0GbPWNkh8fxHoWqm 1g/dXPwp+vfq3PxucvpwB+jVXVVBdeK95EgA0tOK/pz9xvMgcLx6TFpV6zsVXn3FME3y HtEhDhopGFNAEK7LHC9qUPkw5kjfTS9Pf+mW7r6aXeIsy4+L4cgr1kkZONQfhQMvdzmp F9Fw== X-Gm-Message-State: AHQUAuYCDIpkO662Gc4KWwx+wsJZ7kCZgSuPGKmjeWTGyCohQ1oDiF+Q cd29LbTtkOifd/KwoI5mAGI9muQ9KuhQow== X-Google-Smtp-Source: AHgI3IYBe1t3WazhGzCnZp5ybZ2kCA09K/3FntJW+zcRypmeyncuoR7vszAbtt1gZ58WOaGGg5eSUQ== X-Received: by 2002:a1c:cf0d:: with SMTP id f13mr1445105wmg.70.1549429630953; Tue, 05 Feb 2019 21:07:10 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 6 Feb 2019 05:06:59 +0000 Message-Id: <20190206050701.11847-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190206050701.11847-1-richard.henderson@linaro.org> References: <20190206050701.11847-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::342 Subject: [Qemu-devel] [PATCH v2 3/5] target/arm: Use vector minmax expanders for aarch32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/translate.c | 25 +++++++++++++++++++------ 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 9d2dba7ed2..df1cd3fa3e 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -6368,6 +6368,25 @@ static int disas_neon_data_insn(DisasContext *s, uin= t32_t insn) tcg_gen_gvec_cmp(u ? TCG_COND_GEU : TCG_COND_GE, size, rd_ofs, rn_ofs, rm_ofs, vec_size, vec_size); return 0; + + case NEON_3R_VMAX: + if (u) { + tcg_gen_gvec_umax(size, rd_ofs, rn_ofs, rm_ofs, + vec_size, vec_size); + } else { + tcg_gen_gvec_smax(size, rd_ofs, rn_ofs, rm_ofs, + vec_size, vec_size); + } + return 0; + case NEON_3R_VMIN: + if (u) { + tcg_gen_gvec_umin(size, rd_ofs, rn_ofs, rm_ofs, + vec_size, vec_size); + } else { + tcg_gen_gvec_smin(size, rd_ofs, rn_ofs, rm_ofs, + vec_size, vec_size); + } + return 0; } =20 if (size =3D=3D 3) { @@ -6533,12 +6552,6 @@ static int disas_neon_data_insn(DisasContext *s, uin= t32_t insn) case NEON_3R_VQRSHL: GEN_NEON_INTEGER_OP_ENV(qrshl); break; - case NEON_3R_VMAX: - GEN_NEON_INTEGER_OP(max); - break; - case NEON_3R_VMIN: - GEN_NEON_INTEGER_OP(min); - break; case NEON_3R_VABD: GEN_NEON_INTEGER_OP(abd); break; --=20 2.17.2 From nobody Mon Apr 29 11:29:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 154943040956268.2311541348289; Tue, 5 Feb 2019 21:20:09 -0800 (PST) Received: from localhost ([127.0.0.1]:45189 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1grFcx-00085i-ID for importer@patchew.org; Wed, 06 Feb 2019 00:20:03 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50797) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1grFbf-0007H2-0e for qemu-devel@nongnu.org; Wed, 06 Feb 2019 00:18:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1grFQY-0003LC-4V for qemu-devel@nongnu.org; Wed, 06 Feb 2019 00:07:14 -0500 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:41924) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1grFQX-0003Kr-V1 for qemu-devel@nongnu.org; Wed, 06 Feb 2019 00:07:14 -0500 Received: by mail-wr1-x444.google.com with SMTP id x10so6057004wrs.8 for ; Tue, 05 Feb 2019 21:07:13 -0800 (PST) Received: from cloudburst.twiddle.net (host81-133-38-158.in-addr.btopenworld.com. [81.133.38.158]) by smtp.gmail.com with ESMTPSA id l125sm2343473wml.18.2019.02.05.21.07.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Feb 2019 21:07:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Ku2qqiofyo2h0KHaCF51MqBaY9+LaL6xQcdtOeJ2hfM=; b=z8GVaLXdVGsH62Soj/KOBi088ts85OkU2Kfu0SZZyddrH6Febwjd5wMBsbaHmwwcb+ 3/J3bqybk2plf+FF9YAkbM7elt3rwDa3xg5eL0dReqYGdiAGRsJPIdf3eQZtQq5Qy6hu EXK00H+Ek0yW2a/nIZNxpopAiBgj5WLd1IBi0C9A0+WV/ug/0qtrqQmepup0dkB/h/yc jE+6Ntc4XdXiqmbNmVZiUVfRm2Gifpraq2++CbUmtYhNtjsKG7rutTCSn8Zlgvs6QDt/ iTY4gtC+6KDZwH76Y95+oXiBQ4GrY/6pYk5bzZ8dKwGuI52pXL7SFmfkPtU+0S+fpnjT ysdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Ku2qqiofyo2h0KHaCF51MqBaY9+LaL6xQcdtOeJ2hfM=; b=BTAE4HNjqBGvra9sRHyO3xNISyE7dA2bO9MY6fWXoHiQoEunaq/6BdZUEI0f5Cqd3F 1u7BCbmaQSwAITNAdYayTqz1sDsx1NmV/TGXqtORgUTCVASVhPrA3s7K1gRynhUsi/vM uzLXqJKkR0vvjyx1I/aAfOuDtL/dIDyn6tRakrf2nsHXZTjn9QTwpS2vzhXDZirfds4n vbg/7sb+weiBD+ha3YOEKzuxDPxFevQh3GtCMr7x8p73Ef3ItNXlHs+uwRRKrm12aPrd yfxKTAVvCGk2toBNmJFmLEcfLoUI+WoV1UWWF3ysrD8NSvngHznKUkptZtL0fqqDRBvY T31Q== X-Gm-Message-State: AHQUAuZnYZuHxZiuZ4BZzIeqQdqALnws3o831h8eo66z7G+m6zzYrFdU lSSnzXNt5kQB4JqT+KcVsB3hUP7eeI0agA== X-Google-Smtp-Source: AHgI3IaorhacAgeJamVNE/eh92ZD/jHmTj3JHarCiKoGsfnJQwwvcj57WW9jtY5IFuibKiHp0kY8Eg== X-Received: by 2002:a05:6000:1206:: with SMTP id e6mr6804091wrx.227.1549429632591; Tue, 05 Feb 2019 21:07:12 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 6 Feb 2019 05:07:00 +0000 Message-Id: <20190206050701.11847-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190206050701.11847-1-richard.henderson@linaro.org> References: <20190206050701.11847-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 Subject: [Qemu-devel] [PATCH v2 4/5] target/arm: Use tcg integer min/max primitives for neon X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The 32-bit PMIN/PMAX has been decomposed to scalars, and so can be trivially expanded inline. Signed-off-by: Richard Henderson --- target/arm/translate.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index df1cd3fa3e..f0101d2788 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -4760,10 +4760,10 @@ static inline void gen_neon_rsb(int size, TCGv_i32 = t0, TCGv_i32 t1) } =20 /* 32-bit pairwise ops end up the same as the elementwise versions. */ -#define gen_helper_neon_pmax_s32 gen_helper_neon_max_s32 -#define gen_helper_neon_pmax_u32 gen_helper_neon_max_u32 -#define gen_helper_neon_pmin_s32 gen_helper_neon_min_s32 -#define gen_helper_neon_pmin_u32 gen_helper_neon_min_u32 +#define gen_helper_neon_pmax_s32 tcg_gen_smax_i32 +#define gen_helper_neon_pmax_u32 tcg_gen_umax_i32 +#define gen_helper_neon_pmin_s32 tcg_gen_smin_i32 +#define gen_helper_neon_pmin_u32 tcg_gen_umin_i32 =20 #define GEN_NEON_INTEGER_OP_ENV(name) do { \ switch ((size << 1) | u) { \ --=20 2.17.2 From nobody Mon Apr 29 11:29:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1549430502201460.070666127471; Tue, 5 Feb 2019 21:21:42 -0800 (PST) Received: from localhost ([127.0.0.1]:45231 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1grFeV-0000lN-6q for importer@patchew.org; Wed, 06 Feb 2019 00:21:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50846) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1grFbe-0007HS-FF for qemu-devel@nongnu.org; Wed, 06 Feb 2019 00:18:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1grFQZ-0003Ll-K2 for qemu-devel@nongnu.org; Wed, 06 Feb 2019 00:07:16 -0500 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:39011) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1grFQZ-0003LZ-EM for qemu-devel@nongnu.org; Wed, 06 Feb 2019 00:07:15 -0500 Received: by mail-wr1-x443.google.com with SMTP id t27so6074642wra.6 for ; Tue, 05 Feb 2019 21:07:15 -0800 (PST) Received: from cloudburst.twiddle.net (host81-133-38-158.in-addr.btopenworld.com. [81.133.38.158]) by smtp.gmail.com with ESMTPSA id l125sm2343473wml.18.2019.02.05.21.07.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Feb 2019 21:07:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Zi+eGtIG5ntlRP+2o43haALA7jfJjuuH+C4Q78Yx964=; b=Ci4NEGaLBxFolBgMJ6ZKgNQ4Ksz5C+pK4F7AHYHJpSDRKLyuuK7XeUw8Vx0og6OSda ZrAwRbM7wN9TBnS/FwDOR8yYknZb641+84mD81O3dEdlhok/sfPKS1ZX6/B8C5k02LXK PjESwWXaVpo/p3wamXvYj2wu9h6OR1XE34PpJebZ2J8VYufJJuj0jDaS5XVmW5JNv04o kuQHVAZ0+VSVESWhZTFxijluxT3b9jfOT+6WRw6AbqL6dI5HYYcC8mTdJOXB8I1L9iEX UdjgMP/ZPTTCestcVAxS+EVbbP4KxEsP3cz2EZhEiEzAP/zxdmLMbwhw6idINgcG4qVS 6Sqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Zi+eGtIG5ntlRP+2o43haALA7jfJjuuH+C4Q78Yx964=; b=uiVqgrBuDd4ZlfxGDOFh6CG04TwqR4Qae20c3i2easMHUSG63eC0yCzzV72CRkS+sD 4NyzhFThkDlzRVWtdIP20fBLvHJIApPRGuybA52yfySzJjMpK2BROOJzygIk3YBeUw3k ejITGeUeVgumWBx77ME5f3S5W9YJeMEwSkt0+mORLjnsaE/XnG/2+0OmFd3RIEw1zIBX zlGB9OvJEpteTvVdB+PwMYR/1kL61tc6qa21r9uWoWfO0njEtZduWndwEwjbCKWjHoYr BMXbXZKQ8DFPvS9Mr718Tgs+KIGd9AyP7RkDmBQAIWc0o25GprXQtrwZIKuMzmYdfHcS LI/g== X-Gm-Message-State: AHQUAuYU18aAqIMLKMGCXca9MDjqznMavMxqrRG/qdHj9/6aQSzRKw/i dCw4N8s0DqTeWRncBf8DZhyjRQUEF6tD2g== X-Google-Smtp-Source: AHgI3Iaad9VR1FJxZAGGTjAwaR4vi5AuTeF1aa4B0PZRY8RySXhM0/NuciZBZgaoIvhm83LJzRckgA== X-Received: by 2002:a5d:664a:: with SMTP id f10mr6084846wrw.311.1549429634155; Tue, 05 Feb 2019 21:07:14 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 6 Feb 2019 05:07:01 +0000 Message-Id: <20190206050701.11847-6-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190206050701.11847-1-richard.henderson@linaro.org> References: <20190206050701.11847-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::443 Subject: [Qemu-devel] [PATCH v2 5/5] target/arm: Remove neon min/max helpers X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" These are now unused. Signed-off-by: Richard Henderson --- target/arm/helper.h | 12 ------------ target/arm/neon_helper.c | 12 ------------ 2 files changed, 24 deletions(-) diff --git a/target/arm/helper.h b/target/arm/helper.h index 53a38188c6..9874c35ea9 100644 --- a/target/arm/helper.h +++ b/target/arm/helper.h @@ -276,18 +276,6 @@ DEF_HELPER_2(neon_cge_s16, i32, i32, i32) DEF_HELPER_2(neon_cge_u32, i32, i32, i32) DEF_HELPER_2(neon_cge_s32, i32, i32, i32) =20 -DEF_HELPER_2(neon_min_u8, i32, i32, i32) -DEF_HELPER_2(neon_min_s8, i32, i32, i32) -DEF_HELPER_2(neon_min_u16, i32, i32, i32) -DEF_HELPER_2(neon_min_s16, i32, i32, i32) -DEF_HELPER_2(neon_min_u32, i32, i32, i32) -DEF_HELPER_2(neon_min_s32, i32, i32, i32) -DEF_HELPER_2(neon_max_u8, i32, i32, i32) -DEF_HELPER_2(neon_max_s8, i32, i32, i32) -DEF_HELPER_2(neon_max_u16, i32, i32, i32) -DEF_HELPER_2(neon_max_s16, i32, i32, i32) -DEF_HELPER_2(neon_max_u32, i32, i32, i32) -DEF_HELPER_2(neon_max_s32, i32, i32, i32) DEF_HELPER_2(neon_pmin_u8, i32, i32, i32) DEF_HELPER_2(neon_pmin_s8, i32, i32, i32) DEF_HELPER_2(neon_pmin_u16, i32, i32, i32) diff --git a/target/arm/neon_helper.c b/target/arm/neon_helper.c index c2c6491a83..3249005b62 100644 --- a/target/arm/neon_helper.c +++ b/target/arm/neon_helper.c @@ -581,12 +581,6 @@ NEON_VOP(cge_u32, neon_u32, 1) #undef NEON_FN =20 #define NEON_FN(dest, src1, src2) dest =3D (src1 < src2) ? src1 : src2 -NEON_VOP(min_s8, neon_s8, 4) -NEON_VOP(min_u8, neon_u8, 4) -NEON_VOP(min_s16, neon_s16, 2) -NEON_VOP(min_u16, neon_u16, 2) -NEON_VOP(min_s32, neon_s32, 1) -NEON_VOP(min_u32, neon_u32, 1) NEON_POP(pmin_s8, neon_s8, 4) NEON_POP(pmin_u8, neon_u8, 4) NEON_POP(pmin_s16, neon_s16, 2) @@ -594,12 +588,6 @@ NEON_POP(pmin_u16, neon_u16, 2) #undef NEON_FN =20 #define NEON_FN(dest, src1, src2) dest =3D (src1 > src2) ? src1 : src2 -NEON_VOP(max_s8, neon_s8, 4) -NEON_VOP(max_u8, neon_u8, 4) -NEON_VOP(max_s16, neon_s16, 2) -NEON_VOP(max_u16, neon_u16, 2) -NEON_VOP(max_s32, neon_s32, 1) -NEON_VOP(max_u32, neon_u32, 1) NEON_POP(pmax_s8, neon_s8, 4) NEON_POP(pmax_u8, neon_u8, 4) NEON_POP(pmax_s16, neon_s16, 2) --=20 2.17.2