From nobody Mon Apr 29 03:47:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1549390501302209.97989828717846; Tue, 5 Feb 2019 10:15:01 -0800 (PST) Received: from localhost ([127.0.0.1]:36602 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gr5FH-0000rz-9f for importer@patchew.org; Tue, 05 Feb 2019 13:14:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51153) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gr4k2-0007Zj-Pg for qemu-devel@nongnu.org; Tue, 05 Feb 2019 12:42:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gr4k0-0001Vl-Br for qemu-devel@nongnu.org; Tue, 05 Feb 2019 12:42:38 -0500 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:40799) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gr4jz-0001JF-Uh for qemu-devel@nongnu.org; Tue, 05 Feb 2019 12:42:36 -0500 Received: by mail-wr1-x443.google.com with SMTP id p4so4589227wrt.7 for ; Tue, 05 Feb 2019 09:42:11 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id d2sm11756965wrs.97.2019.02.05.09.42.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Feb 2019 09:42:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=fDOf/+vRPBkCdSZK3fX1K7jtcq080jsXWxtMjTsKzuk=; b=PwH00UfXKTC2vg5W8mOk9S2+kEkM5ufuD96oEyUTvbOtvx/UgR30WX57aTGIIBKNCs L8Ur+FumM9khSnY2ZhiQW4ctfeBt6KNJbel3jFv+gHCsRpbiAGCqZcMoMIz+/iQeAzej BQ4wx+JBdRxfcFCJoI8B/1rKeX/pGxRcIjnCrV7mar6dhaMaXGt5Vft9zoubzHwpZZx8 9zUuQaF8LvjFnTIjlcgKb3TJM4ZNDEGSwyG64i3+R2a1uBtAjJkAT1dhl/T6ZWccBbkZ l5fYIyFKAUb9Srl6IIL2oi01ptzzrnw2vE1BX3monjX3i65rb3YeEK+jglVUAP10Kd1o a1Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=fDOf/+vRPBkCdSZK3fX1K7jtcq080jsXWxtMjTsKzuk=; b=SDP+zX2rkBjsvePIphXwL1nWn+Lr0HHBCqQ3mFfsEzhet3MB+MSQZ5SJBdtZ6eVnqk G3ViQzYyl3yPswAgFs9gRcp9c1VK02IjZE9uqu+5tQIHFOodLiFqx1FXipmlijypNQsa EohmUYrWNORIJt6fBRFOObP5f0GHsK6jJArjPZ3Jc0+uVHnZA9d55io+JLSY3epuiPY/ THC/aH2S2Mki4f+kqIhDW2IRS2/NfDIL5FmH9JXkITaVTnObv4Y3zlg/FfxcBQjgAh0A 1k+wO5AUkPmwZNBlvOg7UqHeZRH/hxY4JoheDBNjfqcUADonB72fpPsJfkriqJMwOPA6 2wTA== X-Gm-Message-State: AHQUAuZy5wknxoQ3jvqplsBhO056uCn0kCBznhkC4wFsgR4TBGZlj8nm 52DIGOvYPh+lL8WlENjq5f00AAzZ53CNYg== X-Google-Smtp-Source: AHgI3IaNAMLiRAMzIOYSRij7STq5gHFnwE/NhXDVUafFplUXMnyG4cFLzzfQpxWtdM5ivGNCaySpkA== X-Received: by 2002:a5d:4843:: with SMTP id n3mr4316242wrs.212.1549388529834; Tue, 05 Feb 2019 09:42:09 -0800 (PST) From: Peter Maydell To: qemu-devel@nongnu.org Date: Tue, 5 Feb 2019 17:42:07 +0000 Message-Id: <20190205174207.9278-1-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::443 Subject: [Qemu-devel] [PATCH] linux-user: Check sscanf return value in open_net_route() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Riku Voipio , Laurent Vivier , patches@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Coverity warns (CID 1390634) that open_net_route() is not checking the return value from sscanf(), which means that it might then use values that aren't initialized. Errors here should in general not happen since we're passing an assumed-good /proc/net/route from the host kernel, but if we do fail to parse a line then just skip it in the output we pass to the guest. Signed-off-by: Peter Maydell Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Stefano Garzarella --- linux-user/syscall.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index b5786d4fc1f..894678aa8b4 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -6762,9 +6762,15 @@ static int open_net_route(void *cpu_env, int fd) char iface[16]; uint32_t dest, gw, mask; unsigned int flags, refcnt, use, metric, mtu, window, irtt; - sscanf(line, "%s\t%08x\t%08x\t%04x\t%d\t%d\t%d\t%08x\t%d\t%u\t%u\n= ", - iface, &dest, &gw, &flags, &refcnt, &use, &metric, - &mask, &mtu, &window, &irtt); + int fields; + + fields =3D sscanf(line, + "%s\t%08x\t%08x\t%04x\t%d\t%d\t%d\t%08x\t%d\t%u\t%= u\n", + iface, &dest, &gw, &flags, &refcnt, &use, &metric, + &mask, &mtu, &window, &irtt); + if (fields !=3D 11) { + continue; + } dprintf(fd, "%s\t%08x\t%08x\t%04x\t%d\t%d\t%d\t%08x\t%d\t%u\t%u\n", iface, tswap32(dest), tswap32(gw), flags, refcnt, use, metric, tswap32(mask), mtu, window, irtt); --=20 2.20.1