From nobody Thu Sep 19 01:29:22 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1549272782399967.4934610280472; Mon, 4 Feb 2019 01:33:02 -0800 (PST) Received: from localhost ([127.0.0.1]:39409 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqaca-0001Iw-Qd for importer@patchew.org; Mon, 04 Feb 2019 04:32:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38962) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqa9e-0001Li-2Q for qemu-devel@nongnu.org; Mon, 04 Feb 2019 04:03:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gqa9N-0000Hp-Lw for qemu-devel@nongnu.org; Mon, 04 Feb 2019 04:02:55 -0500 Received: from ozlabs.org ([203.11.71.1]:52477) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gqa9F-0007t9-NI; Mon, 04 Feb 2019 04:02:41 -0500 Received: by ozlabs.org (Postfix, from userid 1007) id 43tMCB4vKfz9sPb; Mon, 4 Feb 2019 20:01:40 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1549270902; bh=1CNcPbQ1qrUgs236SoTtLwPpwK3x6Jqn1sjq4jsN5jM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QvBMRv6XJ2bLT7pwkv0ZjAm20FmNLCzwgUZPKejhJOcEAdsbpmSL+R/PX7V7dvQGG 3S2qaWXyIYmeW8SuOZ6DYtLHttatuFpTY7mETEnd7zU9GzR8evyySpn6mU4cxjG2/q /ZwFeu20QGdQ5NCVocoY5C19/d2V/SiNPs+2rv3Y= From: David Gibson To: peter.maydell@linaro.org Date: Mon, 4 Feb 2019 20:01:21 +1100 Message-Id: <20190204090124.26191-35-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190204090124.26191-1-david@gibson.dropbear.id.au> References: <20190204090124.26191-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 203.11.71.1 Subject: [Qemu-devel] [PULL 34/37] spapr_pci: Fix endianness in assigned-addresses property X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, Alexey Kardashevskiy , qemu-devel@nongnu.org, groug@kaod.org, spopovyc@redhat.com, qemu-ppc@nongnu.org, clg@kaod.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Alexey Kardashevskiy reg->phys_hi and assigned->phys_hi are big endian but we do an extra byteswap anyway when copying reg->phys_hi to assigned->phys_hi. To make things slightly more messy, we also add a relocatable bit (b_n()) although in the right endianness. This fixes endianness of assigned->phys_hi. This is unlikely to produce any visible difference though as we should end = up there only in the case of PCI hotplug and even then I am not sure if (d->io_regions[i].addr =3D=3D PCI_BAR_UNMAPPED) =3D=3D true. Signed-off-by: Alexey Kardashevskiy Signed-off-by: David Gibson --- hw/ppc/spapr_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index 5cdc98513d..c99721cde8 100644 --- a/hw/ppc/spapr_pci.c +++ b/hw/ppc/spapr_pci.c @@ -964,7 +964,7 @@ static void populate_resource_props(PCIDevice *d, Resou= rceProps *rp) } =20 assigned =3D &rp->assigned[assigned_idx++]; - assigned->phys_hi =3D cpu_to_be32(reg->phys_hi | b_n(1)); + assigned->phys_hi =3D cpu_to_be32(be32_to_cpu(reg->phys_hi) | b_n(= 1)); assigned->phys_mid =3D cpu_to_be32(d->io_regions[i].addr >> 32); assigned->phys_lo =3D cpu_to_be32(d->io_regions[i].addr); assigned->size_hi =3D reg->size_hi; --=20 2.20.1