From nobody Mon Feb 9 18:19:51 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=126.com Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1548998462901962.7221226926567; Thu, 31 Jan 2019 21:21:02 -0800 (PST) Received: from localhost ([127.0.0.1]:38928 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpRG1-00052o-3W for importer@patchew.org; Fri, 01 Feb 2019 00:20:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40369) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpRDo-0003fG-W2 for qemu-devel@nongnu.org; Fri, 01 Feb 2019 00:18:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gpRDl-0007nW-R2 for qemu-devel@nongnu.org; Fri, 01 Feb 2019 00:18:34 -0500 Received: from m50-111.126.com ([123.125.50.111]:54034) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpRDh-0007m7-Mi for qemu-devel@nongnu.org; Fri, 01 Feb 2019 00:18:32 -0500 Received: from bogon.bytedance.net (unknown [120.52.147.46]) by smtp5 (Coremail) with SMTP id jtKowABXEaSW1lNcujAMAA--.154S6; Fri, 01 Feb 2019 13:18:21 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id; bh=Kg5pakR21wF2O7bk/6 LM+iwyZMA1JBifOP/DuT6YtR0=; b=kiK9hupSho8KJTl/NT4c/WPnLW8YRK6oTD 7VrUMVfdszdRq02mFmxCV/vcg8Cq5XmmXV91dX7EJWUjngzn9rJ0ywPKtNzPTKoL SrhTzgUQ5i6aWvPJnzxnp64TXcSAilzBiMreRhh/OvJd4uZ7fB+2do9Bgj0nZbsh sUFZf8wCk= From: Fei Li To: qemu-devel@nongnu.org, shirley17fei@gmail.com Date: Fri, 1 Feb 2019 13:17:59 +0800 Message-Id: <20190201051806.53183-5-lifei1214@126.com> X-Mailer: git-send-email 2.17.2 (Apple Git-113) In-Reply-To: <20190201051806.53183-1-lifei1214@126.com> References: <20190201051806.53183-1-lifei1214@126.com> X-CM-TRANSID: jtKowABXEaSW1lNcujAMAA--.154S6 X-Coremail-Antispam: 1Uf129KBjvJXoWrtw45CrWruF4rXFWxWFW3ZFb_yoW8JryUpr Z8G39xKrZ3JFs3ZrW3JayqvFyUGa1rWF4UGr48Cw4fJw1DGa1YvryUG3409FyxCFyYvFWr ZFW5JFy3Wa1qvrJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jJAwxUUUUU= X-Originating-IP: [120.52.147.46] X-CM-SenderInfo: 5olivxarsrkqqrswhudrp/1tbiFh1OIVpD8RQ7KwAAsI X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 123.125.50.111 Subject: [Qemu-devel] [PATCH v11 for-4.0 04/11] qemu_thread: supplement error handling for pci_edu_realize X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fei Li , Jiri Slaby , Markus Armbruster Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Fei Li Utilize the existed errp to propagate the error and do the corresponding cleanup to replace the temporary &error_abort. Cc: Markus Armbruster Cc: Jiri Slaby Signed-off-by: Fei Li Reviewed-by: Markus Armbruster --- hw/misc/edu.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/hw/misc/edu.c b/hw/misc/edu.c index 21adbfddce..8fe232b6d6 100644 --- a/hw/misc/edu.c +++ b/hw/misc/edu.c @@ -356,9 +356,14 @@ static void pci_edu_realize(PCIDevice *pdev, Error **e= rrp) =20 qemu_mutex_init(&edu->thr_mutex); qemu_cond_init(&edu->thr_cond); - /* TODO: let the further caller handle the error instead of abort() he= re */ - qemu_thread_create(&edu->thread, "edu", edu_fact_thread, - edu, QEMU_THREAD_JOINABLE, &error_abort); + if (qemu_thread_create(&edu->thread, "edu", edu_fact_thread, + edu, QEMU_THREAD_JOINABLE, errp) < 0) { + qemu_cond_destroy(&edu->thr_cond); + qemu_mutex_destroy(&edu->thr_mutex); + timer_del(&edu->dma_timer); + msi_uninit(pdev); + return; + } =20 memory_region_init_io(&edu->mmio, OBJECT(edu), &edu_mmio_ops, edu, "edu-mmio", 1 * MiB); --=20 2.17.2 (Apple Git-113)