From nobody Fri Nov 7 16:11:07 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 154881269056276.06527001185498; Tue, 29 Jan 2019 17:44:50 -0800 (PST) Received: from localhost ([127.0.0.1]:58639 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1goevk-0005Ug-AW for importer@patchew.org; Tue, 29 Jan 2019 20:44:44 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49088) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1goetT-0003i1-NB for qemu-devel@nongnu.org; Tue, 29 Jan 2019 20:42:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1goetS-0000ja-Ci for qemu-devel@nongnu.org; Tue, 29 Jan 2019 20:42:23 -0500 Received: from ozlabs.ru ([107.173.13.209]:45181) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1goetS-0000iU-6b; Tue, 29 Jan 2019 20:42:22 -0500 Received: from fstn1-p1.ozlabs.ibm.com (localhost [IPv6:::1]) by ozlabs.ru (Postfix) with ESMTP id 22B32AE8001E; Tue, 29 Jan 2019 20:42:17 -0500 (EST) From: Alexey Kardashevskiy To: qemu-devel@nongnu.org Date: Wed, 30 Jan 2019 12:42:16 +1100 Message-Id: <20190130014216.98287-1-aik@ozlabs.ru> X-Mailer: git-send-email 2.17.1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 107.173.13.209 Subject: [Qemu-devel] [PATCH qemu] spapr: Drop unused parameters from fdt building helper X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexey Kardashevskiy , qemu-ppc@nongnu.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" spapr_load_rtas() handles now RTAS address and size information in the FDT so drop them from spapr_build_fdt(). While we are here, fix a small typo. Fixes: 2cac78c12ade9 "pseries: Consolidate RTAS loading" Signed-off-by: Alexey Kardashevskiy Reviewed-by: Greg Kurz Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/ppc/spapr.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index a217c7f..fa12723 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -1225,9 +1225,7 @@ static void spapr_dt_hypervisor(sPAPRMachineState *sp= apr, void *fdt) } } =20 -static void *spapr_build_fdt(sPAPRMachineState *spapr, - hwaddr rtas_addr, - hwaddr rtas_size) +static void *spapr_build_fdt(sPAPRMachineState *spapr) { MachineState *machine =3D MACHINE(spapr); MachineClass *mc =3D MACHINE_GET_CLASS(machine); @@ -1644,14 +1642,14 @@ static void spapr_machine_reset(void) =20 /* * We place the device tree and RTAS just below either the top of the = RMA, - * or just below 2GB, whichever is lowere, so that it can be + * or just below 2GB, whichever is lower, so that it can be * processed with 32-bit real mode code if necessary */ rtas_limit =3D MIN(spapr->rma_size, RTAS_MAX_ADDR); rtas_addr =3D rtas_limit - RTAS_MAX_SIZE; fdt_addr =3D rtas_addr - FDT_MAX_SIZE; =20 - fdt =3D spapr_build_fdt(spapr, rtas_addr, spapr->rtas_size); + fdt =3D spapr_build_fdt(spapr); =20 spapr_load_rtas(spapr, fdt, rtas_addr); =20 --=20 2.17.1