From nobody Fri Nov 7 22:59:20 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1548811078485912.368992575237; Tue, 29 Jan 2019 17:17:58 -0800 (PST) Received: from localhost ([127.0.0.1]:58184 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1goeVg-0006WR-Ln for importer@patchew.org; Tue, 29 Jan 2019 20:17:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35447) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1goe3g-0008KQ-W3 for qemu-devel@nongnu.org; Tue, 29 Jan 2019 19:48:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1goe3e-00014h-Am for qemu-devel@nongnu.org; Tue, 29 Jan 2019 19:48:51 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:53481) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1goe3b-0000gi-Tt; Tue, 29 Jan 2019 19:48:48 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 3A0AD220D7; Tue, 29 Jan 2019 19:48:17 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 29 Jan 2019 19:48:17 -0500 Received: from localhost (flamenco.cs.columbia.edu [128.59.20.216]) by mail.messagingengine.com (Postfix) with ESMTPA id B1ED8E4667; Tue, 29 Jan 2019 19:48:16 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=braap.org; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=mesmtp; bh=vTJvbxpBU4eOFfsiY9y7x8qOJQHNwQmc9QTOLwCiUI0=; b=y9RKQGoKDEAs 85pavS1yb/v7+dD8yykRW/Bh26epojEmI2jexMfAkbpY3aWxU6fqjPrfvsWup7iX RPszzafbA+i3bXDw/gu36GLsrfKvTZkUGPExrTheaq55tOj6oGeDMLdw9UHXYRUW x8Wzri9rWEswipjaZ8KsgucZGmnyzfI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=vTJvbxpBU4eOFfsiY9y7x8qOJQHNwQmc9QTOLwCiU I0=; b=FUMIy6gaoI3Cmie9Ftblr8laYpoVyMl3j/gS0iLhYLAV4Z7yc6em6oxSr IJ+YhLmYkftMY+LxEhBFGgP7nQt5wAs4ICnYqdP9ZBKdQtfA43ktN4AAss45KKkW csNsz0SRl337k+dai4DjN3g1ne9XpW6uhOAlnvyHTJgkiuTMoS71u+bsD/bky0LT +sJvupK0RrI8N7ejYwAVuzEtm0DJaX7br3deRSxMKHiQ5/rW4d64zx708Nv6jx0c mBpSxuW5T59dulKc1vOKgREUuLm7bauo8VDh+i795kSbWISHvAMssZMpVxfCKAPy ww31/LBMJD4lOXi22FOZSeCCJIYIQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrjeefgddvkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufffkffojg hfgggtgfesthekredtredtjeenucfhrhhomhepfdfgmhhilhhiohcuifdrucevohhtrgdf uceotghothgrsegsrhgrrghprdhorhhgqeenucfkphepuddvkedrheelrddvtddrvdduie enucfrrghrrghmpehmrghilhhfrhhomheptghothgrsegsrhgrrghprdhorhhgnecuvehl uhhsthgvrhfuihiivgepke X-ME-Proxy: From: "Emilio G. Cota" To: qemu-devel@nongnu.org Date: Tue, 29 Jan 2019 19:47:15 -0500 Message-Id: <20190130004811.27372-18-cota@braap.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190130004811.27372-1-cota@braap.org> References: <20190130004811.27372-1-cota@braap.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 66.111.4.25 Subject: [Qemu-devel] [PATCH v6 17/73] arm: convert to cpu_halted X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Paolo Bonzini , qemu-arm@nongnu.org, Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Cc: Andrzej Zaborowski Cc: Peter Maydell Cc: qemu-arm@nongnu.org Reviewed-by: Richard Henderson Reviewed-by: Alex Benn=C3=A9e Signed-off-by: Emilio G. Cota --- hw/arm/omap1.c | 4 ++-- hw/arm/pxa2xx_gpio.c | 2 +- hw/arm/pxa2xx_pic.c | 2 +- target/arm/arm-powerctl.c | 4 ++-- target/arm/cpu.c | 2 +- target/arm/op_helper.c | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/arm/omap1.c b/hw/arm/omap1.c index 539d29ef9c..55a7672976 100644 --- a/hw/arm/omap1.c +++ b/hw/arm/omap1.c @@ -1769,7 +1769,7 @@ static uint64_t omap_clkdsp_read(void *opaque, hwaddr= addr, case 0x18: /* DSP_SYSST */ cpu =3D CPU(s->cpu); return (s->clkm.clocking_scheme << 11) | s->clkm.cold_start | - (cpu->halted << 6); /* Quite useless... */ + (cpu_halted(cpu) << 6); /* Quite useless... */ } =20 OMAP_BAD_REG(addr); @@ -3790,7 +3790,7 @@ void omap_mpu_wakeup(void *opaque, int irq, int req) struct omap_mpu_state_s *mpu =3D (struct omap_mpu_state_s *) opaque; CPUState *cpu =3D CPU(mpu->cpu); =20 - if (cpu->halted) { + if (cpu_halted(cpu)) { cpu_interrupt(cpu, CPU_INTERRUPT_EXITTB); } } diff --git a/hw/arm/pxa2xx_gpio.c b/hw/arm/pxa2xx_gpio.c index e15070188e..5c3fea42e9 100644 --- a/hw/arm/pxa2xx_gpio.c +++ b/hw/arm/pxa2xx_gpio.c @@ -128,7 +128,7 @@ static void pxa2xx_gpio_set(void *opaque, int line, int= level) pxa2xx_gpio_irq_update(s); =20 /* Wake-up GPIOs */ - if (cpu->halted && (mask & ~s->dir[bank] & pxa2xx_gpio_wake[bank])) { + if (cpu_halted(cpu) && (mask & ~s->dir[bank] & pxa2xx_gpio_wake[bank])= ) { cpu_interrupt(cpu, CPU_INTERRUPT_EXITTB); } } diff --git a/hw/arm/pxa2xx_pic.c b/hw/arm/pxa2xx_pic.c index 61275fa040..46ab4c3fc2 100644 --- a/hw/arm/pxa2xx_pic.c +++ b/hw/arm/pxa2xx_pic.c @@ -58,7 +58,7 @@ static void pxa2xx_pic_update(void *opaque) PXA2xxPICState *s =3D (PXA2xxPICState *) opaque; CPUState *cpu =3D CPU(s->cpu); =20 - if (cpu->halted) { + if (cpu_halted(cpu)) { mask[0] =3D s->int_pending[0] & (s->int_enabled[0] | s->int_idle); mask[1] =3D s->int_pending[1] & (s->int_enabled[1] | s->int_idle); if (mask[0] || mask[1]) { diff --git a/target/arm/arm-powerctl.c b/target/arm/arm-powerctl.c index 2b856930fb..003bf6c184 100644 --- a/target/arm/arm-powerctl.c +++ b/target/arm/arm-powerctl.c @@ -64,7 +64,7 @@ static void arm_set_cpu_on_async_work(CPUState *target_cp= u_state, =20 /* Initialize the cpu we are turning on */ cpu_reset(target_cpu_state); - target_cpu_state->halted =3D 0; + cpu_halted_set(target_cpu_state, 0); =20 if (info->target_aa64) { if ((info->target_el < 3) && arm_feature(&target_cpu->env, @@ -238,7 +238,7 @@ static void arm_set_cpu_off_async_work(CPUState *target= _cpu_state, =20 assert(qemu_mutex_iothread_locked()); target_cpu->power_state =3D PSCI_OFF; - target_cpu_state->halted =3D 1; + cpu_halted_set(target_cpu_state, 1); target_cpu_state->exception_index =3D EXCP_HLT; } =20 diff --git a/target/arm/cpu.c b/target/arm/cpu.c index d6da3f4fed..8cf2f5466b 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -149,7 +149,7 @@ static void arm_cpu_reset(CPUState *s) env->vfp.xregs[ARM_VFP_MVFR2] =3D cpu->isar.mvfr2; =20 cpu->power_state =3D cpu->start_powered_off ? PSCI_OFF : PSCI_ON; - s->halted =3D cpu->start_powered_off; + cpu_halted_set(s, cpu->start_powered_off); =20 if (arm_feature(env, ARM_FEATURE_IWMMXT)) { env->iwmmxt.cregs[ARM_IWMMXT_wCID] =3D 0x69051000 | 'Q'; diff --git a/target/arm/op_helper.c b/target/arm/op_helper.c index c998eadfaa..f9ccdc9abf 100644 --- a/target/arm/op_helper.c +++ b/target/arm/op_helper.c @@ -479,7 +479,7 @@ void HELPER(wfi)(CPUARMState *env, uint32_t insn_len) } =20 cs->exception_index =3D EXCP_HLT; - cs->halted =3D 1; + cpu_halted_set(cs, 1); cpu_loop_exit(cs); } =20 --=20 2.17.1