From nobody Fri Nov 7 18:48:28 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 15487708117461011.275649715604; Tue, 29 Jan 2019 06:06:51 -0800 (PST) Received: from localhost ([127.0.0.1]:50177 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1goU2M-0005tN-OL for importer@patchew.org; Tue, 29 Jan 2019 09:06:50 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40460) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1goU0A-0004ev-NY for qemu-devel@nongnu.org; Tue, 29 Jan 2019 09:04:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1goU00-0000Cw-J3 for qemu-devel@nongnu.org; Tue, 29 Jan 2019 09:04:30 -0500 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:41883) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1goTzx-0008Qo-AE for qemu-devel@nongnu.org; Tue, 29 Jan 2019 09:04:22 -0500 Received: by mail-wr1-x441.google.com with SMTP id x10so22169000wrs.8 for ; Tue, 29 Jan 2019 06:04:16 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id w80sm3876678wme.38.2019.01.29.06.04.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Jan 2019 06:04:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q3EgdZXoJH70u4Sb1K0DUazGB/+/w1o7y9u65M6WktQ=; b=H7TNUIbVdxWulQ9crlP8c3aZXl3w39OT4d/aBQpKfeI/2uhlB2fqjejd0NddGmQyya oxsYwej4AAeYwOx/d/08gRkgyzUpsnctCoIdqVan/p0lQ4p+jAzK4r2gyQAFRZzljn+r LXlbkw6uY7oa3O+STKTcfBaAYfPt4qa7ujXII= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q3EgdZXoJH70u4Sb1K0DUazGB/+/w1o7y9u65M6WktQ=; b=BJvkily/zHI+Fgi4yP0mzrcKFoXUoDTCjRHQlnFA0x6uOyHkHkEDYriYVJTE1M8mH9 xJCfy00sdp/8YU4Uo40LAByHA4wsB42CMdyegV/52nJ8ZQ53xDN+254/q6wVIqsKodue Y5vyWjWs7HluhEzQy+6HL22YcFJfFqFicNLf1jOu71ZnwCv2JM8ymLPpL3+dcKyZ7pDc qOUrFI/sfbnmN/hxgmur4jLJG+JC/0KyHo0HECQzZz9Lsq6JCSqR3NMUQLKaa7MbpEHo rLUs1DV5ZuyzM9gmmr4FFNpB5tqGkaNVq8API/9RYhMXxX511YxyvFG+OTQekk3XH/kY pHGA== X-Gm-Message-State: AJcUukfGZ0O/96UEy/WHDaJjUJNpfDHIv9yUumEWeU+K7h04LFuRisIN HUIgVc1/r1gHDMLfQAn+wWxW2vhz5FiARA== X-Google-Smtp-Source: ALg8bN6z/E3pigy7huK0sSRm+N7sAtQYKawHqvlN1su+dmi97ZyIO1s73dUS0KRwgI39whiyUHfLyQ== X-Received: by 2002:adf:f785:: with SMTP id q5mr27401309wrp.9.1548770655162; Tue, 29 Jan 2019 06:04:15 -0800 (PST) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Date: Tue, 29 Jan 2019 14:04:10 +0000 Message-Id: <20190129140411.682-2-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190129140411.682-1-peter.maydell@linaro.org> References: <20190129140411.682-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::441 Subject: [Qemu-devel] [PATCH 1/2] target/arm/translate-a64: Fix FCMLA decoding error X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Desnogues , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The FCMLA (by element) instruction exists in the "vector x indexed element" encoding group, but not in the "scalar x indexed element" group. Correctly UNDEF the unallocated encodings. Reported-by: Laurent Desnogues Signed-off-by: Peter Maydell Reviewed-by: Laurent Desnogues Reviewed-by: Richard Henderson --- target/arm/translate-a64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 30bc2412fc0..a7b999d2b5a 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -12650,7 +12650,7 @@ static void disas_simd_indexed(DisasContext *s, uin= t32_t insn) case 0x13: /* FCMLA #90 */ case 0x15: /* FCMLA #180 */ case 0x17: /* FCMLA #270 */ - if (!dc_isar_feature(aa64_fcma, s)) { + if (is_scalar || !dc_isar_feature(aa64_fcma, s)) { unallocated_encoding(s); return; } --=20 2.20.1 From nobody Fri Nov 7 18:48:28 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1548770810214386.23907051620347; Tue, 29 Jan 2019 06:06:50 -0800 (PST) Received: from localhost ([127.0.0.1]:50175 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1goU2L-0005rI-6M for importer@patchew.org; Tue, 29 Jan 2019 09:06:49 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1goU0H-0004ju-6d for qemu-devel@nongnu.org; Tue, 29 Jan 2019 09:04:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1goU0G-0000I7-AE for qemu-devel@nongnu.org; Tue, 29 Jan 2019 09:04:41 -0500 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]:51975) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1goU0G-0008SY-3w for qemu-devel@nongnu.org; Tue, 29 Jan 2019 09:04:40 -0500 Received: by mail-wm1-x343.google.com with SMTP id b11so18000555wmj.1 for ; Tue, 29 Jan 2019 06:04:17 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id w80sm3876678wme.38.2019.01.29.06.04.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Jan 2019 06:04:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=b16gPjOm37PXIDeysu8Z+J6YDD/flIUhAejAbwkSsqk=; b=R4G29lvB3fs3OrjkbH5WdzBLUUyFWsaDZ23LvbmiOdVYcozAO+95sVUfsZkKjMWAb2 uvjt9OIfvkI89WBRTM2g0sX7jvABjAZVL9Awnv2ymFtS2KmFirq7iEb39hDTjP8aySnz 75VdudNsAJSkP7IS4Wl4xb6OzWwvGR3bYPq0A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=b16gPjOm37PXIDeysu8Z+J6YDD/flIUhAejAbwkSsqk=; b=ty4YXdEe/vnC+/DoXqL8efEjKTtvLRp1DGJB2eytiliEmv/6Zw6kdNAXQ2cyhh7s4Y akd8/RCCCM6uSrzmIwfLMRab5gwHVt/aqcklXcCebY2lR5vq4BfwPmubOrxNDIRR5JDs jRC6TzmqGp9DiWrKhaHpP0OYEXbX6LPHuu1sS9gBASD/2MHX6utM8Wlq99YWWgL0kzDx ZLK64GumTCEBgwDli9xpUVB5Gv2I/TVrwvipiGHVaWrCWl86OjvvNKsxu92Y+r20S0/h ZwCXD5LzrE5a/me6v/iPLiIglnXEB51V4ipqPro2yVPbxs1Oxa2OpfWs/uAceksVDYwU +AiA== X-Gm-Message-State: AJcUukc7vQqeLugl+ypzStDPYZPFQoJtMI6wj5pGRlu8Jxjd30SVbulw GyVBzvQeHUU+0qEGwPQHjxWmgw== X-Google-Smtp-Source: ALg8bN594hMcNqGnuWUPWK4cpWkezcZ1wR67W2VmwSZHvuJhGcKxUrvcpumXa+jV3EdNi2818IC2yQ== X-Received: by 2002:a1c:e910:: with SMTP id q16mr20266474wmc.68.1548770656474; Tue, 29 Jan 2019 06:04:16 -0800 (PST) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Date: Tue, 29 Jan 2019 14:04:11 +0000 Message-Id: <20190129140411.682-3-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190129140411.682-1-peter.maydell@linaro.org> References: <20190129140411.682-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::343 Subject: [Qemu-devel] [PATCH 2/2] target/arm/translate-a64: Fix mishandling of size in FCMLA decode X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Desnogues , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" In disas_simd_indexed(), for the case of "complex fp", each indexable element is a complex pair, so the total size is twice that indicated in the 'size' field in the encoding. We were trying to do this "double the size" operation with a left shift by 1, but this is incorrect because the 'size' field is a MO_8/MO_16/MO_32/MO_64 value, and doubling the size should be done by a simple increment. This meant we were mishandling FCMLA (by element) of values where the real and imaginary parts are 32-bit floats, and would incorrectly UNDEF this encoding. (No other insns take this code path, and for 16-bit floats it happens that 1 << 1 and 1 + 1 are both the same). Reported-by: Laurent Desnogues Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target/arm/translate-a64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index a7b999d2b5a..06418f0ac3c 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -12680,7 +12680,7 @@ static void disas_simd_indexed(DisasContext *s, uin= t32_t insn) =20 case 2: /* complex fp */ /* Each indexable element is a complex pair. */ - size <<=3D 1; + size +=3D 1; switch (size) { case MO_32: if (h && !is_q) { --=20 2.20.1