From nobody Mon Dec 15 18:33:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1548710451367617.4324778273856; Mon, 28 Jan 2019 13:20:51 -0800 (PST) Received: from localhost ([127.0.0.1]:38779 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1goEKi-0007lu-9B for importer@patchew.org; Mon, 28 Jan 2019 16:20:44 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46101) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1goD9q-0003Xi-3q for qemu-devel@nongnu.org; Mon, 28 Jan 2019 15:05:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1goD9c-0005DN-17 for qemu-devel@nongnu.org; Mon, 28 Jan 2019 15:05:16 -0500 Received: from mail-eopbgr800129.outbound.protection.outlook.com ([40.107.80.129]:58944 helo=NAM03-DM3-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1goD9b-0005CQ-Ex for qemu-devel@nongnu.org; Mon, 28 Jan 2019 15:05:11 -0500 Received: from DM5PR07MB2921.namprd07.prod.outlook.com (10.168.103.7) by DM5PR07MB3065.namprd07.prod.outlook.com (10.172.88.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1558.16; Mon, 28 Jan 2019 20:05:08 +0000 Received: from DM5PR07MB2921.namprd07.prod.outlook.com ([fe80::d0bb:c162:9ce9:dca7]) by DM5PR07MB2921.namprd07.prod.outlook.com ([fe80::d0bb:c162:9ce9:dca7%10]) with mapi id 15.20.1558.023; Mon, 28 Jan 2019 20:05:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janustech.onmicrosoft.com; s=selector1-janustech-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dKC4IkXgzlBy4NMYErjSM45ZpYzTPodgZv0yB/nDCH8=; b=EfaGOfPyVnoZgEihERlpFwLsPZDSwtgTdtSvZkKWJNc8KpyPEgkhBuWrjhcXx0ZRfDwg03WfQmTdJTzq1u86SEEKfjajQRkFcPW/GWt9Zl2fWCfr6odCVae5qDcZuZWFyXQs0VuR75dWmHQ7rX6+ir7FCZW0gNvotTZlSCOusUo= From: Yuri Benditovich To: Gerd Hoffmann , "qemu-devel@nongnu.org" Thread-Topic: [PATCH 1/2] usb: XHCI shall not halt isochronous endpoints Thread-Index: AQHUt0TESNc5kwBgxEm8rAiivh6EwQ== Date: Mon, 28 Jan 2019 20:05:07 +0000 Message-ID: <20190128200444.5128-2-yuri.benditovich@janustech.com> References: <20190128200444.5128-1-yuri.benditovich@janustech.com> In-Reply-To: <20190128200444.5128-1-yuri.benditovich@janustech.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: LO2P265CA0221.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:b::17) To DM5PR07MB2921.namprd07.prod.outlook.com (2603:10b6:3:a::7) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yuri.benditovich@janustech.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.15.1.windows.2 x-originating-ip: [141.226.29.227] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM5PR07MB3065; 6:Q0j4rZKL64SLORQJXILbI1gYCe+Msk+29ktqHu3uSWo++CmzhcPcZx0Ge07RvmUJoL0wnfEgIJ5P86a9TUGTszDzyt3yVUHEAvLvrhv3P1ib6mLUsgzZnoi+2gsvyI/GWUTppQJ6OwwZ78ee6dXxvYz6wbwoov65HVJSZpQVKevw4gYYOpXVhm3GdXtT9GT5q9HNrIaDcXZXC90fKXcVL0Xw4h5eEJ3lg0/NDbZ8Afir5BhBVD2Q5h2qCwi4ftNOQwXOzhKenajV2CwpuNQzU25iD2zar3+RvaomZruia4ZtaAjCt1OD0kv6wXcbfvmOLqtvi4XO7f0wSquBxQ1eRwS/dugqcAH6z5awVPhDupZ3h0IJZYmVGNezxuNLdlzZDqkeavRqNCfvN11AXuw0QNsit6WCdGY5SneO2BjoKIQ4wGnNZYuVLCW/X/cVZfIWXs/4z+uhTf+sYrCxkMaezg==; 5:nMW+/sN5+mB462QC7QwcCJgFBpv5cjmC7kiIuz3mIuTVNU095hA76ABN7fbQyqMry2fm4hMDFAKPaZSR8ga6Mv/F4KWcpPna1r7knbfD/NUDsTCVzPZV8MsCYkz41kFgDq6nSyFQAuKXHumiOii/gJ4wipmA6h7n2MZnp/097r13jIVpZgPMD5E3B0hH1jIUSvx0sMsUgM0SPSGtWBqYXw==; 7:8oyhV65wvOQaicDeGOs7Aq9eR+ok4pPtSUltXeMfqurQQQvy7orJZYMgj9j1gpfV7rxQRCGjXPzevF9/UrOiQHs0z/zoCXCFVpq3s+MzetlzFiUUsDxcXDa6enEt1yM2OXINbofb9IjYr58fe+JJww== x-ms-office365-filtering-correlation-id: e610a977-511e-4260-dc03-08d6855be64e x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(7021145)(8989299)(4534185)(7022145)(4603075)(4627221)(201702281549075)(8990200)(7048125)(7024125)(7027125)(7023125)(5600110)(711020)(4605077)(2017052603328)(7153060)(7193020); SRVR:DM5PR07MB3065; x-ms-traffictypediagnostic: DM5PR07MB3065: x-microsoft-antispam-prvs: x-forefront-prvs: 0931CB1479 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(136003)(396003)(366004)(39830400003)(376002)(346002)(199004)(189003)(99286004)(81156014)(476003)(305945005)(7736002)(76176011)(6506007)(386003)(52116002)(8936002)(14454004)(446003)(50226002)(6116002)(3846002)(36756003)(81166006)(8676002)(11346002)(508600001)(68736007)(44832011)(86362001)(2616005)(256004)(2906002)(486006)(25786009)(6512007)(4326008)(26005)(186003)(71200400001)(97736004)(6436002)(102836004)(107886003)(66066001)(110136005)(6486002)(53936002)(4744005)(71190400001)(316002)(105586002)(106356001)(2501003)(1076003); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR07MB3065; H:DM5PR07MB2921.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; received-spf: None (protection.outlook.com: janustech.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: iHSOKhAwNNj3nT+UxZfarh7y8k4Fst/SwhXPxjS7bPcDdUsBraaBTHk3P7stXz90KyPP0bOG9aemyMO43+K8P1xY3yWQSyY+4uljEkjP3tE8dxFEbVZSHzSNRhRMxfb25Kj7R4s/miGPCm5+AnDLTdpJNZs/28jeZV6CWnOVoiEkc8NkG7kPzecie6sEDS6S09PhrgNFD077umdNCjVRjuCzYpoW9Sy+Jt/5zOcT2wrAMV/3XCtI1ocyitCaMlhPFRAt5zihqIG1+3YkdFKtC9HGk290PAxoNcw9pZgrOglYuQiR5bVdCMtp1D7G2jbe7qJ1p4NjIcZ04tsqRIaZg7ROc0Lr/AxmAyqR72znLRcIeOQQCl4rH1/AP1ZyLdl+5+l0uWHtzq0a/kSrluYyb1d+Q5Knv0MGApx28ZsrIeQ= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: janustech.com X-MS-Exchange-CrossTenant-Network-Message-Id: e610a977-511e-4260-dc03-08d6855be64e X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2019 20:05:06.2412 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 34eb020e-3cf3-43a1-afeb-f5cf1310628e X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3065 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 40.107.80.129 X-Mailman-Approved-At: Mon, 28 Jan 2019 16:15:17 -0500 Subject: [Qemu-devel] [PATCH 1/2] usb: XHCI shall not halt isochronous endpoints X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dmitry Fleytman Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" According to the XHCI spec (4.10.2) the controller never halts isochronous endpoints. This commit prevent stop of isochronous streaming when sporadic errors status received from backends. Signed-off-by: Yuri Benditovich Reviewed-by: Dmitry Fleytman --- hw/usb/hcd-xhci.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 8f1a01a..1a8fd96 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -1571,6 +1571,11 @@ static void xhci_stall_ep(XHCITransfer *xfer) uint32_t err; XHCIStreamContext *sctx; =20 + if (epctx->type =3D=3D ET_ISO_IN || epctx->type =3D=3D ET_ISO_OUT) { + /* never halt isoch endpoints, 4.10.2 */ + return; + } + if (epctx->nr_pstreams) { sctx =3D xhci_find_stream(epctx, xfer->streamid, &err); if (sctx =3D=3D NULL) { --=20 2.9.5