From nobody Sat Sep 28 22:37:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1548701538082751.0449054337138; Mon, 28 Jan 2019 10:52:18 -0800 (PST) Received: from localhost ([127.0.0.1]:36995 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1goC0x-00025M-Vj for importer@patchew.org; Mon, 28 Jan 2019 13:52:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41222) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1goBNe-0003AB-Dx for qemu-devel@nongnu.org; Mon, 28 Jan 2019 13:11:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1goBNc-0000Yy-R5 for qemu-devel@nongnu.org; Mon, 28 Jan 2019 13:11:34 -0500 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]:36636) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1goBNc-0000PS-G3 for qemu-devel@nongnu.org; Mon, 28 Jan 2019 13:11:32 -0500 Received: by mail-wm1-x32a.google.com with SMTP id p6so14942593wmc.1 for ; Mon, 28 Jan 2019 10:11:19 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id b18sm97910681wrw.83.2019.01.28.10.11.17 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Jan 2019 10:11:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=R/4vd1ag6pYGkr7XeNEY4GO1VSptJA7C37IWDHT1Zt4=; b=deTbDKrmZHDZ+l0XY6XpK6rJnxny5uo25bLg53D1upilT+1Ptb302z4DKnYHyaQRsG b0cpwL5Oh26roIqLLYAZFghem5J6iE+n8L9Fj74VOmuE7cQJuujJ890f9eiBjk9IyNVQ Qt33y4UgRHvtqVF5IrROHYzr1Zjv5Zhphnt3Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=R/4vd1ag6pYGkr7XeNEY4GO1VSptJA7C37IWDHT1Zt4=; b=XlEJQ/IwZBdfzLW/xpmWniSCRwbWLhdPglnUPq1Dn4OpkXFqZPmbAftMBYBCYTGdI5 BJeTpvAjHK4zxCrLQlyIrnGkuQHw3/Bs/ubNicm7nWzJSC9V2ouyL4ry4N5p5gLpWKAc Cg6sRWIfjG5UTYiTYRwRn3pR/mQr9Bg+Zu5QPi5wtzSNWqRq0xmsGLC8Os6BC9lUQUZb qpn/rOUNFayM4VSrPH+dPMpktwINAh7QdtZOt0i46w2bR3relIlh2yYjf4k6h5rdeTu+ oZ7b2zRqDrCMEVJJv87Fv7BLoPBTGgOaSGc/x4AERAI6jTTnw+cG1Z0WANQsepdow/wR mKAw== X-Gm-Message-State: AJcUukeGJlrzxSuQvPZt8KOcFKM+vLXXf3Xv9oIRYe3ZNELfH+/4y8PY GydDmxsNO8xJwIEuW3kBhrsveVIsKZl8Fw== X-Google-Smtp-Source: ALg8bN4/0KoQFuyvePBMFUK4HALvERxITowYi7p3ogIFLzSzGm2smWsYaM9bn/KR+wN1oQ40uSAEug== X-Received: by 2002:a7b:cf30:: with SMTP id m16mr2740247wmg.22.1548699078767; Mon, 28 Jan 2019 10:11:18 -0800 (PST) From: Peter Maydell To: qemu-devel@nongnu.org Date: Mon, 28 Jan 2019 18:10:44 +0000 Message-Id: <20190128181047.20781-24-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190128181047.20781-1-peter.maydell@linaro.org> References: <20190128181047.20781-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32a Subject: [Qemu-devel] [PULL 23/26] hw/arm/xlnx-zynqmp: Realize cluster after putting RPUs in it X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Currently the cluster implementation doesn't have any constraints on the ordering of realizing the TYPE_CPU_CLUSTER and populating it with child objects. We want to impose a constraint that realize must happen only after all the child objects are added, so move the realize of rpu_cluster. (The apu_cluster is already realized after child population.) Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Luc Michel Reviewed-by: Alistair Francis Reviewed-by: Edgar E. Iglesias Message-id: 20190121152218.9592-2-peter.maydell@linaro.org --- hw/arm/xlnx-zynqmp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c index 70cbe6bd475..4f8bc41d9d4 100644 --- a/hw/arm/xlnx-zynqmp.c +++ b/hw/arm/xlnx-zynqmp.c @@ -188,8 +188,6 @@ static void xlnx_zynqmp_create_rpu(XlnxZynqMPState *s, = const char *boot_cpu, &error_abort, NULL); qdev_prop_set_uint32(DEVICE(&s->rpu_cluster), "cluster-id", 1); =20 - qdev_init_nofail(DEVICE(&s->rpu_cluster)); - for (i =3D 0; i < num_rpus; i++) { char *name; =20 @@ -217,6 +215,8 @@ static void xlnx_zynqmp_create_rpu(XlnxZynqMPState *s, = const char *boot_cpu, return; } } + + qdev_init_nofail(DEVICE(&s->rpu_cluster)); } =20 static void xlnx_zynqmp_init(Object *obj) --=20 2.20.1