From nobody Sat Sep 28 22:39:28 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1548701414089691.8431283890664; Mon, 28 Jan 2019 10:50:14 -0800 (PST) Received: from localhost ([127.0.0.1]:36954 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1goByv-0000kc-Lw for importer@patchew.org; Mon, 28 Jan 2019 13:50:05 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41164) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1goBNd-00038r-3a for qemu-devel@nongnu.org; Mon, 28 Jan 2019 13:11:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1goBNc-0000Xw-AI for qemu-devel@nongnu.org; Mon, 28 Jan 2019 13:11:33 -0500 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:41244) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1goBNc-0000HP-2t for qemu-devel@nongnu.org; Mon, 28 Jan 2019 13:11:32 -0500 Received: by mail-wr1-x432.google.com with SMTP id x10so19123490wrs.8 for ; Mon, 28 Jan 2019 10:11:13 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id b18sm97910681wrw.83.2019.01.28.10.11.11 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Jan 2019 10:11:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=F4JmOlOwq7xp60ySXOl4Ahq+78GWoCsJheA9B1t63k0=; b=BNAHjiwK72uJ6E+wGuSTigNLakJceX/VFg87sz10wYp1dSlGIZx3ajpYyAKCTQTM5e XYOUa2QKVSZIqLAiimjZ9uvSF03KIzJxXogY8h1OjE66Y87XJmX0F4CZsWyN/bob/APG lkzjq4ebYyAPkBYXJrpKz0a2RKWHntGV5gpVU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=F4JmOlOwq7xp60ySXOl4Ahq+78GWoCsJheA9B1t63k0=; b=mlhQLaoCustu7hvdY9Ntv2YKdKIBtEkmk22XiNRzWEpDx5gunEvXYbJkMYFX4CNTqf E1jMj+PK2nfPASWy7eNhmh7qjJl7o3Xe1QoZ0OXHRNh5vr8Fcwrb6qA8t1RxGHsZ0Xv+ 4TILwtPiBoKIoW/CDQU8RGZiYwFNe/hF0U0i3753MvLiRYl0IwNTsETtZcFK5NkPL12P LaxISU5tf2uq6SGQG2W0d/3VN+IRkfRhY3jSQbQSiBNcLEVkVWlWQigVRanJjDPT0YBs 1MwTKLNxMxSsPvq9ojHgEE0fRfd/kI18hVIL7cmFWGETIC5Tfo2q0HczmSs/gRtjN/sR PKsw== X-Gm-Message-State: AJcUukdzsp/EQoJvVNKhd2BPnhV1IEvZvsPeN3s9IZKaHM6EVukOwk7i xqvADfsA1d6CO3Wc5lc9EUZO8F1W/S7r6w== X-Google-Smtp-Source: ALg8bN7kuOGoZrnt3LsPl7T41kYrviWkkrIdkrg9wfOGm2Dqj7Zp4eerSCKvol78IX3bHnfREJxb9Q== X-Received: by 2002:adf:f691:: with SMTP id v17mr21950862wrp.114.1548699072739; Mon, 28 Jan 2019 10:11:12 -0800 (PST) From: Peter Maydell To: qemu-devel@nongnu.org Date: Mon, 28 Jan 2019 18:10:39 +0000 Message-Id: <20190128181047.20781-19-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190128181047.20781-1-peter.maydell@linaro.org> References: <20190128181047.20781-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::432 Subject: [Qemu-devel] [PULL 18/26] aspeed/smc: fix default read value X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: C=C3=A9dric Le Goater 0xFFFFFFFF should be returned for non implemented registers. Signed-off-by: C=C3=A9dric Le Goater Reviewed-by: Joel Stanley Message-id: 20190124140519.13838-2-clg@kaod.org Signed-off-by: Peter Maydell --- hw/ssi/aspeed_smc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c index 1270842dcf0..7af808c33c5 100644 --- a/hw/ssi/aspeed_smc.c +++ b/hw/ssi/aspeed_smc.c @@ -670,7 +670,7 @@ static uint64_t aspeed_smc_read(void *opaque, hwaddr ad= dr, unsigned int size) } else { qemu_log_mask(LOG_UNIMP, "%s: not implemented: 0x%" HWADDR_PRIx "\= n", __func__, addr); - return 0; + return -1; } } =20 --=20 2.20.1