From nobody Fri Nov 7 17:02:32 2025 Delivered-To: importer@patchew.org Received-SPF: temperror (zoho.com: Error in retrieving data from DNS) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1548485662032212.6245159254363; Fri, 25 Jan 2019 22:54:22 -0800 (PST) Received: from localhost ([127.0.0.1]:55913 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gnHr0-00057J-E7 for importer@patchew.org; Sat, 26 Jan 2019 01:54:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33675) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gnHpd-0004SI-2R for qemu-devel@nongnu.org; Sat, 26 Jan 2019 01:52:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gnHpb-0001PD-1Y for qemu-devel@nongnu.org; Sat, 26 Jan 2019 01:52:43 -0500 Received: from poy.remlab.net ([2001:41d0:2:5a1a::]:48102 helo=ns207790.ip-94-23-215.eu) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gnHp8-0000z7-M1; Sat, 26 Jan 2019 01:52:14 -0500 Received: from basile.remlab.net (ip6-localhost [IPv6:::1]) by ns207790.ip-94-23-215.eu (Postfix) with ESMTP id 9EEBD5FE59; Sat, 26 Jan 2019 07:52:12 +0100 (CET) From: =?UTF-8?q?R=C3=A9mi=20Denis-Courmont?= To: qemu-arm@nongnu.org Date: Sat, 26 Jan 2019 08:52:11 +0200 Message-Id: <20190126065211.3587-2-remi@remlab.net> X-Mailer: git-send-email 2.20.1 In-Reply-To: <1648289.tQCHxfjYn9@basile.remlab.net> References: <1648289.tQCHxfjYn9@basile.remlab.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:41d0:2:5a1a:: Subject: [Qemu-devel] [PATCHv2 2/3] target/arm: actually enable PAuth in user mode X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Remi Denis-Courmont This always enables IA, IB, DA and DB keys in user mode on the maximum CPU, in a manner that is consistent with the other CPUs. That is to say redefining the reset value of SCTLR_ELx registers. Without this patch, the PAC* and AUT* instructions have no effects (except PACGA of course). Signed-off-by: Remi Denis-Courmont Reviewed-by: Richard Henderson --- target/arm/cpu64.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c index e9bc461c36..c8ed943c65 100644 --- a/target/arm/cpu64.c +++ b/target/arm/cpu64.c @@ -287,7 +287,7 @@ static void cpu_max_get_packey(Object *obj, Visitor *v,= const char *name, { ARMCPU *cpu =3D ARM_CPU(obj); const uint64_t *bit =3D opaque; - bool enabled =3D (cpu->env.cp15.sctlr_el[1] & *bit) !=3D 0; + bool enabled =3D (cpu->reset_sctlr & *bit) !=3D 0; =20 visit_type_bool(v, name, &enabled, errp); } @@ -304,9 +304,9 @@ static void cpu_max_set_packey(Object *obj, Visitor *v,= const char *name, =20 if (!err) { if (enabled) { - cpu->env.cp15.sctlr_el[1] |=3D *bit; + cpu->reset_sctlr |=3D *bit; } else { - cpu->env.cp15.sctlr_el[1] &=3D ~*bit; + cpu->reset_sctlr &=3D ~*bit; } } error_propagate(errp, err); @@ -413,8 +413,8 @@ static void aarch64_max_initfn(Object *obj) (void *)&apdb_bit, &error_fatal); =20 /* Enable all PAC keys by default. */ - cpu->env.cp15.sctlr_el[1] |=3D SCTLR_EnIA | SCTLR_EnIB; - cpu->env.cp15.sctlr_el[1] |=3D SCTLR_EnDA | SCTLR_EnDB; + cpu->reset_sctlr |=3D SCTLR_EnIA | SCTLR_EnIB; + cpu->reset_sctlr |=3D SCTLR_EnDA | SCTLR_EnDB; } #endif =20 --=20 2.20.1