From nobody Fri Nov 7 17:10:25 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 15484541428290.5475799796838601; Fri, 25 Jan 2019 14:09:02 -0800 (PST) Received: from localhost ([127.0.0.1]:51334 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gn9en-0006Rf-Mj for importer@patchew.org; Fri, 25 Jan 2019 17:09:01 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59743) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gn9cm-0005EB-3C for qemu-devel@nongnu.org; Fri, 25 Jan 2019 17:06:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gn9ck-0006a3-Ad for qemu-devel@nongnu.org; Fri, 25 Jan 2019 17:06:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52038) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gn9cj-0006Y2-F4 for qemu-devel@nongnu.org; Fri, 25 Jan 2019 17:06:54 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 131017F77D; Fri, 25 Jan 2019 22:06:52 +0000 (UTC) Received: from probe.bos.redhat.com (dhcp-17-168.bos.redhat.com [10.18.17.168]) by smtp.corp.redhat.com (Postfix) with ESMTP id 838FA61520; Fri, 25 Jan 2019 22:06:51 +0000 (UTC) From: John Snow To: qemu-devel@nongnu.org Date: Fri, 25 Jan 2019 17:06:41 -0500 Message-Id: <20190125220648.28164-2-jsnow@redhat.com> In-Reply-To: <20190125220648.28164-1-jsnow@redhat.com> References: <20190125220648.28164-1-jsnow@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Fri, 25 Jan 2019 22:06:52 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 1/8] cmd646: Remove unused variable X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, jsnow@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: BALATON Zoltan There was a pointer to PCIIDEState in CMD646BAR which was set but not used afterwards. Get rid of this unused variable. Signed-off-by: BALATON Zoltan Tested-by: Mark Cave-Ayland Reviewed-by: John Snow Message-id: 1e352f091aa601fb2e19771aac46529fe278dd91.1547166960.git.balaton= @eik.bme.hu Signed-off-by: John Snow --- hw/ide/cmd646.c | 1 - include/hw/ide/pci.h | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c index 6bb92d717f..41c1831f9a 100644 --- a/hw/ide/cmd646.c +++ b/hw/ide/cmd646.c @@ -123,7 +123,6 @@ static void setup_cmd646_bar(PCIIDEState *d, int bus_nu= m) CMD646BAR *bar =3D &d->cmd646_bar[bus_num]; =20 bar->bus =3D bus; - bar->pci_dev =3D d; memory_region_init_io(&bar->cmd, OBJECT(d), &cmd646_cmd_ops, bar, "cmd646-cmd", 4); memory_region_init_io(&bar->data, OBJECT(d), &cmd646_data_ops, bar, diff --git a/include/hw/ide/pci.h b/include/hw/ide/pci.h index dbc6a0383d..ed723acfb4 100644 --- a/include/hw/ide/pci.h +++ b/include/hw/ide/pci.h @@ -41,7 +41,6 @@ typedef struct CMD646BAR { MemoryRegion cmd; MemoryRegion data; IDEBus *bus; - struct PCIIDEState *pci_dev; } CMD646BAR; =20 #define TYPE_PCI_IDE "pci-ide" --=20 2.17.2