From nobody Fri Nov 7 14:20:47 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1548444868757401.4453588286725; Fri, 25 Jan 2019 11:34:28 -0800 (PST) Received: from localhost ([127.0.0.1]:49703 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gn7FD-0000VG-L1 for importer@patchew.org; Fri, 25 Jan 2019 14:34:27 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38108) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gn7Ag-0006A3-JJ for qemu-devel@nongnu.org; Fri, 25 Jan 2019 14:29:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gn78c-0005aG-Ml for qemu-devel@nongnu.org; Fri, 25 Jan 2019 14:27:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33608) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gn78c-0005a1-HY for qemu-devel@nongnu.org; Fri, 25 Jan 2019 14:27:38 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B62DCC0AE079; Fri, 25 Jan 2019 19:27:37 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-46.brq.redhat.com [10.40.204.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 15C96600D6; Fri, 25 Jan 2019 19:27:32 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Brad Smith , Kamil Rytarowski , Peter Maydell Date: Fri, 25 Jan 2019 20:27:17 +0100 Message-Id: <20190125192719.15339-2-philmd@redhat.com> In-Reply-To: <20190125192719.15339-1-philmd@redhat.com> References: <20190125192719.15339-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 25 Jan 2019 19:27:37 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 1/3] configure: Disable W^X on OpenBSD X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Li Qiang , Stefan Hajnoczi , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Since OpenBSD 6.0 [1], W^X is enforced by default [2]. TCG requires WX access. Disable W^X if it is available. This fixes: # lm32-softmmu/qemu-system-lm32 Could not allocate dynamic translator buffer # sysctl kern.wxabort=3D1 kern.wxabort: 0 -> 1 # lm32-softmmu/qemu-system-lm32 mmap: Not supported Abort trap (core dumped) # gdb -q lm32-softmmu/qemu-system-lm32 qemu-system-lm32.core (gdb) bt #0 0x000017e3c156c50a in _thread_sys___syscall () at {standard input}:5 #1 0x000017e3c15e5d7a in *_libc_mmap (addr=3DVariable "addr" is not avai= lable.) at /usr/src/lib/libc/sys/mmap.c:47 #2 0x000017e17d9abc8b in alloc_code_gen_buffer () at /usr/src/qemu/accel= /tcg/translate-all.c:1064 #3 0x000017e17d9abd04 in code_gen_alloc (tb_size=3D0) at /usr/src/qemu/a= ccel/tcg/translate-all.c:1112 #4 0x000017e17d9abe81 in tcg_exec_init (tb_size=3D0) at /usr/src/qemu/ac= cel/tcg/translate-all.c:1149 #5 0x000017e17d9897e9 in tcg_init (ms=3D0x17e45e456800) at /usr/src/qemu= /accel/tcg/tcg-all.c:66 #6 0x000017e17d9891b8 in accel_init_machine (acc=3D0x17e3c3f50800, ms=3D= 0x17e45e456800) at /usr/src/qemu/accel/accel.c:63 #7 0x000017e17d989312 in configure_accelerator (ms=3D0x17e45e456800, pro= gname=3D0x7f7fffff07b0 "lm32-softmmu/qemu-system-lm32") at /usr/src/qemu/ac= cel/accel.c:111 #8 0x000017e17d9d8616 in main (argc=3D1, argv=3D0x7f7fffff06b8, envp=3D0= x7f7fffff06c8) at vl.c:4325 [1] https://www.openbsd.org/faq/upgrade60.html [2] https://undeadly.org/cgi?action=3Darticle&sid=3D20160527203200 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- configure | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/configure b/configure index b18281c61f..f6acc028a7 100755 --- a/configure +++ b/configure @@ -5795,6 +5795,17 @@ if test "$mingw32" =3D "yes" ; then done fi =20 +# Disable W^X if available +if test "$tcg" =3D "yes" -a "$targetos" =3D "OpenBSD"; then + cat > $TMPC < Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1548444723792648.5166251942652; Fri, 25 Jan 2019 11:32:03 -0800 (PST) Received: from localhost ([127.0.0.1]:49683 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gn7Ch-0007Bg-K1 for importer@patchew.org; Fri, 25 Jan 2019 14:31:51 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38108) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gn7Ae-0006A3-WE for qemu-devel@nongnu.org; Fri, 25 Jan 2019 14:29:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gn78g-0005bW-UB for qemu-devel@nongnu.org; Fri, 25 Jan 2019 14:27:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45582) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gn78g-0005bD-Ow for qemu-devel@nongnu.org; Fri, 25 Jan 2019 14:27:42 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E45E7C05E74D; Fri, 25 Jan 2019 19:27:41 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-46.brq.redhat.com [10.40.204.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2316C600D6; Fri, 25 Jan 2019 19:27:37 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Brad Smith , Kamil Rytarowski , Peter Maydell Date: Fri, 25 Jan 2019 20:27:18 +0100 Message-Id: <20190125192719.15339-3-philmd@redhat.com> In-Reply-To: <20190125192719.15339-1-philmd@redhat.com> References: <20190125192719.15339-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 25 Jan 2019 19:27:42 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 2/3] XXX oslib-posix: Ignore fcntl("/dev/null", F_SETFL, O_NONBLOCK) failure X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Li Qiang , Stefan Hajnoczi , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Previous to OpenBSD 6.3 [1], fcntl(F_SETFL) is not permitted on memory devices. Do not assert fcntl failures on OpenBSD. This fixes: $ lm32-softmmu/qemu-system-lm32 assertion "f !=3D -1" failed: file "util/oslib-posix.c", line 247, functi= on "qemu_set_nonblock" Abort trap (core dumped) [1] The fix seems https://github.com/openbsd/src/commit/c2a35b387f9d3c "fcntl(F_SETFL) invokes the FIONBIO and FIOASYNC ioctls internally, so the memory devices (/dev/null, /dev/zero, etc) need to permit them." Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- util/oslib-posix.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/util/oslib-posix.c b/util/oslib-posix.c index 4ce1ba9ca4..064c3ae2f7 100644 --- a/util/oslib-posix.c +++ b/util/oslib-posix.c @@ -244,7 +244,9 @@ void qemu_set_nonblock(int fd) f =3D fcntl(fd, F_GETFL); assert(f !=3D -1); f =3D fcntl(fd, F_SETFL, f | O_NONBLOCK); +#ifndef __OpenBSD__ assert(f !=3D -1); +#endif } =20 int socket_set_fast_reuse(int fd) --=20 2.20.1 From nobody Fri Nov 7 14:20:47 2025 Delivered-To: importer@patchew.org Received-SPF: temperror (zoho.com: Error in retrieving data from DNS) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1548444720058301.66165314108696; Fri, 25 Jan 2019 11:32:00 -0800 (PST) Received: from localhost ([127.0.0.1]:49681 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gn7Ce-00079N-Ec for importer@patchew.org; Fri, 25 Jan 2019 14:31:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38108) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gn7Ae-0006A3-5N for qemu-devel@nongnu.org; Fri, 25 Jan 2019 14:29:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gn78r-0005gi-5m for qemu-devel@nongnu.org; Fri, 25 Jan 2019 14:27:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37146) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gn78r-0005gX-0K for qemu-devel@nongnu.org; Fri, 25 Jan 2019 14:27:53 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 29DA312F8F9; Fri, 25 Jan 2019 19:27:52 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-46.brq.redhat.com [10.40.204.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 57D39600D6; Fri, 25 Jan 2019 19:27:42 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Brad Smith , Kamil Rytarowski , Peter Maydell Date: Fri, 25 Jan 2019 20:27:19 +0100 Message-Id: <20190125192719.15339-4-philmd@redhat.com> In-Reply-To: <20190125192719.15339-1-philmd@redhat.com> References: <20190125192719.15339-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 25 Jan 2019 19:27:52 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 3/3] WIP tests/vm: Run tests on OpenBSD X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Li Qiang , Stefan Hajnoczi , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- tests/vm/openbsd | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/vm/openbsd b/tests/vm/openbsd index cfe0572c59..de907dd21c 100755 --- a/tests/vm/openbsd +++ b/tests/vm/openbsd @@ -25,9 +25,7 @@ class OpenBSDVM(basevm.BaseVM): cd $(mktemp -d /var/tmp/qemu-test.XXXXXX); tar -xf /dev/rsd1c; ./configure --cc=3Dx86_64-unknown-openbsd6.1-gcc-4.9.4 --python=3D= python2.7 {configure_opts}; - gmake --output-sync -j{jobs} {verbose}; - # XXX: "gmake check" seems to always hang or fail - #gmake --output-sync -j{jobs} check {verbose}; + gmake --output-sync -j{jobs} check {verbose}; """ =20 def build_image(self, img): --=20 2.20.1