From nobody Fri Nov 7 18:54:09 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 15484409926205.891905708676745; Fri, 25 Jan 2019 10:29:52 -0800 (PST) Received: from localhost ([127.0.0.1]:48971 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gn6Eh-0006MF-GO for importer@patchew.org; Fri, 25 Jan 2019 13:29:51 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54454) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gn6Bk-0004K0-Eg for qemu-devel@nongnu.org; Fri, 25 Jan 2019 13:26:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gn6Bi-0002dZ-EI for qemu-devel@nongnu.org; Fri, 25 Jan 2019 13:26:48 -0500 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:35289) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gn6Bi-0002Xu-1Y for qemu-devel@nongnu.org; Fri, 25 Jan 2019 13:26:46 -0500 Received: by mail-wr1-x444.google.com with SMTP id 96so11363648wrb.2 for ; Fri, 25 Jan 2019 10:26:37 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id t5sm45014921wmg.43.2019.01.25.10.26.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Jan 2019 10:26:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mPazcmGG1PcX/ZPAULBWKJ42pMvpB+sfJKcCkrgpfpM=; b=hbeztnB6zuDp7b1IxHGnf/D5cNn38PsRVQYS+PMAM5CrHYEXqEldPzTai2OEcDD9Lv dwa6+eEZtwhW/IyPKGvodqICSLbnNB5pfoavAYrrkejPUcn8k8Jzum3+PuLr3nfj1gp4 owotCIM1j9SEx5ZqoStnPpx6kfV5n3MS/HhuI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mPazcmGG1PcX/ZPAULBWKJ42pMvpB+sfJKcCkrgpfpM=; b=DPEISuw2Szw87nslKua9l0JuMr2pEjl03ZFHjS72j2dBWT16hNFv+6eAV4lX8loeUX I+uUwJufW1zsxaaZAnbBC4+jMN5coFeDxLAMEUTxYTYKvB+xHVGrZDKF+WlMAIGJ77oe JYDRAKIcAuF+fTKUd5xg7PrOD7gUexMhrUk4VbB1lxyJ/ORBmZtUZcgOqVjAoVW4maa3 7SK/ijbxiQj0Mqp1KxZNfRWlFEHmlwf7KyDO4UGzF35JNE9/xQm6xTZGgamXUhj4/kxc 3Yci0eYrwMRd+tg5np3TSLPfU31wgwz72mKgSJ2e/GiQBQKOceCVkEFu/DiAQlsHuLf6 5YmQ== X-Gm-Message-State: AJcUukc8KWb+fwGTvGvdaZZ45n5Sl5kJ83n+d5JThEKp95FzeL1YdvH/ sdxcb2rmOUPMTn89P3FG9S7SYw== X-Google-Smtp-Source: ALg8bN6/8F32FamEl2hAFhwUPBuiiM+1LzSbUGBJaB8xv2iepsfFK0EHq/QnXIQ56fT0wo192MiFkw== X-Received: by 2002:adf:b595:: with SMTP id c21mr11967853wre.125.1548440797167; Fri, 25 Jan 2019 10:26:37 -0800 (PST) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Date: Fri, 25 Jan 2019 18:26:26 +0000 Message-Id: <20190125182626.9221-8-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190125182626.9221-1-peter.maydell@linaro.org> References: <20190125182626.9221-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 Subject: [Qemu-devel] [PATCH 7/7] target/arm/translate-a64: Don't underdecode SDOT and UDOT X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Desnogues , patches@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" In the AdvSIMD scalar x indexed element and vector x indexed element encoding group, the SDOT and UDOT instructions are vector only, and their opcode is unallocated in the scalar group. Correctly UNDEF this unallocated encoding. Reported-by: Laurent Desnogues Signed-off-by: Peter Maydell --- target/arm/translate-a64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 474d9bfb5f0..30bc2412fc0 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -12641,7 +12641,7 @@ static void disas_simd_indexed(DisasContext *s, uin= t32_t insn) break; case 0x0e: /* SDOT */ case 0x1e: /* UDOT */ - if (size !=3D MO_32 || !dc_isar_feature(aa64_dp, s)) { + if (is_scalar || size !=3D MO_32 || !dc_isar_feature(aa64_dp, s)) { unallocated_encoding(s); return; } --=20 2.20.1