From nobody Fri Nov 7 18:54:09 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1548441307947399.20028273794594; Fri, 25 Jan 2019 10:35:07 -0800 (PST) Received: from localhost ([127.0.0.1]:49067 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gn6Jh-0001iU-W4 for importer@patchew.org; Fri, 25 Jan 2019 13:35:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54577) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gn6Bo-0004Ni-DZ for qemu-devel@nongnu.org; Fri, 25 Jan 2019 13:26:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gn6Bi-0002dP-A9 for qemu-devel@nongnu.org; Fri, 25 Jan 2019 13:26:52 -0500 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:46366) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gn6Bh-0002SR-V2 for qemu-devel@nongnu.org; Fri, 25 Jan 2019 13:26:46 -0500 Received: by mail-wr1-x442.google.com with SMTP id l9so11272828wrt.13 for ; Fri, 25 Jan 2019 10:26:32 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id t5sm45014921wmg.43.2019.01.25.10.26.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Jan 2019 10:26:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=O1du06yHQQZbH4UvjLrkhnO8CuAthMbLXRKig3LlNvA=; b=IQkIjy15DBzO8ZGYaVEJowdX6E59xUuiB7s9AJ2liqLNumT1oJ7izk+yabCGW0SOpR VimWqwIbYNC9l/xpWMdpHFMJiUKgJejD17eRsD4yDbsbAO60DA2JCv1Fjh+QbfSRaZSf TlhFo0Q7zvcJmdTTBeyuOfZ3AVGWguBYFM5S0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=O1du06yHQQZbH4UvjLrkhnO8CuAthMbLXRKig3LlNvA=; b=N/Yhn+po4XZBK45b5nu6Y9axWV6LiigmY0PQf15GX7d/QrL+5/XxOdDvec1t224fxT UYeL6CQW1wuoJnJjMI57y6XZsRfqJuIH1ZMEal3z6hdjxju3CtvUFx+EktYd4OImZ5Uc Zr+uPW0txz4gp9RxgGsIy8DfxNyAJPqoBuAjxawu2+N1bsEYcOMpaPPigPazrVecNiOY jgyRM3eTO7v51u6lska/uSlR0RyVkDAz9HehmKX9OpvKpro8TxZPJ0pC3IJ4LCgQd3Xu BZZVECRBA/Io52EHa94FI2dh4t2EIAcMB6r0vsTRQkzwTVOGNpi/95nngr2DQf2wKaPo yanQ== X-Gm-Message-State: AJcUukcPkQvczVW1Awxcxj3UBu0ECwI5NnHxN0m0v0tIWjhDvWtQ8ZDq FL+3msSIMo0Yzjke3XO5ic2NkQ== X-Google-Smtp-Source: ALg8bN617ovzS5uS+OyR7ZFZkXoC1ZOMyLb2gmeAqhvImJ06HZqqSzMbuuGzbJPmX7/fPGVpad2q+g== X-Received: by 2002:a5d:45d0:: with SMTP id b16mr11994858wrs.86.1548440791392; Fri, 25 Jan 2019 10:26:31 -0800 (PST) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Date: Fri, 25 Jan 2019 18:26:21 +0000 Message-Id: <20190125182626.9221-3-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190125182626.9221-1-peter.maydell@linaro.org> References: <20190125182626.9221-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::442 Subject: [Qemu-devel] [PATCH 2/7] target/arm/translate-a64: Don't underdecode PRFM X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Desnogues , patches@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The PRFM prefetch insn in the load/store with imm9 encodings requires idx field 0b00; we were underdecoding this by only checking !is_unpriv (which is equivalent to idx !=3D 2). Correctly UNDEF the unallocated encodings where idx =3D=3D 0b01 and 0b11 as well as 0b10. Reported-by: Laurent Desnogues Signed-off-by: Peter Maydell Reviewed-by: Laurent Desnogues --- target/arm/translate-a64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index e6df303e321..8e081758e03 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -2803,7 +2803,7 @@ static void disas_ldst_reg_imm9(DisasContext *s, uint= 32_t insn, } else { if (size =3D=3D 3 && opc =3D=3D 2) { /* PRFM - prefetch */ - if (is_unpriv) { + if (idx !=3D 0) { unallocated_encoding(s); return; } --=20 2.20.1