From nobody Fri Nov 7 18:54:09 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1548441322088551.8037053177827; Fri, 25 Jan 2019 10:35:22 -0800 (PST) Received: from localhost ([127.0.0.1]:49069 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gn6Jw-0001p5-4h for importer@patchew.org; Fri, 25 Jan 2019 13:35:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54486) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gn6Bl-0004KP-9w for qemu-devel@nongnu.org; Fri, 25 Jan 2019 13:26:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gn6Bi-0002f4-PB for qemu-devel@nongnu.org; Fri, 25 Jan 2019 13:26:49 -0500 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:51124) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gn6Bi-0002Rz-GP for qemu-devel@nongnu.org; Fri, 25 Jan 2019 13:26:46 -0500 Received: by mail-wm1-x341.google.com with SMTP id n190so7708323wmd.0 for ; Fri, 25 Jan 2019 10:26:31 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id t5sm45014921wmg.43.2019.01.25.10.26.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Jan 2019 10:26:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ux8QnJxJ6UvqTD3RS+ri03Z+8tArGuUjGhPYKu3EKSc=; b=ZcD1mjQ92jJfQPQEXjiSqEB8/87BHecT2vKObPpUFLpbWa7UzHCLotizZzmmPmNyxZ MoqTwLWPNmZP74rpiJu8Pdu6i7P2Dd9bqGbrMRwTZPOG0V3jkg9RNsVLselezbnjbkiD 4M/ZsotwUhi6RBgqEEAwCckMrKAtWbO/Yq7Gk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ux8QnJxJ6UvqTD3RS+ri03Z+8tArGuUjGhPYKu3EKSc=; b=KzzkMvQKwGMKWTExWuXTVT9v5Hvaefx9/+CYLqG6imc0F85dylXmN0//LjXk7vVbnv FuFXab0Euc29De8jUdno/GCrKOQd462nRrRaahywDVY+AKHTInefUE/1ABBFalyoJ3Rp DWMx+Qvrm4iQTMzfMaoxy7uxLJpqqJ8GgFmNDa5N+WWPH9B2Ki05zeg9E2OxuLgmVj4V 4Oaklw+Nqus5eQ1i9AAWnztpC88jffGLmg9NiTj8LnxDYf9sacPNlCQWMcIqITc/sFdQ h3zHk9+clHGN/cFKb20so/yUP28tpSigYu7IMbQesXFrQQN5jpiIYi8uJ5RDnih/2g0C PcGA== X-Gm-Message-State: AJcUukcllsWSm7JJQ6r0j/A5USDKBK+FHU1t4MdOARL4hhh6zJvQQOSi xgNakkU0qJWmRp4jX13NfFKVVI0qK39kAA== X-Google-Smtp-Source: ALg8bN7uyU5dN877piLo8RQ7fNiBVEU3YlmubKgjOprVzjbZ28fgrep99w7s5O2TF8EquflPP4Wkuw== X-Received: by 2002:a1c:b10a:: with SMTP id a10mr7669266wmf.148.1548440790092; Fri, 25 Jan 2019 10:26:30 -0800 (PST) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Date: Fri, 25 Jan 2019 18:26:20 +0000 Message-Id: <20190125182626.9221-2-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190125182626.9221-1-peter.maydell@linaro.org> References: <20190125182626.9221-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 Subject: [Qemu-devel] [PATCH 1/7] target/arm/translate-a64: Don't underdecode system instructions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Desnogues , patches@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The "system instructions" and "system register move" subcategories of "branches, exception generating and system instructions" for A64 only apply if bits [23:22] are zero; other values are currently unallocated. Correctly UNDEF these unallocated encodings. Reported-by: Laurent Desnogues Signed-off-by: Peter Maydell Reviewed-by: Laurent Desnogues --- target/arm/translate-a64.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 4d28a27c3bd..e6df303e321 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -2144,7 +2144,11 @@ static void disas_b_exc_sys(DisasContext *s, uint32_= t insn) break; case 0x6a: /* Exception generation / System */ if (insn & (1 << 24)) { - disas_system(s, insn); + if (extract32(insn, 22, 2) =3D=3D 0) { + disas_system(s, insn); + } else { + unallocated_encoding(s); + } } else { disas_exc(s, insn); } --=20 2.20.1