From nobody Fri Nov 7 18:35:05 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1548438461071826.365237284053; Fri, 25 Jan 2019 09:47:41 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D1F84C0BEAA4; Fri, 25 Jan 2019 17:47:38 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9509A1054FD8; Fri, 25 Jan 2019 17:47:38 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4C3DC3F605; Fri, 25 Jan 2019 17:47:38 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x0PHlIh7012916 for ; Fri, 25 Jan 2019 12:47:18 -0500 Received: by smtp.corp.redhat.com (Postfix) id BD1501057072; Fri, 25 Jan 2019 17:47:18 +0000 (UTC) Received: from linux.fritz.box.com (ovpn-117-226.ams2.redhat.com [10.36.117.226]) by smtp.corp.redhat.com (Postfix) with ESMTP id CF5181001F4A; Fri, 25 Jan 2019 17:47:16 +0000 (UTC) From: Kevin Wolf To: qemu-block@nongnu.org Date: Fri, 25 Jan 2019 18:46:53 +0100 Message-Id: <20190125174653.4604-4-kwolf@redhat.com> In-Reply-To: <20190125174653.4604-1-kwolf@redhat.com> References: <20190125174653.4604-1-kwolf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com Cc: kwolf@redhat.com, pkrempa@redhat.com, libvir-list@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com Subject: [libvirt] [PATCH 3/3] scsi-disk: Deprecate device_id fallback to BlockBackend name X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 25 Jan 2019 17:47:39 +0000 (UTC) Content-Type: text/plain; charset="utf-8" We should never have exposed BlockBackend names to the guest, it's a host detail. Deprecate this behaviour. Users who need to maintain the guest ABI can explicitly set the value with the device_id property. Signed-off-by: Kevin Wolf --- hw/scsi/scsi-disk.c | 5 +++++ qemu-deprecated.texi | 22 +++++++++++++++++++++- 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index e74e1e7c48..38f1fe2570 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -2366,6 +2366,11 @@ static void scsi_realize(SCSIDevice *dev, Error **er= rp) const char *str =3D blk_name(s->qdev.conf.blk); if (str && *str) { s->device_id =3D g_strdup(str); + warn_report("Using the backend drive ID for the Device " + "Identification VPD page is deprecated. " + "Please specify the serial or device_id option= s " + "explicitly to avoid guest-visible changes in " + "future QEMU versions."); } } } diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi index 219206a836..a426d8245d 100644 --- a/qemu-deprecated.texi +++ b/qemu-deprecated.texi @@ -146,7 +146,7 @@ This machine type uses an unmaintained firmware, broken= in lots of ways, and unable to start post-2004 operating systems. 40p machine type should be used instead. =20 -@section Device options +@section Devices =20 @subsection Block device options =20 @@ -170,6 +170,26 @@ The above, converted to the current supported format: =20 @code{json:@{"file.driver":"rbd", "file.pool":"rbd", "file.image":"name"@}} =20 +@subsection scsi-disk device identification (since 4.0.0) + +The Device Identification VPD page of ``scsi-disk'' devices contains a ven= dor +specific designator that can be explicitly specified using the ``device_id= '' +property since 4.0.0. + +If ``device_id'' is not given, the implementation falls back to reusing any +specified serial number for this field. If the serial number is not given +either and ``drive=3DX'' was used where ``X'' is a drive ID, this drive ID= is +given to the guest instead. This is backend information that should not +to be exposed to guests. + +Therefore, this behaviour is deprecated and future versions will change the +guest-visible behaviour (e.g. by leaving out the vendor specific designato= r) +for the case that neither ``device_id'' nor a serial number are given, but= a +drive ID is used to create the device. + +If you need the guest-visible information to stay unchanged, add an explic= it +``device_id'' option to your QEMU invocation. + @subsection vio-spapr-device device options =20 @subsubsection "irq": "" (since 3.0.0) --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list