From nobody Fri Nov 7 14:40:31 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=yadro.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1548431365511201.72117284266176; Fri, 25 Jan 2019 07:49:25 -0800 (PST) Received: from localhost ([127.0.0.1]:46503 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gn3jK-0006HR-Et for importer@patchew.org; Fri, 25 Jan 2019 10:49:18 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44716) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gn3iG-0005vJ-SO for qemu-devel@nongnu.org; Fri, 25 Jan 2019 10:48:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gn3iE-0003ho-TA for qemu-devel@nongnu.org; Fri, 25 Jan 2019 10:48:12 -0500 Received: from mta-01.yadro.com ([89.207.88.251]:54328) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gn3iC-0003eT-Oe for qemu-devel@nongnu.org; Fri, 25 Jan 2019 10:48:08 -0500 Received: from localhost (unknown [127.0.0.1]) by mta-01.yadro.com (Postfix) with ESMTP id B3BC741957; Fri, 25 Jan 2019 15:48:04 +0000 (UTC) Received: from mta-01.yadro.com ([127.0.0.1]) by localhost (mta-01.yadro.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WwV4VyKVgrBt; Fri, 25 Jan 2019 18:48:03 +0300 (MSK) Received: from T-EXCH-02.corp.yadro.com (t-exch-02.corp.yadro.com [172.17.10.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mta-01.yadro.com (Postfix) with ESMTPS id 8379E41955; Fri, 25 Jan 2019 18:48:03 +0300 (MSK) Received: from localhost (172.17.1.50) by T-EXCH-02.corp.yadro.com (172.17.10.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.669.32; Fri, 25 Jan 2019 18:48:03 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yadro.com; h= content-type:content-type:content-transfer-encoding:mime-version :x-mailer:message-id:date:date:subject:subject:from:from :received:received:received; s=mta-01; t=1548431283; x= 1550245684; bh=A2jhtV1fzYQuaV3Dk+s7v7T0iWZqDhA1x1J487dE1fg=; b=b LEJ/iKcilntS4DkbVW2NLvjDt3mHjhlt1to/pnauvtSrwwENL38VL2Y342NgqzCs +F2+9PE2GmhAKYOn9MGiG0twnngFp7OOnBrABkbkZ+dtOLyJyAwNCwP0fY3//68H qQuGBn0OztlKL9ek9S6gKVnNy0tYa12Jmb/E9R++bk= X-Virus-Scanned: amavisd-new at yadro.com From: Roman Bolshakov To: Date: Fri, 25 Jan 2019 18:47:43 +0300 Message-ID: <20190125154743.14498-1-r.bolshakov@yadro.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Originating-IP: [172.17.1.50] X-ClientProxiedBy: T-EXCH-01.corp.yadro.com (172.17.10.101) To T-EXCH-02.corp.yadro.com (172.17.10.102) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 89.207.88.251 Subject: [Qemu-devel] [PATCH] i386: hvf: Don't miss 16-bit displacement X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Roman Bolshakov , Eduardo Habkost , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" In 16-bit addressing mode, when Mod =3D 0 and R/M =3D 6, decoded displaceme= nt doesn't reach decode_linear_addr and gets lost. Instructions that involve the combination of ModRM always get a pointer with zero offset from the beginning of DS segment. The change fixes drawing in F-BIRD from day 1 of '18 advent calendar. Signed-off-by: Roman Bolshakov --- target/i386/hvf/x86_decode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/hvf/x86_decode.c b/target/i386/hvf/x86_decode.c index 5f513c5563..9ef7d7513f 100644 --- a/target/i386/hvf/x86_decode.c +++ b/target/i386/hvf/x86_decode.c @@ -1642,7 +1642,7 @@ void calc_modrm_operand16(CPUX86State *env, struct x8= 6_decode *decode, X86Seg seg =3D R_DS; =20 if (!decode->modrm.mod && 6 =3D=3D decode->modrm.rm) { - op->ptr =3D (uint16_t)decode->displacement; + ptr =3D decode->displacement; goto calc_addr; } =20 --=20 2.20.1