From nobody Fri Nov 7 18:50:31 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=virtuozzo.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 154833286197965.18578068352781; Thu, 24 Jan 2019 04:27:41 -0800 (PST) Received: from localhost ([127.0.0.1]:52648 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gme6e-0001m7-Ub for importer@patchew.org; Thu, 24 Jan 2019 07:27:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37146) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gme51-0000pz-63 for qemu-devel@nongnu.org; Thu, 24 Jan 2019 07:26:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gme50-0004mU-5O for qemu-devel@nongnu.org; Thu, 24 Jan 2019 07:25:59 -0500 Received: from relay.sw.ru ([185.231.240.75]:36116) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gme4q-00047t-Q7; Thu, 24 Jan 2019 07:25:50 -0500 Received: from [10.28.8.145] (helo=kvm.sw.ru) by relay.sw.ru with esmtp (Exim 4.91) (envelope-from ) id 1gme4U-0007pT-79; Thu, 24 Jan 2019 15:25:26 +0300 From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org, qemu-devel@nongnu.org Date: Thu, 24 Jan 2019 15:25:25 +0300 Message-Id: <20190124122525.145968-3-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20190124122525.145968-1-vsementsov@virtuozzo.com> References: <20190124122525.145968-1-vsementsov@virtuozzo.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 185.231.240.75 Subject: [Qemu-devel] [PATCH 2/2] iotest: fix 169: do not run qmp_cont in RUN_STATE_FINISH_MIGRATE X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, armbru@redhat.com, lcapitulino@redhat.com, mreitz@redhat.com, dgilbert@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" qmp_cont fails if vm in RUN_STATE_FINISH_MIGRATE, so let's wait for final RUN_STATE_POSTMIGRATE. Also, while being here, check qmp_cont result. Reported-by: Max Reitz Signed-off-by: Vladimir Sementsov-Ogievskiy Tested-by: Max Reitz --- tests/qemu-iotests/169 | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/169 b/tests/qemu-iotests/169 index 527aebd0cb..7e06cc1145 100755 --- a/tests/qemu-iotests/169 +++ b/tests/qemu-iotests/169 @@ -102,12 +102,17 @@ class TestDirtyBitmapMigration(iotests.QMPTestCase): event =3D self.vm_a.event_wait('MIGRATION') if event['data']['status'] =3D=3D 'completed': break + while True: + result =3D self.vm_a.qmp('query-status') + if (result['return']['status'] =3D=3D 'postmigrate'): + break =20 # test that bitmap is still here removed =3D (not migrate_bitmaps) and persistent self.check_bitmap(self.vm_a, False if removed else sha256) =20 - self.vm_a.qmp('cont') + result =3D self.vm_a.qmp('cont') + self.assert_qmp(result, 'return', {}) =20 # test that bitmap is still here after invalidation self.check_bitmap(self.vm_a, sha256) --=20 2.18.0