From nobody Tue Feb 10 04:56:15 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=mail.uni-paderborn.de Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1548150579139361.6279216183834; Tue, 22 Jan 2019 01:49:39 -0800 (PST) Received: from localhost ([127.0.0.1]:41711 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1glsgc-00078O-3Y for importer@patchew.org; Tue, 22 Jan 2019 04:49:38 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58945) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1glsVW-00068S-Ew for qemu-devel@nongnu.org; Tue, 22 Jan 2019 04:38:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1glsOR-0005ve-3z for qemu-devel@nongnu.org; Tue, 22 Jan 2019 04:30:51 -0500 Received: from mail.uni-paderborn.de ([131.234.142.9]:55078) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1glsOQ-0005T4-Sh; Tue, 22 Jan 2019 04:30:51 -0500 Received: from tweenies.uni-paderborn.de ([131.234.189.21] helo=localhost.localdomain) by mail.uni-paderborn.de with esmtp (Exim 4.89 telepax) id 1glsO0-0001uT-3s; Tue, 22 Jan 2019 10:30:24 +0100 Received: from mail.uni-paderborn.de by tweenies with queue id 3069628-4; Tue, 22 Jan 2019 09:30:23 GMT X-Envelope-From: From: Bastian Koppelmann To: sagark@eecs.berkeley.edu, palmer@sifive.com, kbastian@mail.uni-paderborn.de Date: Tue, 22 Jan 2019 10:29:03 +0100 Message-Id: <20190122092909.5341-30-kbastian@mail.uni-paderborn.de> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190122092909.5341-1-kbastian@mail.uni-paderborn.de> References: <20190122092909.5341-1-kbastian@mail.uni-paderborn.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-PMX-Version: 6.4.6.2792898, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2019.1.22.92116, AntiVirus-Engine: 5.56.1, AntiVirus-Data: 2019.1.18.5561000 X-IMT-Spam-Score: 0.0 () X-IMT-Authenticated-Sender: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 131.234.142.9 Subject: [Qemu-devel] [PATCH v5 29/35] target/riscv: Remove gen_system() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-riscv@nongnu.org, peer.adelt@hni.uni-paderborn.de, richard.henderson@linaro.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" with all 16 bit insns moved to decodetree no path is falling back to gen_system(), so we can remove it. Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Signed-off-by: Peer Adelt --- target/riscv/translate.c | 31 ------------------------------- 1 file changed, 31 deletions(-) diff --git a/target/riscv/translate.c b/target/riscv/translate.c index d0b0fca12b..0e37beb68e 100644 --- a/target/riscv/translate.c +++ b/target/riscv/translate.c @@ -427,32 +427,6 @@ static void gen_set_rm(DisasContext *ctx, int rm) tcg_temp_free_i32(t0); } =20 -static void gen_system(CPURISCVState *env, DisasContext *ctx, uint32_t opc, - int rd, int rs1, int csr) -{ - tcg_gen_movi_tl(cpu_pc, ctx->base.pc_next); - - switch (opc) { - case OPC_RISC_ECALL: - switch (csr) { - case 0x0: /* ECALL */ - /* always generates U-level ECALL, fixed in do_interrupt handl= er */ - generate_exception(ctx, RISCV_EXCP_U_ECALL); - tcg_gen_exit_tb(NULL, 0); /* no chaining */ - ctx->base.is_jmp =3D DISAS_NORETURN; - break; - case 0x1: /* EBREAK */ - generate_exception(ctx, RISCV_EXCP_BREAKPOINT); - tcg_gen_exit_tb(NULL, 0); /* no chaining */ - ctx->base.is_jmp =3D DISAS_NORETURN; - break; - default: - gen_exception_illegal(ctx); - break; - } - break; - } -} =20 static void decode_RV32_64C0(DisasContext *ctx) { @@ -628,7 +602,6 @@ bool decode_insn16(DisasContext *ctx, uint16_t insn); =20 static void decode_RV32_64G(CPURISCVState *env, DisasContext *ctx) { - int rs1, rd; uint32_t op; =20 /* We do not do misaligned address check here: the address should neve= r be @@ -637,13 +610,9 @@ static void decode_RV32_64G(CPURISCVState *env, DisasC= ontext *ctx) * perform the misaligned instruction fetch */ =20 op =3D MASK_OP_MAJOR(ctx->opcode); - rs1 =3D GET_RS1(ctx->opcode); - rd =3D GET_RD(ctx->opcode); =20 switch (op) { case OPC_RISC_SYSTEM: - gen_system(env, ctx, MASK_OP_SYSTEM(ctx->opcode), rd, rs1, - (ctx->opcode & 0xFFF00000) >> 20); break; default: gen_exception_illegal(ctx); --=20 2.20.1