From nobody Fri Nov 7 11:49:34 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1547892556081642.1479502475694; Sat, 19 Jan 2019 02:09:16 -0800 (PST) Received: from localhost ([127.0.0.1]:53780 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gknYx-0005a6-2G for importer@patchew.org; Sat, 19 Jan 2019 05:09:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55345) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gknTb-0001NL-Fp for qemu-devel@nongnu.org; Sat, 19 Jan 2019 05:03:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gknTZ-00082m-FM for qemu-devel@nongnu.org; Sat, 19 Jan 2019 05:03:43 -0500 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:37957) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gknTZ-0007wT-2u for qemu-devel@nongnu.org; Sat, 19 Jan 2019 05:03:41 -0500 Received: by mail-wr1-x443.google.com with SMTP id v13so17926965wrw.5 for ; Sat, 19 Jan 2019 02:03:31 -0800 (PST) Received: from localhost.localdomain ([176.228.155.165]) by smtp.gmail.com with ESMTPSA id j8sm113868847wmd.0.2019.01.19.02.03.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 19 Jan 2019 02:03:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=DjY5u1tA0CXcT1bVZvYnIiD+NeHhUiM9nMhxIpSLSg0=; b=n8n7l/0l/Zqa4eF0RA7/4PNGfUi9QHUO3SctSfBOC176rP9NugpS4aTkA06mRqiDgy IYgtx8DDcDCRA+XfflIKdraBlwUls0NPuXeO+u5X2C0AZb3E6xphzIDx4uInGzuE+ifI H06057ktV1Xy7MG0VfE8vslvOoQyOvTvawEd5w+0YzqsycNSRFfQOp+HE8wPpcN5b7Ev /0OxuJUHzSp1gFw59TqcLy7ox0q625nCDw51hLfb9EksalY0iIz6woW+GDY9oXR925nb KEfy9r5GfkBDOkL+FlhF0/lT/ooqWv2knIHb3CnmTQ5fTYHDmPPvxUiQnll70L/o2wIX A72w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=DjY5u1tA0CXcT1bVZvYnIiD+NeHhUiM9nMhxIpSLSg0=; b=D3nW0B0SpqqNqyDJwfrwcsf76wKsrmBLU24slLinKk6b4gx0NHqcX+WAxiftLwEUpx z5n5AyPyRHShM5BrKZVkgUgM0FUuzgpkkFGNsvAvFj8Ep6eQNZJvAI+E+y15jXtrRzUS 5895LKiY58xIY8DUdFjY6Kbqqr7MCG+fRLKdLayTsdiNMHjjKt14zTHobsGVzTGeALm1 0NRp7jqPaytZqwdDgtn+nWDkrBB9vewL+xDFKqVfpZorzlp21GbOWQ1GwQq5d2dfPqiO /+lT+duCS5u7dSWzHJIgCf4YLYZlzGlunjDjibmxRiT8LV35YP/dLUhMM1e3uuwlLqTQ kcRg== X-Gm-Message-State: AJcUukfOXQqpXErkS84P9ig7ByxF0YQIEnyRY6/EtyeJ1TQPqnLF/BEZ 0FKzn3sdDkynfXehpyw5XQgiIlSN X-Google-Smtp-Source: ALg8bN7eok4KKlLLUxM7/pw1VV3aLRLO6OvkJKqRif4gF4jNG4Ixh8/0HLk1XPG2XDi1p2CZR58Iig== X-Received: by 2002:adf:f903:: with SMTP id b3mr20877662wrr.82.1547892210474; Sat, 19 Jan 2019 02:03:30 -0800 (PST) From: Marcel Apfelbaum To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Sat, 19 Jan 2019 12:03:12 +0200 Message-Id: <20190119100315.23985-8-marcel.apfelbaum@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190119100315.23985-1-marcel.apfelbaum@gmail.com> References: <20190119100315.23985-1-marcel.apfelbaum@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::443 Subject: [Qemu-devel] [PATCH PULL 07/10] hw: rdma: fix an off-by-one issue X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cohuck@redhat.com, liq3ea@163.com, yuval.shaia@oracle.com, kamalheib1@gmail.com, philmd@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Li Qiang In rdma_rm_get_backend_gid_index(), the 'sgid_idx' is used to index the array 'dev_res->port.gid_tbl' which size is MAX_PORT_GIDS. Current the 'sgid_idx' may be MAX_PORT_GIDS thus cause an off-by-one issue. Spotted by Coverity: CID 1398594 Signed-off-by: Li Qiang Message-Id: <20190103131251.49271-1-liq3ea@163.com> Signed-off-by: Marcel Apfelbaum --- hw/rdma/rdma_rm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rdma/rdma_rm.c b/hw/rdma/rdma_rm.c index 8bf241e91f..268ff633a4 100644 --- a/hw/rdma/rdma_rm.c +++ b/hw/rdma/rdma_rm.c @@ -579,7 +579,7 @@ int rdma_rm_del_gid(RdmaDeviceResources *dev_res, RdmaB= ackendDev *backend_dev, int rdma_rm_get_backend_gid_index(RdmaDeviceResources *dev_res, RdmaBackendDev *backend_dev, int sgid_id= x) { - if (unlikely(sgid_idx < 0 || sgid_idx > MAX_PORT_GIDS)) { + if (unlikely(sgid_idx < 0 || sgid_idx >=3D MAX_PORT_GIDS)) { pr_dbg("Got invalid sgid_idx %d\n", sgid_idx); return -EINVAL; } --=20 2.17.1