From nobody Fri Nov 7 12:00:01 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1547756584725660.3294782973113; Thu, 17 Jan 2019 12:23:04 -0800 (PST) Received: from localhost ([127.0.0.1]:54450 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkEBh-000094-HR for importer@patchew.org; Thu, 17 Jan 2019 15:22:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46503) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkE6u-0004pZ-H6 for qemu-devel@nongnu.org; Thu, 17 Jan 2019 15:17:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gkE6t-0003iv-UX for qemu-devel@nongnu.org; Thu, 17 Jan 2019 15:17:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51838) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gkE6t-0003hD-Oj for qemu-devel@nongnu.org; Thu, 17 Jan 2019 15:17:55 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0A3877AE98; Thu, 17 Jan 2019 20:17:55 +0000 (UTC) Received: from localhost (ovpn-116-78.gru2.redhat.com [10.97.116.78]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8F548608E5; Thu, 17 Jan 2019 20:17:54 +0000 (UTC) From: Eduardo Habkost To: Peter Maydell , qemu-devel@nongnu.org Date: Thu, 17 Jan 2019 18:17:38 -0200 Message-Id: <20190117201743.20470-5-ehabkost@redhat.com> In-Reply-To: <20190117201743.20470-1-ehabkost@redhat.com> References: <20190117201743.20470-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 17 Jan 2019 20:17:55 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 4/9] check-venv: use recorded Python version X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Cleber Rosa Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Cleber Rosa The current approach works fine, but it runs Python on every make command (even if it's not related to the venv usage). This is just an optimization, and not a change of behavior. Signed-off-by: Cleber Rosa Message-Id: <20181109150710.31085-3-crosa@redhat.com> Signed-off-by: Eduardo Habkost --- tests/Makefile.include | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index f403a6571d..f8d4399293 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -958,8 +958,7 @@ TESTS_RESULTS_DIR=3D$(BUILD_DIR)/tests/results # information please refer to "avocado --help". AVOCADO_SHOW=3Dnone =20 -PYTHON3 =3D $(shell $(PYTHON) -c 'import sys; print(1 if sys.version_info = >=3D (3, 0) else 0)') -ifeq ($(PYTHON3), 1) +ifneq ($(findstring v2,"v$(PYTHON_VERSION)"),v2) $(TESTS_VENV_DIR): $(TESTS_VENV_REQ) $(call quiet-command, \ $(PYTHON) -m venv --system-site-packages $@, \ --=20 2.18.0.rc1.1.g3f1ff2140