From nobody Mon Feb 9 18:44:19 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1547485196029218.58505820506025; Mon, 14 Jan 2019 08:59:56 -0800 (PST) Received: from localhost ([127.0.0.1]:46186 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gj5ac-0005f2-IU for importer@patchew.org; Mon, 14 Jan 2019 11:59:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60853) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gj5CN-00025a-UP for qemu-devel@nongnu.org; Mon, 14 Jan 2019 11:34:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gj5CM-0001zM-DF for qemu-devel@nongnu.org; Mon, 14 Jan 2019 11:34:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55446) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gj5CJ-0001cS-JV; Mon, 14 Jan 2019 11:34:47 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8EEE111536; Mon, 14 Jan 2019 16:34:20 +0000 (UTC) Received: from localhost (unknown [10.36.118.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7B7F35D73F; Mon, 14 Jan 2019 16:34:19 +0000 (UTC) From: Stefan Hajnoczi To: qemu-devel@nongnu.org Date: Mon, 14 Jan 2019 16:34:15 +0000 Message-Id: <20190114163416.1094-2-stefanha@redhat.com> In-Reply-To: <20190114163416.1094-1-stefanha@redhat.com> References: <20190114163416.1094-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 14 Jan 2019 16:34:20 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 1/2] aio-posix: Unregister fd from ctx epoll when removing fd_handler. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , qemu-block@nongnu.org, Stefan Weil , Max Reitz , Remy Noel , Stefan Hajnoczi , Paolo Bonzini , Kevin Wolf Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Remy Noel Cleaning the events will cause aio_epoll_update to unregister the fd. Otherwise, the fd is kept registered until it is destroyed. Signed-off-by: Remy Noel Reviewed-by: Stefan Hajnoczi Reviewed-by: Paolo Bonzini Message-id: 20181220152030.28035-2-remy.noel@blade-group.com Signed-off-by: Stefan Hajnoczi --- util/aio-posix.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/util/aio-posix.c b/util/aio-posix.c index 51c41ed3c9..a927319d2c 100644 --- a/util/aio-posix.c +++ b/util/aio-posix.c @@ -245,6 +245,9 @@ void aio_set_fd_handler(AioContext *ctx, QLIST_REMOVE(node, node); deleted =3D true; } + /* Clean events in order to unregister fd from the ctx epoll. */ + node->pfd.events =3D 0; + poll_disable_change =3D -!node->io_poll; } else { poll_disable_change =3D !io_poll - (node && !node->io_poll); --=20 2.20.1