From nobody Tue May 21 17:54:48 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=126.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1547471542133767.3729075818326; Mon, 14 Jan 2019 05:12:22 -0800 (PST) Received: from localhost ([127.0.0.1]:48390 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gj22P-0007Yt-6N for importer@patchew.org; Mon, 14 Jan 2019 08:12:21 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35337) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gj20n-0006fC-UJ for qemu-devel@nongnu.org; Mon, 14 Jan 2019 08:10:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gj20m-0007sF-O4 for qemu-devel@nongnu.org; Mon, 14 Jan 2019 08:10:41 -0500 Received: from m50-111.126.com ([123.125.50.111]:51086) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gj20j-0007jC-F6 for qemu-devel@nongnu.org; Mon, 14 Jan 2019 08:10:40 -0500 Received: from bogon.bytedance.net (unknown [120.52.147.46]) by smtp5 (Coremail) with SMTP id jtKowAD3H_I6ijxcLPMWAA--.270S2; Mon, 14 Jan 2019 21:10:27 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=myEuP Jd3JYI3kkUPCAYHsTVp4Url3FX1z/vsJiJiP7s=; b=AwBa9eOewHGtb84t3naUy pR53lGKKqePKK22lGk4XHkanMruwoyMXl4dxSvxzlNUJ8MJG7LAOE/L+4tCTrgvv gtGDkTSvEY0GI6cG7E0kH2KQod564xdhHZi4VoB5ZwuWCZzuv4qPFaUzVrfOHWhO hot8APLrcHn5eH5Piyj+Ls= From: Fei Li To: qemu-devel@nongnu.org Date: Mon, 14 Jan 2019 21:10:15 +0800 Message-Id: <20190114131015.52967-1-lifei1214@126.com> X-Mailer: git-send-email 2.17.2 (Apple Git-113) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: jtKowAD3H_I6ijxcLPMWAA--.270S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7Xw4rWrWruF4UCFWfAFy3twb_yoWfGrb_Aa 40kFsxua1DGr15CF1qyan7Zr1rAFy8uFyrKr17Jr4rKFyUC3WUAr18KFs3Jw47Wws3ZFy7 u39rJFWjvr9rujkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU8QyCtUUUUU== X-Originating-IP: [120.52.147.46] X-CM-SenderInfo: 5olivxarsrkqqrswhudrp/1tbiFgM8IVpD8I-GNwAAsf X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 123.125.50.111 Subject: [Qemu-devel] [PATCH v2] hw/misc/edu: add msi_uninit() for pci_edu_uninit() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jiri Slaby , shirley17fei@gmail.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Fei Li Let's supplement the msi_uninit() when failing to realize the pci edu device. Reported-by: Markus Armbruster Signed-off-by: Fei Li Reviewed-by: Marcel Apfelbaum Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Peter Xu --- hw/misc/edu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/misc/edu.c b/hw/misc/edu.c index cdcf550dd7..ceaf688bfb 100644 --- a/hw/misc/edu.c +++ b/hw/misc/edu.c @@ -377,6 +377,7 @@ static void pci_edu_uninit(PCIDevice *pdev) qemu_mutex_destroy(&edu->thr_mutex); =20 timer_del(&edu->dma_timer); + msi_uninit(pdev); } =20 static void edu_obj_uint64(Object *obj, Visitor *v, const char *name, --=20 2.17.2 (Apple Git-113)