From nobody Fri Nov 7 07:08:55 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1547464067840819.2366024433775; Mon, 14 Jan 2019 03:07:47 -0800 (PST) Received: from localhost ([127.0.0.1]:46381 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gj05n-0007rx-EU for importer@patchew.org; Mon, 14 Jan 2019 06:07:43 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55278) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gizlZ-0000Am-7b for qemu-devel@nongnu.org; Mon, 14 Jan 2019 05:46:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gizlY-0008OZ-GX for qemu-devel@nongnu.org; Mon, 14 Jan 2019 05:46:49 -0500 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:37786) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gizlY-0008IU-Au for qemu-devel@nongnu.org; Mon, 14 Jan 2019 05:46:48 -0500 Received: by mail-wm1-x342.google.com with SMTP id g67so8304267wmd.2 for ; Mon, 14 Jan 2019 02:46:46 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id h2sm70917634wrv.87.2019.01.14.02.46.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 Jan 2019 02:46:44 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 87F143E04BD; Mon, 14 Jan 2019 10:46:44 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=inV+d3aDUzwvG6cM+NkTMc7UN3CsYDCT3H1cyy2IRWU=; b=agppRXb5QnQGSFgwr4CbT2VOUX32XdgsA3PzI1Ire6AvLVUJRDFnCb1vQ9pn5CDTPM 8AtVDDeZOXrW5jdw0WSQgWU9f8R1AH/Z4Ak3EZYTu4+DhF/N9l94VFeO5KkA2N2vQn5u LVALp2fzPetTJcVD6iPu2pXApBemrB7dR8PTk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=inV+d3aDUzwvG6cM+NkTMc7UN3CsYDCT3H1cyy2IRWU=; b=X86STnngEJSF5eJv4e9WJ1vOFZZAiMmgfecUaXjzC8bBTSRzgg1FvbD4l53dpiA/tx 5vVQHPRV1wkKD1q83IPu9bbsv8zIZwDCJyAkwpgMSpHc0pSyc2a4jk6AXHemQpmSM+Bx Ss/8WofCrr7ehH+14loxItZd1mPXPvBsLvY8ssQym1kGGqF8jHOQyzCbKFrtfJOWvBRu xJ4k0LDdC3TVj69Ln0gWAjXjGnskwO9/pxWiTbSUaDfwfiH9eVeMC/4/wQEYwljfXUZE 4TGFB56/riKubSmKHas/EGgzBqXzjVDxl4aYeU8mXj6oNTXYAYYTbvG6ijSQmTWTCdcy gm9w== X-Gm-Message-State: AJcUukeZlrgVBgLIX1FaXXb64YE7pGHOZ0c+sLAcsPG/SOOzv0TqaSlp L71iKjv0vaALQC3KtGT2CHoo1g== X-Google-Smtp-Source: ALg8bN4gO+hUjE9PajxUu6g9t/U58LrusxEyCdRBcakXSpCI5v/OnJ5TxlafiDnX6LsFRWtmjYu3WQ== X-Received: by 2002:a1c:ef11:: with SMTP id n17mr11071720wmh.112.1547462805577; Mon, 14 Jan 2019 02:46:45 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Mon, 14 Jan 2019 10:46:41 +0000 Message-Id: <20190114104641.19186-1-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::342 Subject: [Qemu-devel] [RFC PATCH] tests: use g_usleep instead of rem = sleep(time) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, cota@braap.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , ehabkost@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Relying on sleep to always return having slept isn't safe as a signal may have occurred. If signals are constantly incoming the program will never reach it's termination condition. This is believed to be the mechanism causing time outs for qht-test in Travis. The glib g_usleep() deals with all of this for us so lets use it instead. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Emilio G. Cota Reviewed-by: Peter Maydell Reviewed-by: Richard Henderson --- tests/atomic64-bench.c | 6 ++---- tests/atomic_add-bench.c | 6 ++---- tests/qht-bench.c | 6 ++---- 3 files changed, 6 insertions(+), 12 deletions(-) diff --git a/tests/atomic64-bench.c b/tests/atomic64-bench.c index 71692560ed..121a8c14f4 100644 --- a/tests/atomic64-bench.c +++ b/tests/atomic64-bench.c @@ -74,16 +74,14 @@ static void *thread_func(void *arg) =20 static void run_test(void) { - unsigned int remaining; unsigned int i; =20 while (atomic_read(&n_ready_threads) !=3D n_threads) { cpu_relax(); } + atomic_set(&test_start, true); - do { - remaining =3D sleep(duration); - } while (remaining); + g_usleep(duration * G_USEC_PER_SEC); atomic_set(&test_stop, true); =20 for (i =3D 0; i < n_threads; i++) { diff --git a/tests/atomic_add-bench.c b/tests/atomic_add-bench.c index 2f6c72f63a..5666f6bbff 100644 --- a/tests/atomic_add-bench.c +++ b/tests/atomic_add-bench.c @@ -76,16 +76,14 @@ static void *thread_func(void *arg) =20 static void run_test(void) { - unsigned int remaining; unsigned int i; =20 while (atomic_read(&n_ready_threads) !=3D n_threads) { cpu_relax(); } + atomic_set(&test_start, true); - do { - remaining =3D sleep(duration); - } while (remaining); + g_usleep(duration * G_USEC_PER_SEC); atomic_set(&test_stop, true); =20 for (i =3D 0; i < n_threads; i++) { diff --git a/tests/qht-bench.c b/tests/qht-bench.c index ab4e708180..e3b512f26f 100644 --- a/tests/qht-bench.c +++ b/tests/qht-bench.c @@ -398,16 +398,14 @@ static void pr_stats(void) =20 static void run_test(void) { - unsigned int remaining; int i; =20 while (atomic_read(&n_ready_threads) !=3D n_rw_threads + n_rz_threads)= { cpu_relax(); } + atomic_set(&test_start, true); - do { - remaining =3D sleep(duration); - } while (remaining); + g_usleep(duration * G_USEC_PER_SEC); atomic_set(&test_stop, true); =20 for (i =3D 0; i < n_rw_threads; i++) { --=20 2.17.1