From nobody Mon Feb 9 16:02:22 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1547374071173133.91020133629468; Sun, 13 Jan 2019 02:07:51 -0800 (PST) Received: from localhost ([127.0.0.1]:60905 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gicg2-0006cZ-Bu for importer@patchew.org; Sun, 13 Jan 2019 05:07:34 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33748) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1giceJ-0005lv-Fg for qemu-devel@nongnu.org; Sun, 13 Jan 2019 05:05:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1giceI-0003Tn-Kb for qemu-devel@nongnu.org; Sun, 13 Jan 2019 05:05:47 -0500 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:38024) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1giceI-0003TL-Cy for qemu-devel@nongnu.org; Sun, 13 Jan 2019 05:05:46 -0500 Received: by mail-wr1-x442.google.com with SMTP id v13so19600566wrw.5 for ; Sun, 13 Jan 2019 02:05:46 -0800 (PST) Received: from bark.daynix ([141.226.163.173]) by smtp.gmail.com with ESMTPSA id j8sm62540340wmd.0.2019.01.13.02.05.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 13 Jan 2019 02:05:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=BeznIJQALwc/PDSYm8fp48HdMnQYcXjdvDBCvgmRVC4=; b=ibx8EV8+3AxkQMoeA9XteYJbJJMEkTnKA1RyupakyE6QTZ5NNwFPK5uwtTgrkA9RjX PgGuyHQaYQEL3003tFD6fDqfC36d82i461wUEMym3fKypeZHV/cyml/wKsuZcX0aIeUU CS5iSzA/gFkZE+Pyi/v8f4ZyXt6zVi2FAWE/bwKMTf7vKzYpMh/pIagBystt1KCNIiz6 ZqjENPk5eEliqbsjTzolhKnyz9P5rB7P+kUUpQNdMCtXYcjRBJVMzfjIj4H7HsLDcfPQ mFF0/jwVt3i//JpOvXECWsy1rQnBf7w4/hm2XmvnGEdTOUThwuuyktmseynGAVNZiAhC xXLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=BeznIJQALwc/PDSYm8fp48HdMnQYcXjdvDBCvgmRVC4=; b=kglsHlNMrMDsA6V/oFssMy6UJOaYt/yI2DSu/4uIywaRBQ3g4rhC62r5wnIexw6y7L 9/jmBwmcmIaoy7WkSUUbR/9ZldeFq/htJjO1bUdTANuDbGqpqdd1pqvAzgLblLjC+hOc igZ6PseT4a0wN54ZoknuAE3dj1I//sf9tCfipxfVVOjA5ESDEam+/FB5+KHJGeFInPaA P6Cupkv2pPfy6YDtpJXgslyZXaWSbTd7WPgpxMZZoss14V43YZUqLiwhC5IpmiEqI97m u/2TCtex4D29wpxskePQSf/e3iZ2KZLKVwS/Bo0ucc6e28xzrjWEvXGDaK0OAhypEVSr 66SA== X-Gm-Message-State: AJcUukclwCPYibqm7XwTcnBlbjwvZWRP1YprFPEfiw9TA77MHpNIvW57 1/KcJ6UtsEaVzVHLVdUkp2s3G8plmLg= X-Google-Smtp-Source: ALg8bN5Jeltt1ZseeW9ms6+8KIffXovt12SZgUTMvHYNs39Lg0dz3fTGlvwfqYv2evh9g6g2nFIm6w== X-Received: by 2002:adf:c888:: with SMTP id k8mr21331787wrh.6.1547373945086; Sun, 13 Jan 2019 02:05:45 -0800 (PST) From: Basil Salman To: qemu-devel@nongnu.org, Michael Roth Date: Sun, 13 Jan 2019 12:05:29 +0200 Message-Id: <20190113100531.1346024-3-basil@daynix.com> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190113100531.1346024-1-basil@daynix.com> References: <20190113100531.1346024-1-basil@daynix.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::442 Subject: [Qemu-devel] [PATCH v2 2/4] qga: fix send_response error handling X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yan Vugenfirer , Bishara AbuHattoum Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Sometimes qemu-ga fails to send a response to client due to memory allocati= on issues due to a large response message, this can be experienced while trying to read large number of bytes using QMP command guest-file-read. Added a check to send an error response to qemu-ga client in such cases. Signed-off-by: Basil Salman --- qga/main.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/qga/main.c b/qga/main.c index 87a0711c14..964275c40c 100644 --- a/qga/main.c +++ b/qga/main.c @@ -561,6 +561,8 @@ static void process_command(GAState *s, QDict *req) { QDict *rsp; int ret; + QDict *ersp; + Error *err =3D NULL; =20 g_assert(req); g_debug("processing command"); @@ -569,9 +571,20 @@ static void process_command(GAState *s, QDict *req) ret =3D send_response(s, rsp); if (ret < 0) { g_warning("error sending response: %s", strerror(-ret)); + goto err; } qobject_unref(rsp); } + return; +err: + error_setg(&err, "Insufficient system resources exist to " + "complete the requested service"); + ersp =3D qmp_error_response(err); + ret =3D send_response(s, ersp); + if (ret < 0) { + g_warning("error sending error response: %s", strerror(-ret)); + } + qobject_unref(ersp); } =20 /* handle requests/control events coming in over the channel */ --=20 2.17.2