From nobody Mon Feb 9 13:22:26 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1547199251642634.1229533982113; Fri, 11 Jan 2019 01:34:11 -0800 (PST) Received: from localhost ([127.0.0.1]:43896 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ghtCR-0001kZ-9i for importer@patchew.org; Fri, 11 Jan 2019 04:33:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34530) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ghtAB-0000fa-IB for qemu-devel@nongnu.org; Fri, 11 Jan 2019 04:31:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ghtA7-0003EK-5o for qemu-devel@nongnu.org; Fri, 11 Jan 2019 04:31:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40430) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ghtA3-000357-Jf for qemu-devel@nongnu.org; Fri, 11 Jan 2019 04:31:33 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 60EF3A7893; Fri, 11 Jan 2019 09:31:23 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-117-186.ams2.redhat.com [10.36.117.186]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2596E1714B; Fri, 11 Jan 2019 09:31:17 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 763B09AD9; Fri, 11 Jan 2019 10:31:16 +0100 (CET) From: Gerd Hoffmann To: qemu-devel@nongnu.org Date: Fri, 11 Jan 2019 10:31:15 +0100 Message-Id: <20190111093116.17188-5-kraxel@redhat.com> In-Reply-To: <20190111093116.17188-1-kraxel@redhat.com> References: <20190111093116.17188-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 11 Jan 2019 09:31:23 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 4/5] vfio/display: delay link up event X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alex Williamson , intel-gvt-dev@lists.freedesktop.org, Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Kick the display link up event with a 0.1 sec delay, so the guest has a chance to notice the link down first. Signed-off-by: Gerd Hoffmann --- include/hw/vfio/vfio-common.h | 1 + hw/vfio/display.c | 22 ++++++++++++++++++++-- 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-common.h index ff5c425048..9e29d5810e 100644 --- a/include/hw/vfio/vfio-common.h +++ b/include/hw/vfio/vfio-common.h @@ -151,6 +151,7 @@ typedef struct VFIODisplay { struct vfio_region_info *edid_info; struct vfio_region_gfx_edid *edid_regs; uint8_t *edid_blob; + QEMUTimer *edid_link_timer; struct { VFIORegion buffer; DisplaySurface *surface; diff --git a/hw/vfio/display.c b/hw/vfio/display.c index 3a10072823..a3a710b3ee 100644 --- a/hw/vfio/display.c +++ b/hw/vfio/display.c @@ -37,6 +37,19 @@ goto err; =20 =20 +static void vfio_display_edid_link_up(void *opaque) +{ + VFIOPCIDevice *vdev =3D opaque; + VFIODisplay *dpy =3D vdev->dpy; + + dpy->edid_regs->link_state =3D VFIO_DEVICE_GFX_LINK_STATE_UP; + pwrite_field(vdev->vbasedev.fd, dpy->edid_info, dpy->edid_regs, link_s= tate); + return; + +err: + fprintf(stderr, "%s: Oops, pwrite error\n", __func__); +} + static void vfio_display_edid_update(VFIOPCIDevice *vdev, bool enabled, in= t prefx, int prefy) { VFIODisplay *dpy =3D vdev->dpy; @@ -47,6 +60,7 @@ static void vfio_display_edid_update(VFIOPCIDevice *vdev,= bool enabled, int pref .prefy =3D prefy ?: vdev->display_yres, }; =20 + timer_del(dpy->edid_link_timer); dpy->edid_regs->link_state =3D VFIO_DEVICE_GFX_LINK_STATE_DOWN; pwrite_field(vdev->vbasedev.fd, dpy->edid_info, dpy->edid_regs, link_s= tate); =20 @@ -72,8 +86,7 @@ static void vfio_display_edid_update(VFIOPCIDevice *vdev,= bool enabled, int pref goto err; } =20 - dpy->edid_regs->link_state =3D VFIO_DEVICE_GFX_LINK_STATE_UP; - pwrite_field(vdev->vbasedev.fd, dpy->edid_info, dpy->edid_regs, link_s= tate); + timer_mod(dpy->edid_link_timer, qemu_clock_get_ms(QEMU_CLOCK_REALTIME)= + 100); return; =20 err: @@ -126,6 +139,9 @@ static void vfio_display_edid_init(VFIOPCIDevice *vdev) if (!vdev->display_yres) vdev->display_yres =3D dpy->edid_regs->max_yres; =20 + dpy->edid_link_timer =3D timer_new_ms(QEMU_CLOCK_REALTIME, + vfio_display_edid_link_up, vdev); + vfio_display_edid_update(vdev, true, 0, 0); return; =20 @@ -143,6 +159,8 @@ static void vfio_display_edid_exit(VFIODisplay *dpy) =20 g_free(dpy->edid_regs); g_free(dpy->edid_blob); + timer_del(dpy->edid_link_timer); + timer_free(dpy->edid_link_timer); } =20 static void vfio_display_update_cursor(VFIODMABuf *dmabuf, --=20 2.9.3