From nobody Fri Nov 7 05:35:25 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=163.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 154696078609611.122922032311521; Tue, 8 Jan 2019 07:19:46 -0800 (PST) Received: from localhost ([127.0.0.1]:46746 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggtAG-0004Eg-N5 for importer@patchew.org; Tue, 08 Jan 2019 10:19:36 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52183) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggt3c-0007PD-DH for qemu-devel@nongnu.org; Tue, 08 Jan 2019 10:12:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggt3V-0007EE-Ae for qemu-devel@nongnu.org; Tue, 08 Jan 2019 10:12:41 -0500 Received: from m12-14.163.com ([220.181.12.14]:40500) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggt3O-0006rZ-Pc; Tue, 08 Jan 2019 10:12:31 -0500 Received: from localhost.localdomain (unknown [115.206.0.47]) by smtp10 (Coremail) with SMTP id DsCowABHrhLUvTRciKQSAA--.1942S2; Tue, 08 Jan 2019 23:12:21 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=adKE4mND9jpqmA85AK 6jIOUDKbkB4tqlZgym7TLiUk4=; b=IRp4Bv88hf7mqUS/h9lQ9fQ9fmKCoBzPVE 5pzgV1EvrMKOjvR+ZG+6H1VEMSYsnP+FdcyU5fhhoecsrAgv6+8lwEYhLVZm3r2+ pB46Wc0mycaZpHyaEWN5I1oF/Tb2w2svE/Sb5dU40AhbOtQLpdAAsQ2GsgzEzt2x 27hK/fsWQ= From: Li Qiang To: walling@linux.ibm.com, cohuck@redhat.com, rth@twiddle.net, david@redhat.com, pasic@linux.ibm.com, borntraeger@de.ibm.com Date: Tue, 8 Jan 2019 07:11:14 -0800 Message-Id: <20190108151114.33140-1-liq3ea@163.com> X-Mailer: git-send-email 2.17.1 X-CM-TRANSID: DsCowABHrhLUvTRciKQSAA--.1942S2 X-Coremail-Antispam: 1Uf129KBjvJXoWruFW7KrW3WryUZryDJFyftFb_yoW8JrW5pa s3GFykKws0kr1jvanY9a47XFy8Za1DGrWDXr9xJ3yUt3y8urnFyFWUAay7ArsrJrWxZr15 Xr98trWDXasFkw7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07UwZ2fUUUUU= X-Originating-IP: [115.206.0.47] X-CM-SenderInfo: 5oltjvrd6rljoofrz/1tbiTxU2bVsGNgTY9QAAsD X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 220.181.12.14 Subject: [Qemu-devel] [PATCH v3] s390: avoid potential null dereference ins390_pcihost_unplug() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-s390x@nongnu.org, Li Qiang , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" When getting the 'pbdev', the if...else has no default branch. From Coverity, the 'pbdev' maybe null when the 'dev' is not the TYPE_PCI_BRIDGE/TYPE_PCI_DEVICE/TYPE_S390_PCI_DEVICE. This patch adds a default branch for device plug and unplug. Spotted by Coverity: CID 1398593 Signed-off-by: Li Qiang Reviewed-by: Collin Walling Reviewed-by: David Hildenbrand Reviewed-by: Halil Pasic --- Change since v2: use g_assert_not_reached for default branch hw/s390x/s390-pci-bus.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c index 15759b6514..a94700a78c 100644 --- a/hw/s390x/s390-pci-bus.c +++ b/hw/s390x/s390-pci-bus.c @@ -912,6 +912,8 @@ static void s390_pcihost_plug(HotplugHandler *hotplug_d= ev, DeviceState *dev, pbdev->fh =3D pbdev->idx; QTAILQ_INSERT_TAIL(&s->zpci_devs, pbdev, link); g_hash_table_insert(s->zpci_table, &pbdev->idx, pbdev); + } else { + g_assert_not_reached(); } } =20 @@ -956,6 +958,8 @@ static void s390_pcihost_unplug(HotplugHandler *hotplug= _dev, DeviceState *dev, } else if (object_dynamic_cast(OBJECT(dev), TYPE_S390_PCI_DEVICE)) { pbdev =3D S390_PCI_DEVICE(dev); pci_dev =3D pbdev->pdev; + } else { + g_assert_not_reached(); } =20 switch (pbdev->state) { --=20 2.17.1