From nobody Fri Nov 7 05:57:57 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1546948357654680.7164245065419; Tue, 8 Jan 2019 03:52:37 -0800 (PST) Received: from localhost ([127.0.0.1]:49126 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggpvw-0002LB-NF for importer@patchew.org; Tue, 08 Jan 2019 06:52:36 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37927) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggprY-0007au-T5 for qemu-devel@nongnu.org; Tue, 08 Jan 2019 06:48:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggprN-0003RN-UA for qemu-devel@nongnu.org; Tue, 08 Jan 2019 06:48:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48882) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ggprN-0003Pc-Mi for qemu-devel@nongnu.org; Tue, 08 Jan 2019 06:47:53 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DB573DC910; Tue, 8 Jan 2019 11:47:52 +0000 (UTC) Received: from xz-x1.nay.redhat.com (dhcp-14-116.nay.redhat.com [10.66.14.116]) by smtp.corp.redhat.com (Postfix) with ESMTP id 95D6A5C21C; Tue, 8 Jan 2019 11:47:36 +0000 (UTC) From: Peter Xu To: qemu-devel@nongnu.org Date: Tue, 8 Jan 2019 19:47:16 +0800 Message-Id: <20190108114720.21760-2-peterx@redhat.com> In-Reply-To: <20190108114720.21760-1-peterx@redhat.com> References: <20190108114720.21760-1-peterx@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 08 Jan 2019 11:47:52 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 1/5] intel_iommu: fix operator in vtd_switch_address_space X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S . Tsirkin" , Jason Wang , peterx@redhat.com, Eric Auger , Alex Williamson , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" When calculating use_iommu, we wanted to first detect whether DMAR is enabled, then check whether PT is enabled if DMAR is enabled. However in the current code we used "&" rather than "&&" so the ordering requirement is lost (instead it'll be an "AND" operation). This could introduce errors dumped in QEMU console when rebooting a guest with both assigned device and vIOMMU, like: qemu-system-x86_64: vtd_dev_to_context_entry: invalid root entry: rsvd=3D0xf000ff53f000e2c3, val=3D0xf000ff53f000ff53 (reserved nonzero) Signed-off-by: Peter Xu Acked-by: Jason Wang --- hw/i386/intel_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 8b72735650..6d5cc1d039 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -1153,7 +1153,7 @@ static bool vtd_switch_address_space(VTDAddressSpace = *as) =20 assert(as); =20 - use_iommu =3D as->iommu_state->dmar_enabled & !vtd_dev_pt_enabled(as); + use_iommu =3D as->iommu_state->dmar_enabled && !vtd_dev_pt_enabled(as); =20 trace_vtd_switch_address_space(pci_bus_num(as->bus), VTD_PCI_SLOT(as->devfn), --=20 2.17.1