From nobody Fri Nov 7 04:17:15 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1546943093441326.1645400651345; Tue, 8 Jan 2019 02:24:53 -0800 (PST) Received: from localhost ([127.0.0.1]:36674 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggoZ1-0004XD-35 for importer@patchew.org; Tue, 08 Jan 2019 05:24:51 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41317) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggoXk-0003oN-40 for qemu-devel@nongnu.org; Tue, 08 Jan 2019 05:23:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggoXg-0004oj-EN for qemu-devel@nongnu.org; Tue, 08 Jan 2019 05:23:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44912) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ggoXg-0004Hk-1A for qemu-devel@nongnu.org; Tue, 08 Jan 2019 05:23:28 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 24597C04AC54; Tue, 8 Jan 2019 10:23:10 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-98.ams2.redhat.com [10.36.116.98]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6F24460A9D; Tue, 8 Jan 2019 10:23:02 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 6AFE19F12; Tue, 8 Jan 2019 11:23:01 +0100 (CET) From: Gerd Hoffmann To: qemu-devel@nongnu.org Date: Tue, 8 Jan 2019 11:23:01 +0100 Message-Id: <20190108102301.1957-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 08 Jan 2019 10:23:10 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] i2c-ddc: fix oob read X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: public@hansmi.ch, Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Suggested-by: Michael Hanselmann Signed-off-by: Gerd Hoffmann Reviewed-by: Michael Hanselmann Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i2c/i2c-ddc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i2c/i2c-ddc.c b/hw/i2c/i2c-ddc.c index be34fe072c..0a0367ff38 100644 --- a/hw/i2c/i2c-ddc.c +++ b/hw/i2c/i2c-ddc.c @@ -56,7 +56,7 @@ static int i2c_ddc_rx(I2CSlave *i2c) I2CDDCState *s =3D I2CDDC(i2c); =20 int value; - value =3D s->edid_blob[s->reg]; + value =3D s->edid_blob[s->reg % sizeof(s->edid_blob)]; s->reg++; return value; } --=20 2.9.3