From nobody Tue May 7 14:34:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1546815155964622.9639587217822; Sun, 6 Jan 2019 14:52:35 -0800 (PST) Received: from localhost ([127.0.0.1]:50568 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggHHR-00054W-IV for importer@patchew.org; Sun, 06 Jan 2019 17:52:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53551) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggHFo-0003mR-MP for qemu-devel@nongnu.org; Sun, 06 Jan 2019 17:50:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggHFn-0004gQ-Pg for qemu-devel@nongnu.org; Sun, 06 Jan 2019 17:50:48 -0500 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]:40558) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ggHFn-0004g4-KR for qemu-devel@nongnu.org; Sun, 06 Jan 2019 17:50:47 -0500 Received: by mail-pl1-x644.google.com with SMTP id u18so19931181plq.7 for ; Sun, 06 Jan 2019 14:50:47 -0800 (PST) Received: from cloudburst.lan (2001-44b8-2176-c800-8cc6-2630-7d99-5ef1.static.ipv6.internode.on.net. [2001:44b8:2176:c800:8cc6:2630:7d99:5ef1]) by smtp.gmail.com with ESMTPSA id n78sm45905768pfk.19.2019.01.06.14.50.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 06 Jan 2019 14:50:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=kn8TChn9a+pm0RN7mZwckgPE1JRDgQHcCQVRvVrkJ7Y=; b=bHLGqdcHZdEZOXs6S+jX0XGhwgSMIKO1PeZi6eVSo+9f3gVrKfuz3O3gPa6rooL9x1 xhMJDocZEpeKSf6f5ozxI2getqhOqxfC9nTd+Ucv18RfePA/cx9QHudDK96GYLnV8NkL x2mi3MhIhrgbgb7mF3kcx542fpjbO5y8WBUl0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=kn8TChn9a+pm0RN7mZwckgPE1JRDgQHcCQVRvVrkJ7Y=; b=nefR5CTJWroWq3fMsiagP5z7QJG2+UhR5Il3Mu3STHfZ/1xZSBKl4qripuNGauV9Lo eZukO5IZboNtRu0gXx002Oo/WCft/iuPfoQcmAv5Qga0vOew2oo+tTcUxs/rpaRIJpTV YJKxVSGlFrNDmUJhBYZPJbsO/0SpnuJ8HGhhxo6HpWtzEiRTMLtGS8VMyg/UoO4T/Qbz CfxgeW73l/1O6HqEMawN3EPPcDP50kGzAs4kz3F2ZqUZbKSCBKBMTQwx1+CAEYUaNxjR iqRy0WktL3qOiEVtcjf0R1zbcv5MgOOfliBmHRHd/9plL7KHS04FxVrBWrbQ+POoGpOs qAxQ== X-Gm-Message-State: AJcUukdBgYYl1nQRkFnBKmE5bQatljaRgatKM/7Pz6hNEX9BOTlC8TKS v2AVYQj5sPo+7xQSjuhMtV98eARO6UmJFw== X-Google-Smtp-Source: ALg8bN6Q+lIXd6alV5+LyYbTz4GNChUZwPLkphmWrG5LEt2cSiTFFX4Zi14TvY61jWpEdar1shWojA== X-Received: by 2002:a17:902:b090:: with SMTP id p16mr59152015plr.190.1546815046394; Sun, 06 Jan 2019 14:50:46 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 7 Jan 2019 08:50:33 +1000 Message-Id: <20190106225035.5671-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190106225035.5671-1-richard.henderson@linaro.org> References: <20190106225035.5671-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::644 Subject: [Qemu-devel] [PATCH 1/3] target/arm: Rely on optimization within tcg_gen_gvec_or X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Since we're now handling a =3D=3D b generically, we no longer need to do it by hand within target/arm/. Reviewed-by: David Gibson Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 6 +----- target/arm/translate-sve.c | 6 +----- target/arm/translate.c | 12 +++--------- 3 files changed, 5 insertions(+), 19 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index e1da1e4d6f..2d6f8c1b4f 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -10152,11 +10152,7 @@ static void disas_simd_3same_logic(DisasContext *s= , uint32_t insn) gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_andc, 0); return; case 2: /* ORR */ - if (rn =3D=3D rm) { /* MOV */ - gen_gvec_fn2(s, is_q, rd, rn, tcg_gen_gvec_mov, 0); - } else { - gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_or, 0); - } + gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_or, 0); return; case 3: /* ORN */ gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_orc, 0); diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c index b15b615ceb..3a2eb51566 100644 --- a/target/arm/translate-sve.c +++ b/target/arm/translate-sve.c @@ -280,11 +280,7 @@ static bool trans_AND_zzz(DisasContext *s, arg_rrr_esz= *a) =20 static bool trans_ORR_zzz(DisasContext *s, arg_rrr_esz *a) { - if (a->rn =3D=3D a->rm) { /* MOV */ - return do_mov_z(s, a->rd, a->rn); - } else { - return do_vector3_z(s, tcg_gen_gvec_or, 0, a->rd, a->rn, a->rm); - } + return do_vector3_z(s, tcg_gen_gvec_or, 0, a->rd, a->rn, a->rm); } =20 static bool trans_EOR_zzz(DisasContext *s, arg_rrr_esz *a) diff --git a/target/arm/translate.c b/target/arm/translate.c index 7c4675ffd8..33b1860148 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -6294,15 +6294,9 @@ static int disas_neon_data_insn(DisasContext *s, uin= t32_t insn) tcg_gen_gvec_andc(0, rd_ofs, rn_ofs, rm_ofs, vec_size, vec_size); break; - case 2: - if (rn =3D=3D rm) { - /* VMOV */ - tcg_gen_gvec_mov(0, rd_ofs, rn_ofs, vec_size, vec_size= ); - } else { - /* VORR */ - tcg_gen_gvec_or(0, rd_ofs, rn_ofs, rm_ofs, - vec_size, vec_size); - } + case 2: /* VORR */ + tcg_gen_gvec_or(0, rd_ofs, rn_ofs, rm_ofs, + vec_size, vec_size); break; case 3: /* VORN */ tcg_gen_gvec_orc(0, rd_ofs, rn_ofs, rm_ofs, --=20 2.17.2 From nobody Tue May 7 14:34:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=listsout.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from listsout.gnu.org (listsout.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1546815296846259.80194821124087; Sun, 6 Jan 2019 14:54:56 -0800 (PST) Received: from localhost ([127.0.0.1]:51201 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggHJn-0007es-EB for importer@patchew.org; Sun, 06 Jan 2019 17:54:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53574) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggHFr-0003pr-9S for qemu-devel@nongnu.org; Sun, 06 Jan 2019 17:50:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggHFq-0004h8-Fk for qemu-devel@nongnu.org; Sun, 06 Jan 2019 17:50:51 -0500 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]:43783) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ggHFq-0004gs-Ag for qemu-devel@nongnu.org; Sun, 06 Jan 2019 17:50:50 -0500 Received: by mail-pl1-x643.google.com with SMTP id gn14so19945372plb.10 for ; Sun, 06 Jan 2019 14:50:50 -0800 (PST) Received: from cloudburst.lan (2001-44b8-2176-c800-8cc6-2630-7d99-5ef1.static.ipv6.internode.on.net. [2001:44b8:2176:c800:8cc6:2630:7d99:5ef1]) by smtp.gmail.com with ESMTPSA id n78sm45905768pfk.19.2019.01.06.14.50.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 06 Jan 2019 14:50:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=FerA1jdUPmyzDQdllgAlLCmDGQMUpOXaXKd/jiLP8aM=; b=CgDnNjU3z/4026ZoL+JSXZx91soiI0VkY8LF2EkblXEjDAPh2sWt9qNB82bIsuQK6M uThgi2KY3zWP9+1hU1NkEH+FtoZUWG/lKAkhAQXVHpitAKuqvTsj4JJO14uTrjTnpWOU RnSQRf+uEdEAd58JH8exzmAUtAaYjvOFk02Zo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=FerA1jdUPmyzDQdllgAlLCmDGQMUpOXaXKd/jiLP8aM=; b=tYa414SqG+ZKsD9C/sLmQlOHIv0Bl9OLfTCjAV2RK2ddW57K30oCQvD3lkE8CyxIEV kQg/L3OMXivIUPmhgLUl7SdbgMIp5/7WdVa+e3XW4o2Z7nYrYdxZEX1ae2dNMGpsQwRB IyS6chXPwmGDevjhGaAjZwA6siINudWDkLMqyA7SNapKM0xLBuYkbp/N0dxZh4NDsrT1 yaGmTuEIjWXktgdxlSU1wVFmxjjzdPJYo6pSmDNCzWHxJaYp58x/B/S1HiHhBr0XcWve utlSFx8GNSADgnzMasfWqpJ5++JAjzgK+zMC2yhIdPrmR1iITXNN6gamoZ2Yb5BlmKd9 jB0w== X-Gm-Message-State: AJcUukdBPb+QDxXqqSCX3I68Y0xyjgdR2zodS9Oy9t4TzZqLObJBStCN TiiQJqAw2p4Fb0etLncth0/gCwzvtvH/aQ== X-Google-Smtp-Source: ALg8bN5smIVy69bUysUeUa8+BOc9Ktqu5T3IBhXSIy33EfROUK/dRBkfcY4XYMHUGXq1WGzcf9KEPA== X-Received: by 2002:a17:902:5a4d:: with SMTP id f13mr60842695plm.49.1546815049177; Sun, 06 Jan 2019 14:50:49 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 7 Jan 2019 08:50:34 +1000 Message-Id: <20190106225035.5671-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190106225035.5671-1-richard.henderson@linaro.org> References: <20190106225035.5671-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::643 Subject: [Qemu-devel] [PATCH 2/3] target/arm: Use vector minmax expanders for aarch64 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell --- target/arm/translate-a64.c | 35 ++++++++++++++--------------------- 1 file changed, 14 insertions(+), 21 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 2d6f8c1b4f..bef21ada71 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -10452,6 +10452,20 @@ static void disas_simd_3same_int(DisasContext *s, = uint32_t insn) } =20 switch (opcode) { + case 0x0c: /* SMAX, UMAX */ + if (u) { + gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_umax, size); + } else { + gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_smax, size); + } + return; + case 0x0d: /* SMIN, UMIN */ + if (u) { + gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_umin, size); + } else { + gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_smin, size); + } + return; case 0x10: /* ADD, SUB */ if (u) { gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_sub, size); @@ -10613,27 +10627,6 @@ static void disas_simd_3same_int(DisasContext *s, = uint32_t insn) genenvfn =3D fns[size][u]; break; } - case 0xc: /* SMAX, UMAX */ - { - static NeonGenTwoOpFn * const fns[3][2] =3D { - { gen_helper_neon_max_s8, gen_helper_neon_max_u8 }, - { gen_helper_neon_max_s16, gen_helper_neon_max_u16 }, - { tcg_gen_smax_i32, tcg_gen_umax_i32 }, - }; - genfn =3D fns[size][u]; - break; - } - - case 0xd: /* SMIN, UMIN */ - { - static NeonGenTwoOpFn * const fns[3][2] =3D { - { gen_helper_neon_min_s8, gen_helper_neon_min_u8 }, - { gen_helper_neon_min_s16, gen_helper_neon_min_u16 }, - { tcg_gen_smin_i32, tcg_gen_umin_i32 }, - }; - genfn =3D fns[size][u]; - break; - } case 0xe: /* SABD, UABD */ case 0xf: /* SABA, UABA */ { --=20 2.17.2 From nobody Tue May 7 14:34:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1546815296727356.01618326829043; Sun, 6 Jan 2019 14:54:56 -0800 (PST) Received: from localhost ([127.0.0.1]:51199 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggHJm-0007eo-W5 for importer@patchew.org; Sun, 06 Jan 2019 17:54:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53612) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggHFv-0003v0-2y for qemu-devel@nongnu.org; Sun, 06 Jan 2019 17:50:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggHFt-0004lY-MB for qemu-devel@nongnu.org; Sun, 06 Jan 2019 17:50:54 -0500 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]:41691) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ggHFt-0004ja-EK for qemu-devel@nongnu.org; Sun, 06 Jan 2019 17:50:53 -0500 Received: by mail-pl1-x641.google.com with SMTP id u6so19934294plm.8 for ; Sun, 06 Jan 2019 14:50:53 -0800 (PST) Received: from cloudburst.lan (2001-44b8-2176-c800-8cc6-2630-7d99-5ef1.static.ipv6.internode.on.net. [2001:44b8:2176:c800:8cc6:2630:7d99:5ef1]) by smtp.gmail.com with ESMTPSA id n78sm45905768pfk.19.2019.01.06.14.50.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 06 Jan 2019 14:50:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=kSo0oKSo1CsoY2QHLe3rTxnPQOT4r7h09gkl4JXYPGw=; b=Lfh/sl+/68m//Y2YF1vDNRLPg+ceFxNSlF9404jjh0mTezBeeNR7Sh5ONIHrVeXYqf Ft0yNymMn585Df6cedqBrQaBaJphw70wDDP7BtHk0/IIXHIGcw5v9uvUuXtbnqxffOig RlGZgQIyW09eIT5mhQP3eRiC0TjMf+u3g/RrY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=kSo0oKSo1CsoY2QHLe3rTxnPQOT4r7h09gkl4JXYPGw=; b=Cn8e7QxBmTHUO26arXGeNzv8npgLYAWWFZrwLSofiCkmVZV9DKu/fN7hh8QXuYFvGK ndy+I/RN+eqMh2hzbNbOib/LCGRbRJHJuTxv8Fa89LDd9WbzujG0EgmQWcWsppRXLtum l3pYDqe6n38tWi9DKqSiQIxb0574e0lS1kzXSw5ttpChznedhQuPcLhVBivjkJB+7InR e9aRajzbFEdXfX17dxAVhXDJx8AWBcK9Jpk2QgmZ4IM7wHSK5FKtIvk9CHMat1AKp0Y5 uzWUWsKXqv3H2oj4wmm+AGV9aruj/LablAR7Fo/Z1V2rkkkvDAbtCMK1MPb1FjceDuE+ p2ZQ== X-Gm-Message-State: AJcUukeHo3JjvaR4ZX7wpTcAzvaAbzfn4E4q2Uvz28oYKGchLp+KCpkT W/SJRYTLIkkkmRiqFoHZjzO5udxCPIy6xA== X-Google-Smtp-Source: ALg8bN5dFIA8NXgDIB1lVE+VToKQHdUP/EiAF4CwOOXthgifgq1j8UWT2Gc6eCMdeEZh8rwvA9MZcg== X-Received: by 2002:a17:902:1008:: with SMTP id b8mr57215902pla.252.1546815052118; Sun, 06 Jan 2019 14:50:52 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 7 Jan 2019 08:50:35 +1000 Message-Id: <20190106225035.5671-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190106225035.5671-1-richard.henderson@linaro.org> References: <20190106225035.5671-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::641 Subject: [Qemu-devel] [PATCH 3/3] target/arm: Use vector minmax expanders for aarch32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell --- target/arm/translate.c | 25 +++++++++++++++++++------ 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 33b1860148..f3f172f384 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -6368,6 +6368,25 @@ static int disas_neon_data_insn(DisasContext *s, uin= t32_t insn) tcg_gen_gvec_cmp(u ? TCG_COND_GEU : TCG_COND_GE, size, rd_ofs, rn_ofs, rm_ofs, vec_size, vec_size); return 0; + + case NEON_3R_VMAX: + if (u) { + tcg_gen_gvec_umax(size, rd_ofs, rn_ofs, rm_ofs, + vec_size, vec_size); + } else { + tcg_gen_gvec_smax(size, rd_ofs, rn_ofs, rm_ofs, + vec_size, vec_size); + } + return 0; + case NEON_3R_VMIN: + if (u) { + tcg_gen_gvec_umin(size, rd_ofs, rn_ofs, rm_ofs, + vec_size, vec_size); + } else { + tcg_gen_gvec_smin(size, rd_ofs, rn_ofs, rm_ofs, + vec_size, vec_size); + } + return 0; } =20 if (size =3D=3D 3) { @@ -6533,12 +6552,6 @@ static int disas_neon_data_insn(DisasContext *s, uin= t32_t insn) case NEON_3R_VQRSHL: GEN_NEON_INTEGER_OP_ENV(qrshl); break; - case NEON_3R_VMAX: - GEN_NEON_INTEGER_OP(max); - break; - case NEON_3R_VMIN: - GEN_NEON_INTEGER_OP(min); - break; case NEON_3R_VABD: GEN_NEON_INTEGER_OP(abd); break; --=20 2.17.2