[Qemu-devel] [PATCH v2 0/3] cutils: Cleanup, improve documentation

Philippe Mathieu-Daudé posted 3 patches 5 years, 2 months ago
Test asan passed
Test checkpatch passed
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
Test docker-clang@ubuntu failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190104181208.7809-1-philmd@redhat.com
There is a newer version of this series
hw/core/bus.c                |   2 +-
hw/core/qdev-properties.c    |   1 +
hw/s390x/s390-virtio-ccw.c   |   1 +
hw/scsi/scsi-generic.c       |   2 +-
include/qemu-common.h        |  17 ---
include/qemu/cutils.h        | 262 +++++++++++++++++++++++++++++++++++
qapi/qapi-util.c             |   2 +-
qapi/string-output-visitor.c |   2 +-
qobject/json-parser.c        |   1 -
target/ppc/monitor.c         |   1 +
ui/keymaps.c                 |   1 +
util/cutils.c                | 191 -------------------------
util/id.c                    |   2 +-
util/readline.c              |   1 -
14 files changed, 271 insertions(+), 215 deletions(-)
[Qemu-devel] [PATCH v2 0/3] cutils: Cleanup, improve documentation
Posted by Philippe Mathieu-Daudé 5 years, 2 months ago
This series is a fairly trivial cleanup of "cutils.h"
(size_to_str() and ctype macros moved into it), and
some documentation improvements.

Since v1:
- Fixed checkpatch errors (patchew)
- Added Stefano R-b

There are still checkpatch warnings (due to 8c06fbdf36b) for using the
Doxygen '/**' comment opening:

    WARNING: Block comments use a leading /* on a separate line
    #42: FILE: include/qemu/cutils.h:160:
    +/**

v1: https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg05927.html

Regards,

Phil.

Philippe Mathieu-Daudé (3):
  util/cutils: Move size_to_str() from "qemu-common.h" to "cutils.h"
  util/cutils: Move ctype macros to "cutils.h"
  util/cutils: Move function documentations to the header

 hw/core/bus.c                |   2 +-
 hw/core/qdev-properties.c    |   1 +
 hw/s390x/s390-virtio-ccw.c   |   1 +
 hw/scsi/scsi-generic.c       |   2 +-
 include/qemu-common.h        |  17 ---
 include/qemu/cutils.h        | 262 +++++++++++++++++++++++++++++++++++
 qapi/qapi-util.c             |   2 +-
 qapi/string-output-visitor.c |   2 +-
 qobject/json-parser.c        |   1 -
 target/ppc/monitor.c         |   1 +
 ui/keymaps.c                 |   1 +
 util/cutils.c                | 191 -------------------------
 util/id.c                    |   2 +-
 util/readline.c              |   1 -
 14 files changed, 271 insertions(+), 215 deletions(-)

-- 
2.17.2