From nobody Sat Apr 27 11:58:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1546613505271514.6095878988502; Fri, 4 Jan 2019 06:51:45 -0800 (PST) Received: from localhost ([127.0.0.1]:36020 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gfQos-0002GG-NX for importer@patchew.org; Fri, 04 Jan 2019 09:51:30 -0500 Received: from eggs.gnu.org ([208.118.235.92]:46486) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gfQnp-0001gg-Vt for qemu-devel@nongnu.org; Fri, 04 Jan 2019 09:50:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gfQnm-0007FD-Nd for qemu-devel@nongnu.org; Fri, 04 Jan 2019 09:50:25 -0500 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:39498) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gfQnm-0007B5-DC for qemu-devel@nongnu.org; Fri, 04 Jan 2019 09:50:22 -0500 Received: by mail-wr1-x444.google.com with SMTP id t27so36813768wra.6 for ; Fri, 04 Jan 2019 06:50:22 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id a62sm926540wmf.47.2019.01.04.06.50.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 04 Jan 2019 06:50:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=8r96HUAxK9l0LtrrF1BLqhlMVgiHZXEjOYg+Ln/WEeQ=; b=AQhcd6FARyCMS4qTxW3rvftGEuXtpQyMS8fYLP15jc9PJ/FXurypEoh7Km35Vx73YA h8w96Xa3WilNRdiUdAYbeCWl+0CHAZvA2MmNdncHqu1lhn3ksB54uBkruyh+WFT34P4b LGyN+coEQmXBFBApPEOPGZYeheBeOq9G4KEII= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=8r96HUAxK9l0LtrrF1BLqhlMVgiHZXEjOYg+Ln/WEeQ=; b=AneeChf6vYvwJtceWNfmsnM3pdN2pAf7dWbjpb6JGit/pdNS2b+SP+/TpGNBZ9GgPm 0KKgaWxnfzlSFhNM6Slof4Sv6fY9kGTrXuLyI7fjZWqx53mss8kcKxuqziJqOA+TI560 8Yz7SPPen7am+uGDmnj4Bj0k0OL07XXS4gmocGA75e2Q27xggQ/J4VTTFQtkviQMrCZr +PGmTzonOV6sGSyUkkykX0wjbH82wO0fQ6suxONy0qpVYrVwX1cMThueFp/aVILmY8rv ScOL9NGAhSt41GRYJYg0l2K+7NZXoxYiUH/hWLFAVgY3Z4JoWRv+qjqUnDWejo4bUuJY eubQ== X-Gm-Message-State: AJcUukd2JBF9xqlwr3cJY9iDUR8ZcaxWOSrO0KpJyDj1r4ijzktP4Mve trJICPHhc+ijDPA6frtzTMMxsg== X-Google-Smtp-Source: ALg8bN4tx5fNZMVqBegLq6rVS0oH6TwZ4Y5d9qcLCyNYJ0CEvsSWmKB8+eojI6blfoCtzHcmuElQ9Q== X-Received: by 2002:adf:d112:: with SMTP id a18mr46669041wri.17.1546613421297; Fri, 04 Jan 2019 06:50:21 -0800 (PST) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Date: Fri, 4 Jan 2019 14:50:18 +0000 Message-Id: <20190104145018.16950-1-peter.maydell@linaro.org> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 Subject: [Qemu-devel] [PATCH] tests/hexloader-test: Don't pass -nographic to the QEMU under test X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Su Hang , patches@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The hexloader test invokes QEMU with the -nographic argument. This is unnecessary, because the qtest_initf() function will pass it -display none, which suffices to disable the graphical window. It also means that the QEMU process will make the stdin/stdout O_NONBLOCK. Since O_NONBLOCK is not per-file descriptor but per "file description", this non-blocking behaviour is then shared with any other process that's using the stdin/stdout of the 'make check' run, including make itself. This can result in make falling over with "make: write error: stdout" because it got an unexpected EINTR trying to write output messages to the terminal. This is particularly noticable if running 'make check' in a loop with while make check; do true; done (It does not affect single make check runs so much because the shell will remove the O_NONBLOCK status before it reads the terminal for interactive input.) Remove the unwanted -nographic argument. Signed-off-by: Peter Maydell Reviewed-by: Thomas Huth --- This seems to be sufficient to resolve my "make falls over" issues with the current test harness and a build done for arm targets; I haven't checked whether other test cases which are specific to other target architectures might have similar accidental O_NONBLOCK behaviour. tests/hexloader-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/hexloader-test.c b/tests/hexloader-test.c index 834ed52c22b..8b7aa2d72d0 100644 --- a/tests/hexloader-test.c +++ b/tests/hexloader-test.c @@ -23,7 +23,7 @@ static void hex_loader_test(void) const unsigned int base_addr =3D 0x00010000; =20 QTestState *s =3D qtest_initf( - "-M vexpress-a9 -nographic -device loader,file=3Dtests/data/hex-lo= ader/test.hex"); + "-M vexpress-a9 -device loader,file=3Dtests/data/hex-loader/test.h= ex"); =20 for (i =3D 0; i < 256; ++i) { uint8_t val =3D qtest_readb(s, base_addr + i); --=20 2.19.2