From nobody Mon Apr 29 10:45:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=listsout.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=163.com Return-Path: Received: from listsout.gnu.org (listsout.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1546524445141834.9036119657776; Thu, 3 Jan 2019 06:07:25 -0800 (PST) Received: from localhost ([127.0.0.1]:54085 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gf3ed-000246-RV for importer@patchew.org; Thu, 03 Jan 2019 09:07:23 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57612) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gf3bd-0007u8-Ra for qemu-devel@nongnu.org; Thu, 03 Jan 2019 09:04:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gf3bd-0005m8-3F for qemu-devel@nongnu.org; Thu, 03 Jan 2019 09:04:17 -0500 Received: from m12-17.163.com ([220.181.12.17]:53753) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gf3bY-0005kT-93; Thu, 03 Jan 2019 09:04:12 -0500 Received: from localhost.localdomain (unknown [183.134.169.2]) by smtp13 (Coremail) with SMTP id EcCowABXC2tJFi5c_PUECA--.5489S2; Thu, 03 Jan 2019 22:03:54 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=BTHAXQMDQsEy8M3P0+ 1fxu+weZ1OvNmvcl7/Kc2UKE8=; b=OYvGQPv/PcZNveI46SP8w524i+391M8ZTn MGniGhhKpFqRdA7LTLd11i/CiWe4qmBp6ocOnhkDouxZM+P1YFDKwBzgp2ZJ+L5x /mPWCFJQhR5x22cOJdu1YscUhknr3f/mJSDIrX4ZD0POEnCWuWe4JksUg0CnFRF9 eCQEy3NyQ= From: Li Qiang To: walling@linux.ibm.com, rth@twiddle.net, david@redhat.com, cohuck@redhat.com, pasic@linux.ibm.com, borntraeger@de.ibm.com Date: Thu, 3 Jan 2019 06:02:46 -0800 Message-Id: <20190103140246.50791-1-liq3ea@163.com> X-Mailer: git-send-email 2.17.1 X-CM-TRANSID: EcCowABXC2tJFi5c_PUECA--.5489S2 X-Coremail-Antispam: 1Uf129KBjvdXoWruFWxXF4rWF4Dur4kGw43GFg_yoWfuFX_Za 48Ca1kK3Z7WrnIk39YvF1rZrnYyw1kJw4rXa4agr1vvr1rJa4DuFy7uw1xKr1UWF43Xry5 W34UGw4ak3ZrKjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUbpVbJUUUUU== X-Originating-IP: [183.134.169.2] X-CM-SenderInfo: 5oltjvrd6rljoofrz/xtbBawoxbVettg8OWQAAsp X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 220.181.12.17 Subject: [Qemu-devel] [PATCH] s390: avoid potential null dereference in s390_pcihost_unplug() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-s390x@nongnu.org, Li Qiang , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" When getting the 'pbdev', the if...else has no default branch. From Coverity, the 'pbdev' maybe null when the 'dev' is not the TYPE_PCI_BRIDGE/TYPE_PCI_DEVICE/TYPE_S390_PCI_DEVICE. Spotted by Coverity: CID 1398593 Signed-off-by: Li Qiang --- hw/s390x/s390-pci-bus.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c index 15759b6514..b3122268a3 100644 --- a/hw/s390x/s390-pci-bus.c +++ b/hw/s390x/s390-pci-bus.c @@ -956,6 +956,10 @@ static void s390_pcihost_unplug(HotplugHandler *hotplu= g_dev, DeviceState *dev, } else if (object_dynamic_cast(OBJECT(dev), TYPE_S390_PCI_DEVICE)) { pbdev =3D S390_PCI_DEVICE(dev); pci_dev =3D pbdev->pdev; + } else { + error_setg(errp, "s390: device unplug for not supported device" + " type: %s", object_get_typename(OBJECT(dev))); + return; } =20 switch (pbdev->state) { --=20 2.17.1