From nobody Sat May 4 04:48:40 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=163.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 15465224488741009.5381619323063; Thu, 3 Jan 2019 05:34:08 -0800 (PST) Received: from localhost ([127.0.0.1]:53797 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gf38R-0006Pp-O5 for importer@patchew.org; Thu, 03 Jan 2019 08:34:07 -0500 Received: from eggs.gnu.org ([208.118.235.92]:51394) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gf36y-0005Wz-IU for qemu-devel@nongnu.org; Thu, 03 Jan 2019 08:32:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gf36t-0000Hr-Io for qemu-devel@nongnu.org; Thu, 03 Jan 2019 08:32:36 -0500 Received: from m12-16.163.com ([220.181.12.16]:46269) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gf36t-0000HZ-0E for qemu-devel@nongnu.org; Thu, 03 Jan 2019 08:32:31 -0500 Received: from localhost.localdomain (unknown [183.134.169.2]) by smtp12 (Coremail) with SMTP id EMCowAAn6jfjDi5cERErBA--.149S2; Thu, 03 Jan 2019 21:32:24 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=3cCy4L8ZM/JxTYM4HW VnTqFdNN621O1rJYanb44xVLE=; b=JYKW1MU/wBLnzXL0gztDGE7hwJlz/Kn5dz +MLxlXfOC3v3noArWfRMAsQ0f7vNqWBLPltTRMWZJWRsoWgefpXwjZjKjNbKpLnh 2Wah7AxZ07qKY5c8jDVm8D2f5S8yeZOdN1ctLLk+eN2IS9DNhSOJVRhfz/+8IzK8 E57IW5BGM= From: Li Qiang To: kraxel@redhat.com Date: Thu, 3 Jan 2019 05:31:13 -0800 Message-Id: <20190103133113.49599-1-liq3ea@163.com> X-Mailer: git-send-email 2.17.1 X-CM-TRANSID: EMCowAAn6jfjDi5cERErBA--.149S2 X-Coremail-Antispam: 1Uf129KBjvdXoWruw4fGw4fZF45GF1rur1DGFg_yoWxKFb_CF ZrCF18Xr1UJF1q9347Zwn2qr1UJw15Jr45X3sIqFsYyr47t3WDXF4jyrWUXFyUXrWxJF98 Cw1UA3WUuF1UXjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU1q-e3UUUUU== X-Originating-IP: [183.134.169.2] X-CM-SenderInfo: 5oltjvrd6rljoofrz/xtbBoQAxbVQHDGnwDQAAs2 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 220.181.12.16 Subject: [Qemu-devel] [PATCH] usb: dev-mtp: close fd in usb_mtp_object_readdir() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Li Qiang , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Spotted by Coverity: CID 1397070 Signed-off-by: Li Qiang Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/usb/dev-mtp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index b19b576278..666bafd9e8 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -666,6 +666,7 @@ static void usb_mtp_object_readdir(MTPState *s, MTPObje= ct *o) } dir =3D fdopendir(fd); if (!dir) { + close(fd); return; } #ifdef CONFIG_INOTIFY1 @@ -682,6 +683,7 @@ static void usb_mtp_object_readdir(MTPState *s, MTPObje= ct *o) usb_mtp_add_child(s, o, entry->d_name); } closedir(dir); + close(fd); } =20 /* -----------------------------------------------------------------------= */ --=20 2.17.1