From nobody Sat Oct 4 22:00:24 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1546528570909969.1907395570807; Thu, 3 Jan 2019 07:16:10 -0800 (PST) Received: from localhost ([127.0.0.1]:55240 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gf4jB-00017f-PU for importer@patchew.org; Thu, 03 Jan 2019 10:16:09 -0500 Received: from eggs.gnu.org ([208.118.235.92]:34407) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gf22C-0005FV-Eq for qemu-devel@nongnu.org; Thu, 03 Jan 2019 07:23:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gf229-0004Cd-9d for qemu-devel@nongnu.org; Thu, 03 Jan 2019 07:23:36 -0500 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]:40604) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gf228-0004Bi-S8 for qemu-devel@nongnu.org; Thu, 03 Jan 2019 07:23:33 -0500 Received: by mail-wm1-x343.google.com with SMTP id f188so30104076wmf.5 for ; Thu, 03 Jan 2019 04:23:32 -0800 (PST) Received: from bark.daynix ([141.226.163.173]) by smtp.gmail.com with ESMTPSA id t76sm72325798wme.33.2019.01.03.04.23.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 Jan 2019 04:23:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=BeznIJQALwc/PDSYm8fp48HdMnQYcXjdvDBCvgmRVC4=; b=R64hqXq7EPO4ElT//qZRDirEJVDOi/RBV3hJZMFnT0Sv3WbQmcfuHjU1dh5HxbzXvA YJ7IifmTU3kYAkF/CfkRpId0AgDAsiBGFIfvFaHpYTodSzdKbp3XB3DnP6sv72pBPXd9 ExBZ6kzzmlGRVy0BG3d7QBCFWaYtDtXhzBInfCbjyr4aTyCWDM/ts1Pnq5brd4lfDUGz x80uCinf6+ETJ6FlW5JLQh0dgp/MLp94OCe40hkc4A2GT5j0Y1D5D9ovYNNtZ0TF1/Nw o8r/D8Afl56l3MThyvO0AUCfDN3rWR7KsY6bXMcJut3wn1Cl1kC6ybPVMxMizOjk1l94 mKyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=BeznIJQALwc/PDSYm8fp48HdMnQYcXjdvDBCvgmRVC4=; b=Lb5AoQcO4eSSNeeYXV8l6AhM9XeNuA61cr0InO+5n5i53iGk4JPCLZc42alPcBprzX n1srUxlYFA6LnBrvnBAiYzRHlkh7VCSTPprt3emIVhFQdhm2COjh/UmUzaxTa3JWMJ4O HrzVdb0yn8NElOe0AV3Ts3whGbJn4iI0KeP7sDXIn9y4gMZIgVjKXkjsikuKxH4gGl2r ox+GSEm1ggcM/03zNgEYAI3Q8Hyvza0Q/cHAlfN7TQALRCT2AfkGgl/XeAIJF6x82LQH UvbPwTvLRjgAlQd6qwGfJYXlh9qHM2sM8C9ShSqZQ5H19wzqXlF+Q7FYcloYg2JH0lHD h1qw== X-Gm-Message-State: AA+aEWYyh4Y9/YI5qEPzDGASYcf+9m2tm+NEUiZo1LM94kU5aFGvMRnw 7GEAd1hwgvS7EpcDFPNH8maXpYRt3u0tLQ== X-Google-Smtp-Source: ALg8bN4NJFaJ2mMsLNr87QohZBhHeT9AB0gRxmFLkN7yI8Z2zEo/sPOCsB1lBGLQu/NwnQgDTeReZw== X-Received: by 2002:a1c:e913:: with SMTP id q19mr39260102wmc.55.1546518211648; Thu, 03 Jan 2019 04:23:31 -0800 (PST) From: Basil Salman To: qemu-devel@nongnu.org, Michael Roth Date: Thu, 3 Jan 2019 14:23:21 +0200 Message-Id: <20190103122323.1273034-3-basil@daynix.com> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190103122323.1273034-1-basil@daynix.com> References: <20190103122323.1273034-1-basil@daynix.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::343 X-Mailman-Approved-At: Thu, 03 Jan 2019 10:10:24 -0500 Subject: [Qemu-devel] [PATCH 2/4] qga: fix send_response error handling X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yan Vugenfirer , Bishara AbuHattoum Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Sometimes qemu-ga fails to send a response to client due to memory allocati= on issues due to a large response message, this can be experienced while trying to read large number of bytes using QMP command guest-file-read. Added a check to send an error response to qemu-ga client in such cases. Signed-off-by: Basil Salman --- qga/main.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/qga/main.c b/qga/main.c index 87a0711c14..964275c40c 100644 --- a/qga/main.c +++ b/qga/main.c @@ -561,6 +561,8 @@ static void process_command(GAState *s, QDict *req) { QDict *rsp; int ret; + QDict *ersp; + Error *err =3D NULL; =20 g_assert(req); g_debug("processing command"); @@ -569,9 +571,20 @@ static void process_command(GAState *s, QDict *req) ret =3D send_response(s, rsp); if (ret < 0) { g_warning("error sending response: %s", strerror(-ret)); + goto err; } qobject_unref(rsp); } + return; +err: + error_setg(&err, "Insufficient system resources exist to " + "complete the requested service"); + ersp =3D qmp_error_response(err); + ret =3D send_response(s, ersp); + if (ret < 0) { + g_warning("error sending error response: %s", strerror(-ret)); + } + qobject_unref(ersp); } =20 /* handle requests/control events coming in over the channel */ --=20 2.17.2