From nobody Fri Nov 7 03:55:10 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1546420621923662.3051916929655; Wed, 2 Jan 2019 01:17:01 -0800 (PST) Received: from localhost ([127.0.0.1]:43147 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gece3-0007cL-Vt for importer@patchew.org; Wed, 02 Jan 2019 04:17:00 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41462) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gecbq-0005rB-Tc for qemu-devel@nongnu.org; Wed, 02 Jan 2019 04:14:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gecbo-0007pV-Ny for qemu-devel@nongnu.org; Wed, 02 Jan 2019 04:14:42 -0500 Received: from chuckie.co.uk ([82.165.15.123]:60455 helo=s16892447.onlinehome-server.info) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gecbo-0007p9-HM; Wed, 02 Jan 2019 04:14:40 -0500 Received: from host86-138-87-125.range86-138.btcentralplus.com ([86.138.87.125] helo=kentang.home) by s16892447.onlinehome-server.info with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1gecc2-0008OT-EZ; Wed, 02 Jan 2019 09:14:55 +0000 From: Mark Cave-Ayland To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, richard.henderson@linaro.org, david@gibson.dropbear.id.au Date: Wed, 2 Jan 2019 09:14:16 +0000 Message-Id: <20190102091423.21155-3-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190102091423.21155-1-mark.cave-ayland@ilande.co.uk> References: <20190102091423.21155-1-mark.cave-ayland@ilande.co.uk> X-SA-Exim-Connect-IP: 86.138.87.125 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk X-SA-Exim-Version: 4.2.1 (built Sun, 08 Jan 2012 02:45:44 +0000) X-SA-Exim-Scanned: Yes (on s16892447.onlinehome-server.info) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 82.165.15.123 Subject: [Qemu-devel] [PATCH v5 2/9] target/ppc: switch EXTRACT_HELPER macros over to use sextract32/extract32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" These ensure that we consistently handle signed and unsigned extensions cor= rectly when decoding immediates from instruction opcodes. Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson --- target/ppc/internal.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/ppc/internal.h b/target/ppc/internal.h index 8b35863549..5d460247e2 100644 --- a/target/ppc/internal.h +++ b/target/ppc/internal.h @@ -52,20 +52,20 @@ FUNC_MASK(mask_u64, uint64_t, 64, UINT64_MAX); #define EXTRACT_HELPER(name, shift, nb) = \ static inline uint32_t name(uint32_t opcode) = \ { = \ - return (opcode >> (shift)) & ((1 << (nb)) - 1); = \ + return extract32(opcode, shift, nb); = \ } =20 #define EXTRACT_SHELPER(name, shift, nb) = \ static inline int32_t name(uint32_t opcode) = \ { = \ - return (int16_t)((opcode >> (shift)) & ((1 << (nb)) - 1)); = \ + return sextract32(opcode, shift, nb); = \ } =20 #define EXTRACT_HELPER_SPLIT(name, shift1, nb1, shift2, nb2) = \ static inline uint32_t name(uint32_t opcode) = \ { = \ - return (((opcode >> (shift1)) & ((1 << (nb1)) - 1)) << nb2) | = \ - ((opcode >> (shift2)) & ((1 << (nb2)) - 1)); = \ + return extract32(opcode, shift1, nb1) << nb2 | = \ + extract32(opcode, shift2, nb2); = \ } =20 #define EXTRACT_HELPER_SPLIT_3(name, = \ --=20 2.11.0